From: "H.J. Lu" <hjl.tools@gmail.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: [RFC] DT_X86_64_PLT* dependency
Date: Fri, 29 Sep 2023 08:16:16 -0700 [thread overview]
Message-ID: <CAMe9rOrGNtG_1aO3A=_7c1HyJzZy9D3saESCxrqndut8qpUBsQ@mail.gmail.com> (raw)
Hi,
I checked in a linker patch:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=832ca732b8a96ff9a3e7c4abf24098bf2a59a96d
to generate DT_X86_64_PLT, DT_X86_64_PLTSZ and DT_X86_64_PLTENT for
https://gitlab.com/x86-psABIs/x86-64-ABI/-/commit/6d824a52a42d173eb838b879616c1be5870b593e
When these tags are generated, the r_addend field of the R_X86_64_JUMP_SLOT
relocation stores the offset of the indirect branch instruction. However, glibc
versions which don't have this commit in glibc 2.36:
commit f8587a61892cbafd98ce599131bf4f103466f084
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Fri May 20 19:21:48 2022 -0700
x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
According to x86-64 psABI, r_addend should be ignored for R_X86_64_GLOB_DAT
and R_X86_64_JUMP_SLOT. Since linkers always set their r_addends to 0, we
can ignore their r_addends.
Reviewed-by: Fangrui Song <maskray@google.com>
won't ignore the r_addend value in the R_X86_64_JUMP_SLOT relocation. Such
binaries will fail to run with these versions of glibc. I am working
on a linker patch
to add a glibc version dependency similar to GLIBC_ABI_DT_RELR for DT_RELR.
Although this commit has been backported to glibc 2.33/2.34/2.35
release branches,
there may be 2.33/2.34/2.35 glibc binaries without the fix. Should
binaries with
DT_X86_64_PLT tags depend on glibc 2.36 or 2.33?
Thanks.
--
H.J.
next reply other threads:[~2023-09-29 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 15:16 H.J. Lu [this message]
2023-10-02 10:26 ` Florian Weimer
2023-10-03 7:44 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrGNtG_1aO3A=_7c1HyJzZy9D3saESCxrqndut8qpUBsQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).