From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=NHeG=3T=gmail.com=hjl.tools@sourceware.org>
Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35])
	by sourceware.org (Postfix) with ESMTPS id 6C59038432C9
	for <libc-alpha@sourceware.org>; Sat, 19 Nov 2022 00:08:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C59038432C9
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-14286d5ebc3so4507753fac.3
        for <libc-alpha@sourceware.org>; Fri, 18 Nov 2022 16:08:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=XDIl09XJYi9ZpGSynQWnYBoOI5YYhkttyDX+6QraKr0=;
        b=GtCMWC11WEUSmcL4CTSBIpE9cXyu9wqGNQrHC8rIqANI50LfhA5E2oSvIzAbbxD/q4
         Gsa6bUeV1J+V/JryI/aqCM8KOjBRr6dKZ+lCSLduGPqxCsGe+LmFz629GzmBoOBJ++YO
         pGpdupoayLlcdrh95fBcuq41+dXD78jxbrbw5H4IOiVm/cuhGHtkFWLSPrQNNa5naPwB
         AWd0gug2U89fDqk1YUHBIIq6VNOgtypqzj0k6ZCbEYxD23rJcn29Azc3MgSZ1oVWLk2a
         0odaV8FJonKZTN2Brx6MrMB72bwhhZt8UXboYKf2CKbbLgM7ESoaEK+3FJWdHr4DD6CV
         YGnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=XDIl09XJYi9ZpGSynQWnYBoOI5YYhkttyDX+6QraKr0=;
        b=TGwPRbI6IPKveV5kWvgFtxnqpD+IvBMWvqxr3k3ktQSEM+1dBzJMFZcKpDk6O/QVc1
         1YucQctoRkQt/FL+F9PbKTM2HIaF6F5AkYKtiQyRG/RBX+0TpyxQXe+G+5nt/j8VOcby
         3+w82Ri4mn1IOIFwI+fOXyUqErIJSlJK42kTWivdZRIO5BL0u4qnPhedmAwW+zC8FWph
         q0icM6E8jlrcr0b3m8/oZu9zCH+OKHXHj0BeSxQWmbnyCuqhbfYBrcdVUvmkFSOFlk5m
         sj55tqeQGxZx5ucVZRPIlc2NH4Kuu0fg8SnDP+5tcWCWKiWUTkxh6d9uKmsSMDezY7eG
         zNVg==
X-Gm-Message-State: ANoB5pm6g0VW6pn+M/oF8EyAYR+6jlearxCuyvcJkVDVYVfbtumBqy80
	zLwe6ZmiCIoynEzOlznf4mCYPPE/tgQOaz1dDRQ=
X-Google-Smtp-Source: AA0mqf7hXvowuis3zHet1UcsLpp19tHS8HXZWNv5IFHXJtVi8nnP66RO5LEHFvBa/qXB6CtXobvzY0f+Ig2j/QUmfpQ=
X-Received: by 2002:a05:6871:4501:b0:13c:5da4:7229 with SMTP id
 nj1-20020a056871450100b0013c5da47229mr5386950oab.266.1668816511829; Fri, 18
 Nov 2022 16:08:31 -0800 (PST)
MIME-Version: 1.0
References: <20221118190835.1033248-1-goldstein.w.n@gmail.com>
 <20221118212255.1305681-1-goldstein.w.n@gmail.com> <20221118212255.1305681-3-goldstein.w.n@gmail.com>
 <CAMe9rOqoAToEsDtTst4hT=Qt_uouVr02+wRhTbgQUQhkraO01A@mail.gmail.com> <CAFUsyfJYziJtdLX4jfmAQt3GnozaQGp2KD=eDGOWyP78UqRbhQ@mail.gmail.com>
In-Reply-To: <CAFUsyfJYziJtdLX4jfmAQt3GnozaQGp2KD=eDGOWyP78UqRbhQ@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 18 Nov 2022 16:07:56 -0800
Message-ID: <CAMe9rOrH757C7uYXYDb_toLiK+9q71hqX+TSEWr7wh21srKfXA@mail.gmail.com>
Subject: Re: [PATCH v4 3/3] x86/fpu: Factor out shared avx2/avx512 code in svml_{s|d}_wrapper_impl.h
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: libc-alpha@sourceware.org, andrey.kolesov@intel.com, 
	carlos@systemhalted.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3016.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Fri, Nov 18, 2022 at 1:59 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Fri, Nov 18, 2022 at 1:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Fri, Nov 18, 2022 at 1:23 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > Code is exactly the same for the two so better to only maintain one
> > > version.
> > >
> > > All math and mathvec tests pass on x86.
> >
> > Is the output of "objdump -dw" on libmvec.so the same before and after
> > the patch?
> >
>
> Yes for both libmvec.so and libm.so.

Please mention this in the commit log.  OK with the change.

Thanks.

-- 
H.J.