glibc master won't build with GCC 10

glibc master won't build with GCC 10

[H.J. Lu]

commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue Apr 28 12:10:32 2020 +0200

    misc: Remove sstk from the autogenerated system call list

    This change should not have an effect because the system call was
    never defined.  Also add the misssing attribute_compat_text_section
    attribute to the sstk function (a minor optimization).  Also update the
    NEWS file to document the change.

    Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
    ("misc: Turn sstk into a compat symbol").

won't build with GCC 10:

rtld.c: In function ‘dl_main’:
rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
an interior zero-length array ‘struct auditstate[0]’
[-Werror=zero-length-bounds]
 1016 |    GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
In file included from ../include/dlfcn.h:4,
                 from rtld.c:20:
../include/link.h:335:7: note: while referencing ‘l_audit’
  335 |     } l_audit[0];
      |       ^~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [../o-iterator.mk:9:
/export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
Error 1


-- 
H.J.

Re: glibc master won't build with GCC 10

[Andrew Pinski]

This should have been fixed already:
https://sourceware.org/bugzilla/show_bug.cgi?id=25097

Thanks,
Andrew

On Tue, Apr 28, 2020 at 3:54 PM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
> Author: Florian Weimer <fweimer@redhat.com>
> Date:   Tue Apr 28 12:10:32 2020 +0200
>
>     misc: Remove sstk from the autogenerated system call list
>
>     This change should not have an effect because the system call was
>     never defined.  Also add the misssing attribute_compat_text_section
>     attribute to the sstk function (a minor optimization).  Also update the
>     NEWS file to document the change.
>
>     Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
>     ("misc: Turn sstk into a compat symbol").
>
> won't build with GCC 10:
>
> rtld.c: In function ‘dl_main’:
> rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
> an interior zero-length array ‘struct auditstate[0]’
> [-Werror=zero-length-bounds]
>  1016 |    GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
> In file included from ../include/dlfcn.h:4,
>                  from rtld.c:20:
> ../include/link.h:335:7: note: while referencing ‘l_audit’
>   335 |     } l_audit[0];
>       |       ^~~~~~~
> cc1: all warnings being treated as errors
> make[5]: *** [../o-iterator.mk:9:
> /export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
> Error 1
>
>
> --
> H.J.

Re: glibc master won't build with GCC 10

[Florian Weimer]

* Andrew Pinski via Libc-alpha:

> This should have been fixed already:
> https://sourceware.org/bugzilla/show_bug.cgi?id=25097
>
> Thanks,
> Andrew
>
> On Tue, Apr 28, 2020 at 3:54 PM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
>> Author: Florian Weimer <fweimer@redhat.com>
>> Date:   Tue Apr 28 12:10:32 2020 +0200
>>
>>     misc: Remove sstk from the autogenerated system call list
>>
>>     This change should not have an effect because the system call was
>>     never defined.  Also add the misssing attribute_compat_text_section
>>     attribute to the sstk function (a minor optimization).  Also update the
>>     NEWS file to document the change.
>>
>>     Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
>>     ("misc: Turn sstk into a compat symbol").
>>
>> won't build with GCC 10:
>>
>> rtld.c: In function ‘dl_main’:
>> rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
>> an interior zero-length array ‘struct auditstate[0]’
>> [-Werror=zero-length-bounds]
>>  1016 |    GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
>> In file included from ../include/dlfcn.h:4,
>>                  from rtld.c:20:
>> ../include/link.h:335:7: note: while referencing ‘l_audit’
>>   335 |     } l_audit[0];
>>       |       ^~~~~~~
>> cc1: all warnings being treated as errors
>> make[5]: *** [../o-iterator.mk:9:
>> /export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
>> Error 1

Agreed, this error doesn't look like something from glibc master to
me.  master does not contain the string “l_audit[0]” anymore.

Re: glibc master won't build with GCC 10

[H.J. Lu]

On Wed, Apr 29, 2020 at 3:31 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * Andrew Pinski via Libc-alpha:
>
> > This should have been fixed already:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=25097
> >
> > Thanks,
> > Andrew
> >
> > On Tue, Apr 28, 2020 at 3:54 PM H.J. Lu via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> >>
> >> commit 6d246cb852d3c5ab721dc583112a59ac47dc374e
> >> Author: Florian Weimer <fweimer@redhat.com>
> >> Date:   Tue Apr 28 12:10:32 2020 +0200
> >>
> >>     misc: Remove sstk from the autogenerated system call list
> >>
> >>     This change should not have an effect because the system call was
> >>     never defined.  Also add the misssing attribute_compat_text_section
> >>     attribute to the sstk function (a minor optimization).  Also update the
> >>     NEWS file to document the change.
> >>
> >>     Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
> >>     ("misc: Turn sstk into a compat symbol").
> >>
> >> won't build with GCC 10:
> >>
> >> rtld.c: In function ‘dl_main’:
> >> rtld.c:1016:27: error: array subscript ‘cnt’ is outside the bounds of
> >> an interior zero-length array ‘struct auditstate[0]’
> >> [-Werror=zero-length-bounds]
> >>  1016 |    GL(dl_rtld_map).l_audit[cnt].cookie = (intptr_t) &GL(dl_rtld_map);
> >> In file included from ../include/dlfcn.h:4,
> >>                  from rtld.c:20:
> >> ../include/link.h:335:7: note: while referencing ‘l_audit’
> >>   335 |     } l_audit[0];
> >>       |       ^~~~~~~
> >> cc1: all warnings being treated as errors
> >> make[5]: *** [../o-iterator.mk:9:
> >> /export/build/gnu/tools-build/glibc/build-x86_64-linux/elf/rtld.os]
> >> Error 1
>
> Agreed, this error doesn't look like something from glibc master to
> me.  master does not contain the string “l_audit[0]” anymore.

Never mind.  Pilot error.

-- 
H.J.