From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-il1-x143.google.com (mail-il1-x143.google.com
 [IPv6:2607:f8b0:4864:20::143])
 by sourceware.org (Postfix) with ESMTPS id 26C1E3857C68
 for <libc-alpha@sourceware.org>; Thu, 16 Jul 2020 16:01:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 26C1E3857C68
Received: by mail-il1-x143.google.com with SMTP id r12so5497619ilh.4
 for <libc-alpha@sourceware.org>; Thu, 16 Jul 2020 09:01:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=2wHwLZYlTOtiekt7hudf0koUeIbcjvlyT6yfQ/gDaWY=;
 b=snRiwuDEE8LbFavySl+Az2bgCoh6oBVS3DUlQNnr6NPUHULblXAahWWvJ2mJ/bvbe8
 5ajI30Q/Mbyr17GeDgMThVHaIoH6G1EHna80Bg6iYhQfQxJ0ZyIyxTDDH1jax91qLrY0
 +pKSZQ43aViYu27wcRhIijg/VVv4M1nYu8u3YpqXcZmo3oEvE9dHTyeysm6MaVcsDSCI
 2oGDsmayCZ1NnK3RHeHISml78ZiwI1sgITT5YZE0ujPTS6v4+J+pyBX6oIUSPRMeB/U9
 Nh3C6w/IMQIAl45l/M2hwgKHLKhR5IM1cwu1O1Df6UJ/cxez34m+u7/sR0h0DKcHoSYI
 IfSw==
X-Gm-Message-State: AOAM533dlBQJIZCf93stE1HyXY9tsrOIbu4o8qCvUKQLYdH2LZz4F++U
 MyD/2tyC8LNsBiWVsqMHo0F/i5zAD6NXuP57feo=
X-Google-Smtp-Source: ABdhPJzXigqwOOB1QmHuM9Z5BoF6aIU9qFXke/rnv3+Gp174M35FZW7MpE5exmQNE/CJ0nVNC2rQ6AcG2q8Oq56bRVk=
X-Received: by 2002:a92:874a:: with SMTP id d10mr5337957ilm.273.1594915278553; 
 Thu, 16 Jul 2020 09:01:18 -0700 (PDT)
MIME-Version: 1.0
References: <20200716112651.2257283-1-hjl.tools@gmail.com>
 <87o8ofy8e7.fsf@oldenburg2.str.redhat.com>
 <CAMe9rOo8K3D+pNabZy+F6wKkT-N2M64eNASOFpq5uK9Ghnq86Q@mail.gmail.com>
 <87d04vxxk6.fsf@oldenburg2.str.redhat.com>
In-Reply-To: <87d04vxxk6.fsf@oldenburg2.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 16 Jul 2020 09:00:42 -0700
Message-ID: <CAMe9rOrJZF4yMGH_KXeeVtwnjPAW6v6qC4OcUh1N5z=WhNVYGQ@mail.gmail.com>
Subject: Re: [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248]
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jul 2020 16:01:20 -0000

On Thu, Jul 16, 2020 at 8:57 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> >> Isn't it sufficient to change the type of id to unsigned long int[3]?
> >> The UID arguments are unsigned on the kernel side, so no sign extension
> >> is required.
> >
> > It works.  Here is the updated patch.  OK for master?
>
> Does the test work if the list of supplementary groups is empty?
>

My patch turns:

setgroups(0, bad address);

into

setgroups(0, good address);

It should be OK.

-- 
H.J.