public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] x86: Remove unused variables for raw cache sizes
@ 2020-12-21 17:08 Florian Weimer
  2021-02-22 14:53 ` H.J. Lu
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2020-12-21 17:08 UTC (permalink / raw)
  To: libc-alpha

---
 sysdeps/x86/cacheinfo.h | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/sysdeps/x86/cacheinfo.h b/sysdeps/x86/cacheinfo.h
index 0aec0e2875..4c710f3c6c 100644
--- a/sysdeps/x86/cacheinfo.h
+++ b/sysdeps/x86/cacheinfo.h
@@ -23,18 +23,10 @@
    L1 size, rounded to multiple of 256 bytes.  */
 long int __x86_data_cache_size_half attribute_hidden = 32 * 1024 / 2;
 long int __x86_data_cache_size attribute_hidden = 32 * 1024;
-/* Similar to __x86_data_cache_size_half, but not rounded.  */
-long int __x86_raw_data_cache_size_half attribute_hidden = 32 * 1024 / 2;
-/* Similar to __x86_data_cache_size, but not rounded.  */
-long int __x86_raw_data_cache_size attribute_hidden = 32 * 1024;
 /* Shared cache size for use in memory and string routines, typically
    L2 or L3 size, rounded to multiple of 256 bytes.  */
 long int __x86_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;
 long int __x86_shared_cache_size attribute_hidden = 1024 * 1024;
-/* Similar to __x86_shared_cache_size_half, but not rounded.  */
-long int __x86_raw_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;
-/* Similar to __x86_shared_cache_size, but not rounded.  */
-long int __x86_raw_shared_cache_size attribute_hidden = 1024 * 1024;
 
 /* Threshold to use non temporal store.  */
 long int __x86_shared_non_temporal_threshold attribute_hidden;
@@ -360,8 +352,6 @@ init_cacheinfo (void)
 
   if (data > 0)
     {
-      __x86_raw_data_cache_size_half = data / 2;
-      __x86_raw_data_cache_size = data;
       /* Round data cache size to multiple of 256 bytes.  */
       data = data & ~255L;
       __x86_data_cache_size_half = data / 2;
@@ -374,8 +364,6 @@ init_cacheinfo (void)
 
   if (shared > 0)
     {
-      __x86_raw_shared_cache_size_half = shared / 2;
-      __x86_raw_shared_cache_size = shared;
       /* Round shared cache size to multiple of 256 bytes.  */
       shared = shared & ~255L;
       __x86_shared_cache_size_half = shared / 2;

-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: Remove unused variables for raw cache sizes
  2020-12-21 17:08 [PATCH] x86: Remove unused variables for raw cache sizes Florian Weimer
@ 2021-02-22 14:53 ` H.J. Lu
  0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2021-02-22 14:53 UTC (permalink / raw)
  To: Florian Weimer; +Cc: GNU C Library

On Mon, Dec 21, 2020 at 9:09 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> ---
>  sysdeps/x86/cacheinfo.h | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/sysdeps/x86/cacheinfo.h b/sysdeps/x86/cacheinfo.h
> index 0aec0e2875..4c710f3c6c 100644
> --- a/sysdeps/x86/cacheinfo.h
> +++ b/sysdeps/x86/cacheinfo.h
> @@ -23,18 +23,10 @@
>     L1 size, rounded to multiple of 256 bytes.  */
>  long int __x86_data_cache_size_half attribute_hidden = 32 * 1024 / 2;
>  long int __x86_data_cache_size attribute_hidden = 32 * 1024;
> -/* Similar to __x86_data_cache_size_half, but not rounded.  */
> -long int __x86_raw_data_cache_size_half attribute_hidden = 32 * 1024 / 2;
> -/* Similar to __x86_data_cache_size, but not rounded.  */
> -long int __x86_raw_data_cache_size attribute_hidden = 32 * 1024;
>  /* Shared cache size for use in memory and string routines, typically
>     L2 or L3 size, rounded to multiple of 256 bytes.  */
>  long int __x86_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;
>  long int __x86_shared_cache_size attribute_hidden = 1024 * 1024;
> -/* Similar to __x86_shared_cache_size_half, but not rounded.  */
> -long int __x86_raw_shared_cache_size_half attribute_hidden = 1024 * 1024 / 2;
> -/* Similar to __x86_shared_cache_size, but not rounded.  */
> -long int __x86_raw_shared_cache_size attribute_hidden = 1024 * 1024;
>
>  /* Threshold to use non temporal store.  */
>  long int __x86_shared_non_temporal_threshold attribute_hidden;
> @@ -360,8 +352,6 @@ init_cacheinfo (void)
>
>    if (data > 0)
>      {
> -      __x86_raw_data_cache_size_half = data / 2;
> -      __x86_raw_data_cache_size = data;
>        /* Round data cache size to multiple of 256 bytes.  */
>        data = data & ~255L;
>        __x86_data_cache_size_half = data / 2;
> @@ -374,8 +364,6 @@ init_cacheinfo (void)
>
>    if (shared > 0)
>      {
> -      __x86_raw_shared_cache_size_half = shared / 2;
> -      __x86_raw_shared_cache_size = shared;
>        /* Round shared cache size to multiple of 256 bytes.  */
>        shared = shared & ~255L;
>        __x86_shared_cache_size_half = shared / 2;
>

LGTM.

Thanks.

-- 
H.J.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-22 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 17:08 [PATCH] x86: Remove unused variables for raw cache sizes Florian Weimer
2021-02-22 14:53 ` H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).