From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33])
	by sourceware.org (Postfix) with ESMTPS id 702CA38582B7
	for <libc-alpha@sourceware.org>; Fri, 14 Oct 2022 17:32:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 702CA38582B7
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-qv1-xf33.google.com with SMTP id o67so3650356qvo.13
        for <libc-alpha@sourceware.org>; Fri, 14 Oct 2022 10:32:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=ThlmZXPlwMM5ndC3hBhiTZ9zNRXm31MGM88jHsi+ncg=;
        b=Mi7qJg53Wo390jAqH7XSiU+p/VtWMJPQvn5lxqUXoZydve3rxr83AcSFtTFuwCDZNL
         FOGAKMrnkp0Qvs9md6LDHrX0uR1PTwGUO/5TEBy+oC19+zMaiWITJRWWYBKS46QkCzmn
         tNjcZi/2pTkHW0YeAELJYzQU9K0SCRmzgqqBxFn3CMFSuH+vZVNZBWV2Jo703UTPKIp+
         0MCLFx9AgeAQrf4sr50pRfv5hVyM4Ul71hRrPflmsqmrEzYxIg9woqtrpKe2OFhURgvO
         P9H4jwZ4QMY9gRAjRUb/oy0/dqCUjysedUGyRP4d2Kzc6dqVPHNPA+wuScFFTK9Rntpc
         +BoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=ThlmZXPlwMM5ndC3hBhiTZ9zNRXm31MGM88jHsi+ncg=;
        b=MvhWtUjwEHAf5Kd14gM05FUUK5Elm2LCu1rZqC3KUO4rrOLSXgb/E0xXBkJvV0MWI4
         s5f78hPAtp1Z8WIDIoF4nAWvo6466ZXsJ4Q921ulRrFDkq+HH/htEBgF2onqa8V9uLbi
         TlCIlfqZwbRlEYaUuvASrEgwFLavL1s52ME55pAOrP5Kx8E6rNMMDNEblaxvAOTqCRhN
         8ypn5tMApD5RSW7T0HZcggVY/+/jxOItSNREw0a1tqfECf8odeBFRAx5w+x9I+kFAIfn
         quey53cjDW4f01lRjl7h5JSmNB4abPc8ryBdFzQleyi4TrGsBo5DW6+3i8bAzR4bat0V
         MTKA==
X-Gm-Message-State: ACrzQf38YGhg46QotPzOgUkFN8MdGwD4nVMIW87qpJw0N/UKTl4X9VGP
	YrUGifk4OYy2Gh3rMCk7OineoWzCf080QXvrtDI=
X-Google-Smtp-Source: AMsMyM4ShUrAz7TgdVq70BR8lYhWRaBMzYDrbE8l0IL8YoNbo/yV9YLA5fqgEM5WL7BMC4J1F1iZFTJ4N3nv9LXfE1w=
X-Received: by 2002:ad4:4ee4:0:b0:4b1:d60b:c830 with SMTP id
 dv4-20020ad44ee4000000b004b1d60bc830mr5118137qvb.84.1665768734774; Fri, 14
 Oct 2022 10:32:14 -0700 (PDT)
MIME-Version: 1.0
References: <20221014164008.1325863-1-goldstein.w.n@gmail.com>
In-Reply-To: <20221014164008.1325863-1-goldstein.w.n@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 14 Oct 2022 10:31:39 -0700
Message-ID: <CAMe9rOrLjxKqgKPOA-XoOLFmXGnRSzZHYz7Ef_JdcYu61RP8+w@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] x86: Update evex256/512 vec macros
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: libc-alpha@sourceware.org, carlos@systemhalted.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3024.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Fri, Oct 14, 2022 at 9:40 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> 1) Make section only define if there is not a previous definition
> 2) Add `VEC_lo` definition for proper reg-width but in the
>    ymm/zmm0-15 range.
>
> This commit does not change libc.so
>
> Tested build on x86-64
> ---
>  sysdeps/x86_64/multiarch/evex256-vecs.h | 7 +++++--
>  sysdeps/x86_64/multiarch/evex512-vecs.h | 7 +++++--
>  2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/sysdeps/x86_64/multiarch/evex256-vecs.h b/sysdeps/x86_64/multiarch/evex256-vecs.h
> index 222ba46dc7..4fccabd4b8 100644
> --- a/sysdeps/x86_64/multiarch/evex256-vecs.h
> +++ b/sysdeps/x86_64/multiarch/evex256-vecs.h
> @@ -28,8 +28,11 @@
>  #include "evex-vecs-common.h"
>
>  #define USE_WITH_EVEX256       1
> -#define SECTION(p)                     p##.evex
>
> -#define VEC                                    VEC_ymm
> +#ifndef SECTION
> +# define SECTION(p)                    p##.evex
> +#endif
>
> +#define VEC                                    VEC_ymm
> +#define VEC_lo                         VEC_any_ymm
>  #endif
> diff --git a/sysdeps/x86_64/multiarch/evex512-vecs.h b/sysdeps/x86_64/multiarch/evex512-vecs.h
> index d1784d5368..fecc2d3925 100644
> --- a/sysdeps/x86_64/multiarch/evex512-vecs.h
> +++ b/sysdeps/x86_64/multiarch/evex512-vecs.h
> @@ -28,8 +28,11 @@
>  #include "evex-vecs-common.h"
>
>  #define USE_WITH_EVEX512       1
> -#define SECTION(p)                     p##.evex512
>
> -#define VEC                                    VEC_zmm
> +#ifndef SECTION
> +# define SECTION(p)                    p##.evex512
> +#endif
>
> +#define VEC                                    VEC_zmm
> +#define VEC_lo                         VEC_any_zmm
>  #endif
> --
> 2.34.1
>

LGTM.

Thanks.

-- 
H.J.