From: "H.J. Lu" <hjl.tools@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Mark internal functions with attribute_hidden
Date: Tue, 22 Aug 2017 17:58:00 -0000 [thread overview]
Message-ID: <CAMe9rOrM0mptQkX28JhRkEAmCtz2B7fHHvbbBZNfwXmsfc3rsw@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOr39bsXStfuXoP9F8aaPyq5gSdu3WmJUQ+2gjA_AEKYpQ@mail.gmail.com>
On Thu, Aug 17, 2017 at 11:57 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Aug 17, 2017 at 7:01 AM, Joseph Myers <joseph@codesourcery.com> wrote:
>> On Thu, 17 Aug 2017, H.J. Lu wrote:
>>
>>> Yes, this is target independent. It should benefit static PIE build for all
>>> targets. On x86, it bypasses GOT/PLT.
>>
>> Specifically, on x86 I'd consider this (making functions hidden if they
>> are not exported from the shared library containing their definitions) to
>> be part of the fix for bug 18822.
>>
>
> You are right. Here is the same patch with libc.so size comparison on
> i686 and x86-64.
>
> OK for trunk?
>
>
Any comments or objections?
--
H.J.
prev parent reply other threads:[~2017-08-22 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 12:25 H.J. Lu
2017-08-17 12:37 ` Florian Weimer
2017-08-17 12:43 ` H.J. Lu
2017-08-17 13:12 ` Zack Weinberg
2017-08-17 13:19 ` H.J. Lu
2017-08-17 13:35 ` Florian Weimer
2017-08-17 14:02 ` Joseph Myers
2017-08-17 18:58 ` H.J. Lu
2017-08-22 17:58 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrM0mptQkX28JhRkEAmCtz2B7fHHvbbBZNfwXmsfc3rsw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).