From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98419 invoked by alias); 3 Apr 2018 20:51:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 98344 invoked by uid 89); 3 Apr 2018 20:51:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ot0-f194.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YpNbFR8f9esGP2/+ID27qYOEK7UrgmD47C7ciGGWiZ8=; b=ENtNYZSPQuD0ync2N3Z7y+BI0ZTiP6o3AVMpXypUarpEkhf9LLV34GderGboJ+Iu8F n37XvG/nJ5aeS2PR1PV9tsxVBMS8KTXdxnrbaAhFtS+Fk6+EJzY0089ke/b0oZiI3kbG p35QR9Dq+PfQqQnzb7rPbDXeVgzLzL96AwwD7MzuJdB/YlCt7ohcvmObIc2PL9Su2yEp DHfrfXsiJFSxU3nKdKrBrtZ3tN/3bYM458PYMM7IKQBLcaU+0FeX6hrjtVUO8j3syIru EC62++KLb5L2xhMin5FOMpK+GR9I73OF94Xi/60HJzO3nYBUOoxOKZAovY+oOqop3nol wzXA== X-Gm-Message-State: ALQs6tB1CLRYt3NZkmmisl3ueGeiDpD/siblhpQ1zIAj/KTjRDBXxLJM iZj9CV0x8rb28ZYi09qnEcmFSY4V63QTxiRUATZFcg== X-Google-Smtp-Source: AIpwx4+2PjogLJ9g7QVXNE5szxxid0K9dEAxDtpHCNcsh75AhwV0sLM6we7FFBT8YerNGIJr0Yrtayg5cJ+y/AASsPI= X-Received: by 2002:a9d:720a:: with SMTP id u10-v6mr9556429otj.332.1522788705475; Tue, 03 Apr 2018 13:51:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20180403003817.21337-1-samuel.thibault@ens-lyon.org> <20180403082029.g3bfw4upbti67wwz@var.youpi.perso.aquilenet.fr> From: "H.J. Lu" Date: Tue, 03 Apr 2018 20:51:00 -0000 Message-ID: Subject: Re: [hurd,commited] hurd: Avoid more libc.so local PLTs To: Samuel Thibault Cc: Andreas Schwab , GNU C Library Content-Type: multipart/mixed; boundary="000000000000dbd08d0568f7dfeb" X-SW-Source: 2018-04/txt/msg00073.txt.bz2 --000000000000dbd08d0568f7dfeb Content-Type: text/plain; charset="UTF-8" Content-length: 2163 On Tue, Apr 3, 2018 at 12:26 PM, H.J. Lu wrote: > On Tue, Apr 3, 2018 at 1:20 AM, Samuel Thibault > wrote: >> Andreas Schwab, on mar. 03 avril 2018 10:10:21 +0200, wrote: >>> On Apr 03 2018, Samuel Thibault wrote: >>> >>> > * hurd/catch-signal.c (__hurd_catch_signal): Call __libc_siglongjmp >>> > instead if siglongjmp. >>> > (hurd_safe_memmove): Call __libc_longjmp instead of longjmp. >>> > * hurd/hurdfault.c (faulted): Call __libc_longjmp instead of longjmp. >>> > * include/setjmp.h (__libc_siglongjmp, __libc_longjmp): New hidden >>> > prototypes. >>> > * libio/iolibio.h (_IO_puts): New hidden prototype. >>> > * libio/ioputs.c (_IO_puts): New hidden def. >>> > * setjmp/longjmp.c (__libc_longjmp, __libc_siglongjmp): New hidden >>> > defs. >>> > * sysdeps/mach/hurd/sigwait.c (__sigwait): Call __libc_longjmp instead >>> > of longjmp. >>> >>> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/s/s390x >>> >>> In file included from :0:0: >>> ../sysdeps/s390/longjmp.c:35:34: error: '__libc_longjmp' aliased to undefined symbol '__libc_siglongjmp' >>> strong_alias (__libc_siglongjmp, __libc_longjmp) >>> ^ >>> ./../include/libc-symbols.h:135:26: note: in definition of macro '_strong_alias' >>> extern __typeof (name) aliasname __attribute__ ((alias (#name))); >>> ^~~~~~~~~ >>> ../sysdeps/s390/longjmp.c:35:1: note: in expansion of macro 'strong_alias' >>> strong_alias (__libc_siglongjmp, __libc_longjmp) >> >> Ah, there is #define __libc_siglongjmp magic here indeed. Does the >> attached patch fix it? > > __libc_longjmp and __libc_siglongjmp are private external functions provided for > libpthread. They should never be called inside libc. Please revert > it and find another > way to fix hurd. Here is my patch: https://sourceware.org/git/?p=glibc.git;a=commit;h=6253bacdc00de132dec452ff7c6ce3ba7fa23d81 which removed libc_hidden_def (__libc_longjmp) I am going to check in this path. -- H.J. --000000000000dbd08d0568f7dfeb Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Revert-hurd-Avoid-more-libc.so-local-PLTs.patch" Content-Disposition: attachment; filename="0001-Revert-hurd-Avoid-more-libc.so-local-PLTs.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jfk52d560 Content-length: 5596 RnJvbSBjODMyNTc1MWMxNzFlMzU4ODgxZGIyNzYyODA1OWI0OTcwZGIzNjQ5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFR1ZSwgMyBBcHIgMjAxOCAxMzo0 NToyNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydCAiaHVyZDogQXZv aWQgbW9yZSBsaWJjLnNvIGxvY2FsIFBMVHMiCgpUaGlzIHJldmVydHMgY29t bWl0IDgxMTgzNmE0MTFhMWM5N2EwZTcwZTdmMDk2ZTU3ZjMxNmRjMTljNzIg YW5kCmNvbW1pdCA4MmRiZjU1NWE0ZDQxNjkwZjYzYjk0Y2NiNGRiNGJmNDNk ODczYWEwOgoKCSogaHVyZC9jYXRjaC1zaWduYWwuYyAoX19odXJkX2NhdGNo X3NpZ25hbCk6IENhbGwgX19saWJjX3NpZ2xvbmdqbXAKCWluc3RlYWQgaWYg c2lnbG9uZ2ptcC4KCShodXJkX3NhZmVfbWVtbW92ZSk6IENhbGwgX19saWJj X2xvbmdqbXAgaW5zdGVhZCBvZiBsb25nam1wLgoJKiBodXJkL2h1cmRmYXVs dC5jIChmYXVsdGVkKTogQ2FsbCBfX2xpYmNfbG9uZ2ptcCBpbnN0ZWFkIG9m IGxvbmdqbXAuCgkqIGluY2x1ZGUvc2V0am1wLmggKF9fbGliY19zaWdsb25n am1wLCBfX2xpYmNfbG9uZ2ptcCk6IE5ldyBoaWRkZW4KCXByb3RvdHlwZXMu CgkqIHNldGptcC9sb25nam1wLmMgKF9fbGliY19sb25nam1wLCBfX2xpYmNf c2lnbG9uZ2ptcCk6IE5ldyBoaWRkZW4KCWRlZnMuCgkqIHN5c2RlcHMvbWFj aC9odXJkL3NpZ3dhaXQuYyAoX19zaWd3YWl0KTogQ2FsbCBfX2xpYmNfbG9u Z2ptcCBpbnN0ZWFkCglvZiBsb25nam1wLgoJKiBzeXNkZXBzL3MzOTAvbG9u Z2ptcC5jIChfX2xpYmNfbG9uZ2ptcCwgX19saWJjX3NpZ2xvbmdqbXApOiBO ZXcKCWhpZGRlbiBkZWZzLgotLS0KIGh1cmQvY2F0Y2gtc2lnbmFsLmMgICAg ICAgICB8IDQgKystLQogaHVyZC9odXJkZmF1bHQuYyAgICAgICAgICAgIHwg MiArLQogaW5jbHVkZS9zZXRqbXAuaCAgICAgICAgICAgIHwgMyAtLS0KIHNl dGptcC9sb25nam1wLmMgICAgICAgICAgICB8IDIgLS0KIHN5c2RlcHMvbWFj aC9odXJkL3NpZ3dhaXQuYyB8IDIgKy0KIHN5c2RlcHMvczM5MC9sb25nam1w LmMgICAgICB8IDIgLS0KIDYgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25z KCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9odXJkL2NhdGNo LXNpZ25hbC5jIGIvaHVyZC9jYXRjaC1zaWduYWwuYwppbmRleCBhMDBjY2Vm NGZiLi41NmNlODY1MzJkIDEwMDY0NAotLS0gYS9odXJkL2NhdGNoLXNpZ25h bC5jCisrKyBiL2h1cmQvY2F0Y2gtc2lnbmFsLmMKQEAgLTMyLDcgKzMyLDcg QEAgX19odXJkX2NhdGNoX3NpZ25hbCAoc2lnc2V0X3Qgc2lnc2V0LAogICAg ICBpbnN0YW5jZSBjYWxsaW5nIGh1cmRfY2F0Y2hfc2lnbmFsIGFnYWluIHdv dWxkIHRoZW4gZHVtcCBjb3JlLiAgKi8KICAgc2lnam1wX2J1ZiBidWY7CiAg IHZvaWQgdGhyb3cgKGludCBzaWdubywgbG9uZyBpbnQgc2lnY29kZSwgc3Ry dWN0IHNpZ2NvbnRleHQgKnNjcCkKLSAgICB7IF9fbGliY19zaWdsb25nam1w IChidWYsIHNjcC0+c2NfZXJyb3IgPzogRUdSQVRVSVRPVVMpOyB9CisgICAg eyBzaWdsb25nam1wIChidWYsIHNjcC0+c2NfZXJyb3IgPzogRUdSQVRVSVRP VVMpOyB9CiAKICAgc3RydWN0IGh1cmRfc2lnbmFsX3ByZWVtcHRvciBwcmVl bXB0b3IgPQogICAgIHsKQEAgLTEyMSw3ICsxMjEsNyBAQCBodXJkX3NhZmVf bWVtbW92ZSAodm9pZCAqZGVzdCwgY29uc3Qgdm9pZCAqc3JjLCBzaXplX3Qg bmJ5dGVzKQogewogICBqbXBfYnVmIGJ1ZjsKICAgdm9pZCB0aHJvdyAoaW50 IHNpZ25vLCBsb25nIGludCBzaWdjb2RlLCBzdHJ1Y3Qgc2lnY29udGV4dCAq c2NwKQotICAgIHsgX19saWJjX2xvbmdqbXAgKGJ1Ziwgc2NwLT5zY19lcnJv ciA/OiBFR1JBVFVJVE9VUyk7IH0KKyAgICB7IGxvbmdqbXAgKGJ1Ziwgc2Nw LT5zY19lcnJvciA/OiBFR1JBVFVJVE9VUyk7IH0KIAogICBzdHJ1Y3QgaHVy ZF9zaWduYWxfcHJlZW1wdG9yIHNyY19wcmVlbXB0b3IgPQogICAgIHsKZGlm ZiAtLWdpdCBhL2h1cmQvaHVyZGZhdWx0LmMgYi9odXJkL2h1cmRmYXVsdC5j CmluZGV4IGM0MmQ1ZTczOWEuLjM5YTQ1MjI4MTEgMTAwNjQ0Ci0tLSBhL2h1 cmQvaHVyZGZhdWx0LmMKKysrIGIvaHVyZC9odXJkZmF1bHQuYwpAQCAtMTUy LDcgKzE1Miw3IEBAIGZhdWx0ZWQgKHZvaWQpCiAgICAgX19saWJjX2ZhdGFs ICgiQlVHOiB1bmV4cGVjdGVkIGZhdWx0IGluIHNpZ25hbCB0aHJlYWRcbiIp OwogCiAgIF9odXJkc2lnX2ZhdWx0X3ByZWVtcHRvci5zaWduYWxzID0gMDsK LSAgX19saWJjX2xvbmdqbXAgKF9odXJkc2lnX2ZhdWx0X2VudiwgMSk7Cisg IGxvbmdqbXAgKF9odXJkc2lnX2ZhdWx0X2VudiwgMSk7CiB9CiAKIHN0YXRp YyBjaGFyIGZhdWx0c3RhY2tbMTAyNF07CmRpZmYgLS1naXQgYS9pbmNsdWRl L3NldGptcC5oIGIvaW5jbHVkZS9zZXRqbXAuaAppbmRleCA2ODJmZjRiNWE1 Li4yNjNiYzY0YjNkIDEwMDY0NAotLS0gYS9pbmNsdWRlL3NldGptcC5oCisr KyBiL2luY2x1ZGUvc2V0am1wLmgKQEAgLTI0LDkgKzI0LDYgQEAgZXh0ZXJu IHZvaWQgX19saWJjX3NpZ2xvbmdqbXAgKHNpZ2ptcF9idWYgZW52LCBpbnQg dmFsKQogZXh0ZXJuIHZvaWQgX19saWJjX2xvbmdqbXAgKHNpZ2ptcF9idWYg ZW52LCBpbnQgdmFsKQogICAgICBfX2F0dHJpYnV0ZV9fICgobm9yZXR1cm4p KTsKIAotbGliY19oaWRkZW5fcHJvdG8gKF9fbGliY19zaWdsb25nam1wKQot bGliY19oaWRkZW5fcHJvdG8gKF9fbGliY19sb25nam1wKQotCiBsaWJjX2hp ZGRlbl9wcm90byAoX3NldGptcCkKIGxpYmNfaGlkZGVuX3Byb3RvIChfX3Np Z3NldGptcCkKIApkaWZmIC0tZ2l0IGEvc2V0am1wL2xvbmdqbXAuYyBiL3Nl dGptcC9sb25nam1wLmMKaW5kZXggMDU1NWQ2ZDZiNy4uYTJhNzA2NWE4NSAx MDA2NDQKLS0tIGEvc2V0am1wL2xvbmdqbXAuYworKysgYi9zZXRqbXAvbG9u Z2ptcC5jCkBAIC00Niw2ICs0Niw0IEBAIHN0cm9uZ19hbGlhcyAoX19saWJj X3NpZ2xvbmdqbXAsIF9fbGliY19sb25nam1wKQogd2Vha19hbGlhcyAoX19s aWJjX3NpZ2xvbmdqbXAsIF9sb25nam1wKQogd2Vha19hbGlhcyAoX19saWJj X3NpZ2xvbmdqbXAsIGxvbmdqbXApCiB3ZWFrX2FsaWFzIChfX2xpYmNfc2ln bG9uZ2ptcCwgc2lnbG9uZ2ptcCkKLWxpYmNfaGlkZGVuX2RlZiAoX19saWJj X2xvbmdqbXApCi1saWJjX2hpZGRlbl9kZWYgKF9fbGliY19zaWdsb25nam1w KQogI2VuZGlmCmRpZmYgLS1naXQgYS9zeXNkZXBzL21hY2gvaHVyZC9zaWd3 YWl0LmMgYi9zeXNkZXBzL21hY2gvaHVyZC9zaWd3YWl0LmMKaW5kZXggMzIx YWI0NmQxNC4uY2UxN2NjZTg5NSAxMDA2NDQKLS0tIGEvc3lzZGVwcy9tYWNo L2h1cmQvc2lnd2FpdC5jCisrKyBiL3N5c2RlcHMvbWFjaC9odXJkL3NpZ3dh aXQuYwpAQCAtNTksNyArNTksNyBAQCBfX3NpZ3dhaXQgKGNvbnN0IHNpZ3Nl dF90ICpzZXQsIGludCAqc2lnKQogICAgIGhhbmRsZXIgKGludCBzaWcpCiAg ICAgewogICAgICAgYXNzZXJ0IChzaWcgPT0gc2lnbm8pOwotICAgICAgX19s aWJjX2xvbmdqbXAgKGJ1ZiwgMSk7CisgICAgICBsb25nam1wIChidWYsIDEp OwogICAgIH0KIAogICB3YWl0ID0gX19tYWNoX3JlcGx5X3BvcnQgKCk7CmRp ZmYgLS1naXQgYS9zeXNkZXBzL3MzOTAvbG9uZ2ptcC5jIGIvc3lzZGVwcy9z MzkwL2xvbmdqbXAuYwppbmRleCBlNTQzNDE1ZGYwLi5lNjFjZGJhMmEzIDEw MDY0NAotLS0gYS9zeXNkZXBzL3MzOTAvbG9uZ2ptcC5jCisrKyBiL3N5c2Rl cHMvczM5MC9sb25nam1wLmMKQEAgLTMzLDggKzMzLDYgQEAKICAgIGJ1dCB3 ZXJlIHJldmVydGVkIGJlZm9yZSAyLjIwLiBUaHVzIGJvdGggdmVyc2lvbnMg YXJlIHRoZSBzYW1lIGZ1bmN0aW9uLiAgKi8KIAogc3Ryb25nX2FsaWFzIChf X2xpYmNfc2lnbG9uZ2ptcCwgX19saWJjX2xvbmdqbXApCi1saWJjX2hpZGRl bl9kZWYgKF9fbGliY19sb25nam1wKQotbGliY19oaWRkZW5fZGVmIChfX2xp YmNfc2lnbG9uZ2ptcCkKIAogd2Vha19hbGlhcyAoX19saWJjX3NpZ2xvbmdq bXAsIF9fdjFfbG9uZ2ptcCkKIHdlYWtfYWxpYXMgKF9fbGliY19zaWdsb25n am1wLCBfX3YyX2xvbmdqbXApCi0tIAoyLjE0LjMKCg== --000000000000dbd08d0568f7dfeb--