From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-79371-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 101033 invoked by alias); 12 May 2017 16:26:24 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 101017 invoked by uid 89); 12 May 2017 16:26:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mail-qk0-f196.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=hKba7IZhuVf8vF20LSex/xPASp8Dx5qlzBfXMOiVsDQ=;
        b=fRmpRusWfC/coS9U0v7X+qviub+g/jAZNvDlRtdKX166C1bPs7O/JyXPtgP9cGOcjv
         8JGSHYRnTDNc3rcM1Lwt080lKMSGBnPeg+D7fy+JPvezr8N/ors/ExjqOjeRTaYA72DQ
         bYu44G8+6pR/ivJKDQLqH3tNrEeHLwp6gVqqvrpjO4oYNdayNpaYId44TkQk0kNutLQa
         8LYTWZlsCpzM7rlSl54fduVacHYCP1gHN2VK/NiOB5cb8wDaqPtJb6PRCAAeFIvf0qa1
         +8Y+WrjtLkjWrmishqjPwdEUaMDWuWejKYPcDZwtK+/dWooCWJVy/Kl5ntAviPMmiUGU
         GAEg==
X-Gm-Message-State: AODbwcARiqdkUXRu5YBgYwN0biKFZE4YAi3nLJiD5xKt38hyEEE3MHhN
	gChQ6IWcQzEOWzFYXsp5IFmBcaPl2Q==
X-Received: by 10.55.74.214 with SMTP id x205mr4835143qka.231.1494606384273;
 Fri, 12 May 2017 09:26:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAKCAbMhFjwXuTzvbL4USteu-PRC+SjSaene=+tcGri_ddhCZBA@mail.gmail.com>
References: <20170509154103.11973-1-zackw@panix.com> <20170509154103.11973-3-zackw@panix.com>
 <alpine.DEB.2.20.1705092126120.28688@digraph.polyomino.org.uk>
 <CAKCAbMjrvYeYMAv9CSaVc+_iWvqBwD3a4nQJ4VO6q1tWuH-5xw@mail.gmail.com>
 <CAMe9rOrMiK8iPwu_B3fn7NQeq9=tggOe7TKqmmU+_wd_T6Z02w@mail.gmail.com> <CAKCAbMhFjwXuTzvbL4USteu-PRC+SjSaene=+tcGri_ddhCZBA@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 12 May 2017 16:26:00 -0000
Message-ID: <CAMe9rOrMDyfX7LdWr49Dp=pMWwidNgarFj2MXnFhu0c5gkNHMA@mail.gmail.com>
Subject: Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
To: Zack Weinberg <zackw@panix.com>
Cc: Joseph Myers <joseph@codesourcery.com>, GNU C Library <libc-alpha@sourceware.org>, 
	Adhemerval Zanella <adhemerval.zanella@linaro.org>, Wilco Dijkstra <Wilco.Dijkstra@arm.com>, 
	Florian Weimer <fweimer@redhat.com>, "Carlos O'Donell" <carlos@redhat.com>, Andreas Schwab <schwab@suse.de>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2017-05/txt/msg00399.txt.bz2

On Fri, May 12, 2017 at 9:16 AM, Zack Weinberg <zackw@panix.com> wrote:
> On Fri, May 12, 2017 at 11:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> This patch has
>>
>> /* The testsuite, and some other ancillary code, should be compiled against
>>    as close an approximation to the installed headers as possible.
>>    Defining this symbol disables most internal-use-only declarations
>>    provided by this header, and all those provided by other internal
>>    wrapper headers.  */
>> #if IS_IN (testsuite) || defined IS_IN_build || defined __cplusplus
>> # define _ISOMAC 1
>> #endif
>>
>> However, benchtests don't define testsuite and _ISOMAC is undefined.
>> Programs in benchtests include sysdeps/generic/hp-timing-common.h
>> which includes sysdeps/generic/_itoa.h which uses attribute_hidden
>> attribute_hidden is defined only if _ISOMAC is undefined.  That is
>> means C++ program in benchtests won't compile since
>> attribute_hidden is undefined.
>
> What is the current IS_IN value for benchtests?  Is there any reason

-DMODULE_NAME=nonlib

> not to change it to 'testsuite'?

No, we can't since benchtests use glibc internal header files for hp-timing.

-- 
H.J.