From: "H.J. Lu" <hjl.tools@gmail.com>
To: Zack Weinberg <zackw@panix.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Florian Weimer <fweimer@redhat.com>,
"Carlos O'Donell" <carlos@redhat.com>,
Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
Date: Fri, 12 May 2017 15:40:00 -0000 [thread overview]
Message-ID: <CAMe9rOrMiK8iPwu_B3fn7NQeq9=tggOe7TKqmmU+_wd_T6Z02w@mail.gmail.com> (raw)
In-Reply-To: <CAKCAbMjrvYeYMAv9CSaVc+_iWvqBwD3a4nQJ4VO6q1tWuH-5xw@mail.gmail.com>
On Wed, May 10, 2017 at 4:56 AM, Zack Weinberg <zackw@panix.com> wrote:
> On Tue, May 9, 2017 at 5:28 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>>
>> The patch is OK with those changes, provided you've verified unchanged
>> installed stripped shared libraries on at least one platform (unless
>> there's some reason for the libraries to change), and an unchanged set of
>> tests run on at least one platform (except for any deliberate changes such
>> as from splitting strtod tests).
>
> Thanks. I did this verification once already, but it was long enough
> ago that I'm going to do it again, which will take another day or two.
>
This patch has
/* The testsuite, and some other ancillary code, should be compiled against
as close an approximation to the installed headers as possible.
Defining this symbol disables most internal-use-only declarations
provided by this header, and all those provided by other internal
wrapper headers. */
#if IS_IN (testsuite) || defined IS_IN_build || defined __cplusplus
# define _ISOMAC 1
#endif
However, benchtests don't define testsuite and _ISOMAC is undefined.
Programs in benchtests include sysdeps/generic/hp-timing-common.h
which includes sysdeps/generic/_itoa.h which uses attribute_hidden
attribute_hidden is defined only if _ISOMAC is undefined. That is
means C++ program in benchtests won't compile since
attribute_hidden is undefined.
--
H.J.
next prev parent reply other threads:[~2017-05-12 15:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 15:41 [PATCH 00/10] All of my not-yet-reviewed patches Zack Weinberg
2017-05-09 15:41 ` [PATCH 03/10] The bits/types/*.h treatment for stdio and wchar Zack Weinberg
2017-05-09 21:34 ` Joseph Myers
2017-05-10 11:52 ` Zack Weinberg
2017-05-20 21:05 ` Zack Weinberg
2017-05-22 14:56 ` Joseph Myers
2017-05-09 15:41 ` [PATCH 02/10] Suppress internal declarations for most of the testsuite Zack Weinberg
2017-05-09 21:28 ` Joseph Myers
2017-05-10 11:56 ` Zack Weinberg
2017-05-12 15:40 ` H.J. Lu [this message]
2017-05-12 16:16 ` Zack Weinberg
2017-05-12 16:26 ` H.J. Lu
2017-05-15 14:18 ` [PATCH] Move tst-mutex*8* to tests-internal Tulio Magno Quites Machado Filho
2017-05-20 13:06 ` Zack Weinberg
2017-05-22 14:21 ` Stefan Liebler
2017-05-25 17:55 ` Tulio Magno Quites Machado Filho
2017-05-09 15:41 ` [PATCH 07/10] Remove __need_IOV_MAX and __need_FOPEN_MAX Zack Weinberg
2017-05-09 15:41 ` [PATCH 04/10] Convert signal.h from __need macros to bits/types/ headers Zack Weinberg
2017-05-09 21:36 ` Joseph Myers
2017-05-17 17:41 ` Joseph Myers
2017-05-20 21:03 ` Zack Weinberg
2017-05-09 15:41 ` [PATCH 08/10] Don't install libio.h or _G_config.h Zack Weinberg
2017-05-09 15:41 ` [PATCH 01/10] Remove _IO_MTSAFE_IO from public headers Zack Weinberg
2017-05-09 21:11 ` Joseph Myers
2017-05-09 15:41 ` [PATCH 09/10] Remove bits/string2.h Zack Weinberg
2017-05-09 15:56 ` [PATCH 06/10] Remove __need_list_t and __need_res_state Zack Weinberg
2017-05-10 7:37 ` Florian Weimer
2017-05-20 19:37 ` Zack Weinberg
2017-05-09 15:56 ` [PATCH 05/10] Remove __need macros from errno.h (__need_Emath, __need_error_t) Zack Weinberg
2017-05-09 21:38 ` Joseph Myers
2017-05-10 7:31 ` Florian Weimer
2017-05-10 11:49 ` Joseph Myers
2017-05-10 12:03 ` Florian Weimer
2017-05-11 12:15 ` Zack Weinberg
2017-05-11 14:30 ` Joseph Myers
2017-05-11 14:46 ` Zack Weinberg
2017-05-11 14:53 ` Florian Weimer
2017-05-11 14:48 ` Florian Weimer
2017-05-11 15:26 ` Joseph Myers
2017-05-11 15:42 ` Andreas Schwab
2017-05-11 16:10 ` Joseph Myers
2017-05-11 17:20 ` Andreas Schwab
2017-05-11 16:19 ` Florian Weimer
2017-05-11 17:25 ` Andreas Schwab
2017-05-12 6:23 ` Florian Weimer
2017-05-15 8:11 ` Andreas Schwab
2017-05-15 8:13 ` Florian Weimer
2017-05-15 8:24 ` Andreas Schwab
2017-05-15 9:08 ` Florian Weimer
2017-05-09 15:56 ` [PATCH 10/10] Remove bits/string.h Zack Weinberg
2017-05-11 0:12 ` [PATCH 00/10] All of my not-yet-reviewed patches Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrMiK8iPwu_B3fn7NQeq9=tggOe7TKqmmU+_wd_T6Z02w@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).