From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Race condition in localedata tests?
Date: Tue, 18 Nov 2014 16:39:00 -0000 [thread overview]
Message-ID: <CAMe9rOrPZMSvG4tBgLLATKrGh3Kj-S-1ost20TVOGJX+_097Fg@mail.gmail.com> (raw)
In-Reply-To: <546B73C4.2020505@redhat.com>
On Tue, Nov 18, 2014 at 8:28 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 11/18/2014 11:17 AM, H.J. Lu wrote:
>> Hi,
>>
>> When machine is under heavy load, I saw
>>
>> FAIL: localedata/bug-iconv-trans
>> FAIL: localedata/tst-mbswcs6
>> FAIL: localedata/tst-trans
>> FAIL: localedata/tst-wctype
>> FAIL: localedata/tst_mbrlen
>> FAIL: localedata/tst_mbrtowc
>> FAIL: localedata/tst_mbsrtowcs
>> FAIL: localedata/tst_mbstowcs
>> FAIL: localedata/tst_mbtowc
>> FAIL: localedata/tst_swscanf
>> FAIL: localedata/tst_wcrtomb
>> FAIL: localedata/tst_wcsrtombs
>> FAIL: localedata/tst_wcstombs
>> FAIL: localedata/tst_wctob
>> FAIL: localedata/tst_wctomb
>>
>> Has anyone else seen it?
>
> No.
>
> Failing memory allocations?
I have plenty of memory.
> Do the tests have explicit dependencies on the locales they use?
> Perhaps it just happens that de_DE.UTF-8 hits the filesystem by
> the time the test runs.
>
localedata/Makefile has
# Dependency for the locale files. We actually make it depend only on
# one of the files.
$(addprefix $(objpfx),$(CTYPE_FILES)): %: \
gen-locale.sh $(common-objpfx)locale/localedef Makefile \
$(addprefix charmaps/,$(CHARMAPS)) $(addprefix locales/,$(LOCALE_SRCS))
@$(SHELL) gen-locale.sh $(common-objpfx) \
'$(built-program-cmd-before-env)' '$(run-program-env)' \
'$(built-program-cmd-after-env)' $@; \
$(evaluate-test)
$(addsuffix .out,$(addprefix $(objpfx),$(tests))): %: \
$(addprefix $(objpfx),$(CTYPE_FILES))
$(objpfx)sort-test.out: sort-test.sh $(objpfx)collate-test $(objpfx)xfrm-test \
$(test-input-data) $(addprefix $(objpfx),$(CTYPE_FILES))
$(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
'$(run-program-env)' '$(test-program-prefix-after-env)' \
$(test-input) \
> $@; \
$(evaluate-test)
However, there is no $(CTYPE_FILES) dependency for those tests
above, which fail at random under heavy load with parallel build.
--
H.J.
next prev parent reply other threads:[~2014-11-18 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 16:17 H.J. Lu
2014-11-18 16:29 ` Carlos O'Donell
2014-11-18 16:39 ` H.J. Lu [this message]
2014-11-18 16:41 ` H.J. Lu
2014-11-18 19:47 ` Carlos O'Donell
2014-11-18 19:45 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrPZMSvG4tBgLLATKrGh3Kj-S-1ost20TVOGJX+_097Fg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).