From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-54478-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 12447 invoked by alias); 18 Nov 2014 16:39:23 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 12436 invoked by uid 89); 18 Nov 2014 16:39:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ob0-f170.google.com
MIME-Version: 1.0
X-Received: by 10.60.177.137 with SMTP id cq9mr8841756oec.45.1416328759485;
 Tue, 18 Nov 2014 08:39:19 -0800 (PST)
In-Reply-To: <546B73C4.2020505@redhat.com>
References: <CAMe9rOp1ytEWzT8NzBj9-UtG1Ev0378BUj=PsGN2AwNSVa2KMA@mail.gmail.com>
	<546B73C4.2020505@redhat.com>
Date: Tue, 18 Nov 2014 16:39:00 -0000
Message-ID: <CAMe9rOrPZMSvG4tBgLLATKrGh3Kj-S-1ost20TVOGJX+_097Fg@mail.gmail.com>
Subject: Re: Race condition in localedata tests?
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2014-11/txt/msg00452.txt.bz2

On Tue, Nov 18, 2014 at 8:28 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 11/18/2014 11:17 AM, H.J. Lu wrote:
>> Hi,
>>
>> When machine is under heavy load, I saw
>>
>> FAIL: localedata/bug-iconv-trans
>> FAIL: localedata/tst-mbswcs6
>> FAIL: localedata/tst-trans
>> FAIL: localedata/tst-wctype
>> FAIL: localedata/tst_mbrlen
>> FAIL: localedata/tst_mbrtowc
>> FAIL: localedata/tst_mbsrtowcs
>> FAIL: localedata/tst_mbstowcs
>> FAIL: localedata/tst_mbtowc
>> FAIL: localedata/tst_swscanf
>> FAIL: localedata/tst_wcrtomb
>> FAIL: localedata/tst_wcsrtombs
>> FAIL: localedata/tst_wcstombs
>> FAIL: localedata/tst_wctob
>> FAIL: localedata/tst_wctomb
>>
>> Has anyone else seen it?
>
> No.
>
> Failing memory allocations?

I have plenty of memory.

> Do the tests have explicit dependencies on the locales they use?
> Perhaps it just happens that de_DE.UTF-8 hits the filesystem by
> the time the test runs.
>

localedata/Makefile has

# Dependency for the locale files.  We actually make it depend only on
# one of the files.
$(addprefix $(objpfx),$(CTYPE_FILES)): %: \
  gen-locale.sh $(common-objpfx)locale/localedef Makefile \
  $(addprefix charmaps/,$(CHARMAPS)) $(addprefix locales/,$(LOCALE_SRCS))
        @$(SHELL) gen-locale.sh $(common-objpfx) \
                  '$(built-program-cmd-before-env)' '$(run-program-env)' \
                  '$(built-program-cmd-after-env)' $@; \
        $(evaluate-test)

$(addsuffix .out,$(addprefix $(objpfx),$(tests))): %: \
  $(addprefix $(objpfx),$(CTYPE_FILES))

$(objpfx)sort-test.out: sort-test.sh $(objpfx)collate-test $(objpfx)xfrm-test \
                       $(test-input-data) $(addprefix $(objpfx),$(CTYPE_FILES))
        $(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
          '$(run-program-env)' '$(test-program-prefix-after-env)' \
          $(test-input) \
          > $@; \
        $(evaluate-test)

However, there is no $(CTYPE_FILES) dependency for those tests
above, which fail at random under heavy load with parallel build.


-- 
H.J.