From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by sourceware.org (Postfix) with ESMTPS id 692343858C62 for ; Thu, 23 May 2024 13:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 692343858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 692343858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716472761; cv=none; b=M7V7B9DFImqxQwNdZbONyV8Z9q+pGlG1vwg4+nv4bCABXRievhlhOzj+WA1CsbVJ7q1jgh3VgONRRd3JTYlUJSDkCgrdlZNVI/o2x3vpgGC23wUpWzXPx4dZ4urEszIIzoCcb7BkRP42pdwmTV1LwtikMQ8JbkZY8kuMw02KCuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716472761; c=relaxed/simple; bh=nrCjpmMUtwg/D5vlY3bi+F40yr2frj7vGCpxv5xrfvM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=FsE4gqZ4h8AmziRvftS+sDF7/Rm+EyKPrDanfOcvNIDpdzBbOtLXSTs4ANMmTM6qf6pY1zCebkaaTnN+QfBEHWcmSnLGFAKAN1WagT9czsK03A4lcPbW9WF+oZq6pX+6Q0dTmxuSIkpNkQU0afR6o7NIRtZczJAy9bYWl2NRn08= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-627ecda47d0so18524477b3.2 for ; Thu, 23 May 2024 06:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716472758; x=1717077558; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SODeH0A3L3uhhsqH/cvnN5qO+fTBHIIpN1qTGgHq9eI=; b=ax8EbPusRo4dvcdtCpmSvBRN3ZUd3jDo3LtH9kQHHLo1jATOCQRLBm5LMRQN6QdNYG IG66EQtxKyXcD8Ba7WFfWi8hZCOaG+3zTeRmM5PZ/B4wcgV1ob/oh0jkPWdHDFuscBS9 KgmX2a7VIV1YEY+hfseFgxgotP6Ku4KtdXSYAJZDuY9HuzsT1ssEdmiPIbUk23Mn2wni m4w0WJorRkaOauvqmILwEJoC2ANQdqNcFhhASdbQht6iBKtOZYyE1k+L0qceaW14k1rt 51gaxRychVYV4q1cUifZ2f1e+pNc3H8Ph0qz+i8joZyozBVBVtYBNDMyDDAWnDTOC6Ar ruxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716472758; x=1717077558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SODeH0A3L3uhhsqH/cvnN5qO+fTBHIIpN1qTGgHq9eI=; b=kmbkPToh5QQcLTEkXpNVjkQ8mQJ+9/s0oajAt64k3PzrOvikOy2qDr6YFP6UsA21oO PKtgSSnVsBO5iq6seXGRe00po962dfNXrxX6tb0LyIQRkc+EHDFBei/yWxwzA+LQGyJN h6r+zD1vC6QWwkwdtPf1urcBTgDxPQmn7K9Q5iW+p0y2Aj9MaShxqZd0kHTKDmp0zWl0 lLMBIk+9/miB+B+fNA1UFztKJv+G7K/8NWGHaZK+Q2VbnuCFgPfLGwhZo0F49b0m50go QggyZZ4mW+i6TJLzN5LjnwINAbQlQoQfashV1iw5LkmgCUgZt3vnglzocTVgK4P4ouOS aOIg== X-Gm-Message-State: AOJu0YyVGDmb5ZWoiYtvpvobE4ESTL9tMmYxyUGnccsHsBz3SjsNTzbQ s4KFzhWu95R3jx3v1BXkf3gRaivInbo1iBoPKfN//IzSYFbm6Zz6Ei4pHqw+VYCYLuJyfys9POc x+BJSGFZV1Lcs/y3D3ima39gD3sjbTlqY X-Google-Smtp-Source: AGHT+IGkEK4O9yCdC8H8GxE4vGCUWOkeOg/ZZ9pwSNX/L9LPttrKg2zyBkzPKUF00r+E7eN/RVQTxXTLyiHq+8zDqOI= X-Received: by 2002:a05:690c:301:b0:615:41a4:1a8a with SMTP id 00721157ae682-627e47217f4mr55843977b3.25.1716472758459; Thu, 23 May 2024 06:59:18 -0700 (PDT) MIME-Version: 1.0 References: <20240523134650.14966-1-hjl.tools@gmail.com> <87cypcprf8.fsf@oldenburg.str.redhat.com> In-Reply-To: <87cypcprf8.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Thu, 23 May 2024 06:58:42 -0700 Message-ID: Subject: Re: [PATCH v4] Check global symbols in static library against shared library To: Florian Weimer Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 23, 2024 at 6:51=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > diff --git a/sysdeps/alpha/Makefile b/sysdeps/alpha/Makefile > > index 11d5e65503..ed658c143e 100644 > > --- a/sysdeps/alpha/Makefile > > +++ b/sysdeps/alpha/Makefile > > @@ -33,6 +33,11 @@ sysdep_routines +=3D stxcpy stxncpy > > endif > > > > ifeq ($(subdir),elf) > > +# These global symbols are only in libc.so. > > +libc-shared-only-symbols +=3D \ > > + __nldbl__IO_vfscanf \ > > +# libc-shared-only-symbols > > + > > # The ld.so startup code cannot use literals until it self-relocates. > > CFLAGS-rtld.c =3D -mbuild-constants > > endif > > Why doesn't this indicate a bug? Shouldn't this part of libc.a, too? It is referenced from libnldbl_nonshared.a. > If it's not a bug, I think this belongs into > sysdeps/ieee754/ldbl-opt/Makefile. I will fix it. > (not a complete review, sorry, just realized this and wanted to share) > > Thanks, > Florian > Thanks. --=20 H.J.