From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com
 [IPv6:2607:f8b0:4864:20::635])
 by sourceware.org (Postfix) with ESMTPS id EE80C3858432
 for <libc-alpha@sourceware.org>; Mon,  6 Dec 2021 19:22:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE80C3858432
Received: by mail-pl1-x635.google.com with SMTP id b11so7704650pld.12
 for <libc-alpha@sourceware.org>; Mon, 06 Dec 2021 11:22:57 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=9lEYEIxmg8sCCSKuuYBfKq32tekfJd2b47mvlshLVpk=;
 b=N9sYba1me8GCrzsc+x1uot4QhECzl3rgw78jWbDwmb48CleHvZcqOcY5oKVj37/No3
 vgQBH+zuanmqS5r7G5M3PScgEjeoaHfAclETCSge0D3b7Rwca8LgrP/SCL8iihBS1W0/
 qiVgnV+tE3RewHU+BZxhtYeeyXTfjHf4ouOto9beQeQFKO5ijUmMcKc7ztavVY9rq1r2
 va6Q+elciDAh7UDWN4b3hYWftWCbet88vN1iqqE2Go7QCcay2X84DpggAU80aXhCg+Ab
 H0SB0KZRJPzQCJUuTyZwbN0h+YptGYlIWvQy20LbW7zUd2sezW2Ae1jktL16A9AGla05
 T9lg==
X-Gm-Message-State: AOAM5300kF9jB9UVw2WvNuyXJ6Vc89CJ7nMjP/Y5/0YSj1q4SUcPmKzM
 3A54GaLV67GTYyDLaTYZ+p5iyNpRPH1VcWeh7Bk=
X-Google-Smtp-Source: ABdhPJyaZpbnKa+ViE/LzVcTTtPAT/KHTfDedYeNNoPXeM78jl6MYO2lEkDT8YTE15/g7VfaKMl4PjvPK9YMHFQlyok=
X-Received: by 2002:a17:90b:3a85:: with SMTP id
 om5mr659970pjb.28.1638818577078; 
 Mon, 06 Dec 2021 11:22:57 -0800 (PST)
MIME-Version: 1.0
References: <20211119150329.2200675-1-adhemerval.zanella@linaro.org>
 <87bl1tmtxz.fsf@oldenburg.str.redhat.com>
In-Reply-To: <87bl1tmtxz.fsf@oldenburg.str.redhat.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 6 Dec 2021 11:22:21 -0800
Message-ID: <CAMe9rOrVXvk13ReiwSU1-PYKZsvpuYEV7hkua+0Z5GUff+v8vg@mail.gmail.com>
Subject: Re: [PATCH] elf: Add elf checks for main executable
To: Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>, 
 GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Dec 2021 19:22:59 -0000

On Mon, Dec 6, 2021 at 11:09 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Adhemerval Zanella:
>
> > +static void
> > +modify_abiversion (ElfW(Ehdr) *ehdr)
> > +{
> > +  ehdr->e_ident[EI_ABIVERSION] = LIBC_ABI_MAX;
> > +}
>
> So this is eventually controlled by the libc-abis file, right?
>
> I *thought* that the consensus was that binutils should bump version if
> absolute symbols are used.  But I don't see that in the absolute symbol
> tests.
>
> Is this really doing anything?
>

EI_ABIVERSION check works on executables created by the new linker
which bumps EI_ABIVERSION.  This complements the existing
EI_ABIVERSION check on DSOs.  This is orthogonal to the ABI version
check for existing ld.so binaries which needs an ABIVERSION version.

-- 
H.J.