Re: [PATCH v1] x86: Remove unneeded rtld-wmemcmp

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Jul 12, 2022 at 12:29 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> wmemcmp isn't used by the dynamic loader so their no need to add an
> RTLD stub for it.
>
> Tested with and without multiarch on x86_64 for ISA levels:
> {generic, x86-64-v2, x86-64-v3, x86-64-v4}
>
> And m32 with and without multiarch.
> ---
>  sysdeps/x86_64/multiarch/rtld-wmemcmp.S | 18 ------------------
>  1 file changed, 18 deletions(-)
>  delete mode 100644 sysdeps/x86_64/multiarch/rtld-wmemcmp.S
>
> diff --git a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S b/sysdeps/x86_64/multiarch/rtld-wmemcmp.S
> deleted file mode 100644
> index 71a6f0affa..0000000000
> --- a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -/* Copyright (C) 2022 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library; if not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#include "../wmemcmp.S"
> --
> 2.34.1
>

LGTM.

Thanks.

-- 
H.J.