From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 40FAA3857BA1 for ; Tue, 12 Jul 2022 19:45:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40FAA3857BA1 Received: by mail-pj1-x102a.google.com with SMTP id o3-20020a17090a744300b001ef8f7f3dddso9600136pjk.3 for ; Tue, 12 Jul 2022 12:45:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sDZah07Zy+JvM5oiV+pzqLDbb+mTqY6HMQOKku9x84U=; b=VvgOZj5qc8UuLM9GUCzL7RAmciR3KEq/QCM8eIvr5uWnnVyTSBdHscR5kV5ZgqBT1K hPisW6T3xjbzKXr3gUyk6R1zYO/lXr/fBltCd0p0mh8rHmPuHjv4O1P7NmDMqMjkFutV 9bCuag4VikYTz48ZjsUJFouZVUxKdm1xQ2oPQyWNsCWCKUTBkWBPnChNCHP9oxlYS5+7 vnWOhKf0mwVHrrcVMTnN3CGRZE/CeXnr9ux+XeJWx+jfHog8O5rlDJWe6AiUOHbtkAH/ 6KbLTVOOOzkoi7b9hsrf53jJTfXajVAuK9VkDNY96xrZmuEdVTjTCxfHGFExDJPagz2i CRWQ== X-Gm-Message-State: AJIora+9skPyWr3QJKdC7uGl482AnMKIa61UgnVD4+7kCWGhJVnZ6PTG 5Qs70DP5VLXBEEktwv4Go6O9KJwf9prPflKlPx0= X-Google-Smtp-Source: AGRyM1sa2upeANtrz5KZQ1QnXPdJbTtbk4cuPFEGgb+zzEnhK7NVydfr8+70Nt0gaxgj6pULK92sX5EZpl7NYQgwhiA= X-Received: by 2002:a17:902:d50e:b0:16c:1664:81e5 with SMTP id b14-20020a170902d50e00b0016c166481e5mr25902052plg.149.1657655101250; Tue, 12 Jul 2022 12:45:01 -0700 (PDT) MIME-Version: 1.0 References: <20220712192910.351121-1-goldstein.w.n@gmail.com> <20220712192910.351121-9-goldstein.w.n@gmail.com> In-Reply-To: <20220712192910.351121-9-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Tue, 12 Jul 2022 12:44:25 -0700 Message-ID: Subject: Re: [PATCH v1] x86: Remove unneeded rtld-wmemcmp To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 19:45:04 -0000 On Tue, Jul 12, 2022 at 12:29 PM Noah Goldstein wrote: > > wmemcmp isn't used by the dynamic loader so their no need to add an > RTLD stub for it. > > Tested with and without multiarch on x86_64 for ISA levels: > {generic, x86-64-v2, x86-64-v3, x86-64-v4} > > And m32 with and without multiarch. > --- > sysdeps/x86_64/multiarch/rtld-wmemcmp.S | 18 ------------------ > 1 file changed, 18 deletions(-) > delete mode 100644 sysdeps/x86_64/multiarch/rtld-wmemcmp.S > > diff --git a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S b/sysdeps/x86_64/multiarch/rtld-wmemcmp.S > deleted file mode 100644 > index 71a6f0affa..0000000000 > --- a/sysdeps/x86_64/multiarch/rtld-wmemcmp.S > +++ /dev/null > @@ -1,18 +0,0 @@ > -/* Copyright (C) 2022 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -#include "../wmemcmp.S" > -- > 2.34.1 > LGTM. Thanks. -- H.J.