From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by sourceware.org (Postfix) with ESMTPS id 41D123858D20 for ; Mon, 1 Apr 2024 14:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41D123858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41D123858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711980017; cv=none; b=bLgFvj6YFRkxgkDL4ypEx53q8CxsykpfE7/uxG3Iy4BoZ8Azn+xulp21L3IwRIS9CrgwSgnfz9CXpUOg6ME2VFgRfo6FQBNd2R5k8Uq8SXF/VfKkrXCQUP6dg6g7QRQtcgBjUbsPo9wIWCNasw9FrtHgyPEjdLWy4rvUk9CDHJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711980017; c=relaxed/simple; bh=pcxi6uvAH5yf3zmvel7n7X4e3pQBvjRPwNKFUvlwWMc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fzJLx3BzbYhGauqsw9BUpkBqAADGIkE5EdFsr8vzXUX46JkObD2xM1aPSs2IEE/SdlZB7EZKWdLyJQLjCcXotfRWwaE8CQ96t6hyY/RKdtZWmh5mweJ4sTcZ3mrkpx6uKaiF+HbfBio4ClJrTFoxZsNBNbZMUVMGPwhdHAH0Tlw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso3754232276.2 for ; Mon, 01 Apr 2024 07:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711980015; x=1712584815; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mV6RuhcoK7vEdlfUPs9xAlVOSHe7AygXH4LSe705RvY=; b=hOMuHCCEidjQdJbQmo7gx7UCLASSJFsqe7KYGkgiRcDyk+TsSFOR5ytebnpk+W8HZn 3njxuXvmk72agiZ/1Q+uC4Ceol8fe8OHx+7ySkkm4fIx9PDOivs7CHB8uLNmbZMOKXjm TfRrxhYE323Njkece8zY5qQEFw5kO1oxxi1C2MoTOVF9+QO9Y3kbLhVjZXM0p7tttrQI ICxDG+3I1O6e/MLy8qRuQZODFj/eeGaRRmh9HhL7PYzgXKamcf+fmGPGui8IudGzmWI+ vsKSwC0d6tAR9KL1oDPgH5SQADOI21JibCTyFJf50iy/mRUslqvqdYz7/ApL0P5t4U6P CXGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711980015; x=1712584815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mV6RuhcoK7vEdlfUPs9xAlVOSHe7AygXH4LSe705RvY=; b=XsirhpBfiEYcUtN5e15akDsZHkErDxJ1fvKtOuyd+lwhcGiS3yWtS1LIXideHn3t5j aHgILpMn7RAzxkepTwWbQ8ERF7Zm28QYdFSRh786+fDQakN5kfHCnYKm2LU8acJvZK0y p2No7ZZmp+BySa2+7KJL99azjdzaDaCoLzWYNbacWxu0/6xZE4IrdvBisj1W+o96y+5n WI96cVUsZULAYHzVRaQG6dKyWFd1y0Fsx3f1OoRzpH5tQWtqG2LUQYBzppt+KoGZv+ja z7ITQH1CoHNNL1s2zJSRMdXlTK5MM0BiNhywMouYPEl6A/J4f7QRPmCP/SZ3EgGFZGbS cd+A== X-Gm-Message-State: AOJu0YwNwlbXAONGP9Hh9aYmkyA7jWrzw0HnWd8U3K3kHAoXFVpED26K 5vR/ue2rThb6P5CKa2tmOAqyysNDGlb76zNoGQjHsyP1G1xLcI4HJXTPGzjlWHlFSfiyC2l/+I8 901ZRbh62tYqilQ59+5WHO6fTNTQG6oL6 X-Google-Smtp-Source: AGHT+IE7b00YK2hA11fmX4OM55zYrqSlxwtztCeu9CsWG+7mn2bd1O4cFt7uOo26X/38t1lk1Kxi6b2sbopCTH2M8x4= X-Received: by 2002:a25:ae98:0:b0:dc6:ff32:aae2 with SMTP id b24-20020a25ae98000000b00dc6ff32aae2mr6265448ybj.63.1711980015478; Mon, 01 Apr 2024 07:00:15 -0700 (PDT) MIME-Version: 1.0 References: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> <20231228172026.2013007-3-adhemerval.zanella@linaro.org> In-Reply-To: <20231228172026.2013007-3-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Mon, 1 Apr 2024 06:59:39 -0700 Message-ID: Subject: Re: [PATCH 02/12] powerpc: Add missing arch flags on rounding ifunc variants To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 28, 2023 at 9:21=E2=80=AFAM Adhemerval Zanella wrote: > > The ifunc variants now uses the powerpc implementation which in turn > uses the compiler builtin. Without the proper -mcpu switch the builtin > does not generate the expected optimization. > > Checked on powerpc-linux-gnu. > --- > sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sy= sdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile > index 64317506c6..2f5c0eded6 100644 > --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile > +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile > @@ -34,6 +34,12 @@ CFLAGS-s_modff-power5+.c =3D -mcpu=3Dpower5+ > CFLAGS-s_logbl-power7.c =3D -mcpu=3Dpower7 > CFLAGS-s_logb-power7.c =3D -mcpu=3Dpower7 > CFLAGS-s_logbf-power7.c =3D -mcpu=3Dpower7 > +CFLAGS-s_round-power5+.c +=3D -mcpu=3Dpower5+ > +CFLAGS-s_roundf-power5+.c +=3D -mcpu=3Dpower5+ > +CFLAGS-s_floor-power5+.c +=3D -mcpu=3Dpower5+ > +CFLAGS-s_floorf-power5+.c +=3D -mcpu=3Dpower5+ > +CFLAGS-s_trunc-power5+.c +=3D -mcpu=3Dpower5+ > +CFLAGS-s_truncf-power5+.c +=3D -mcpu=3Dpower5+ > > # These files quiet sNaNs in a way that is optimized away without > # -fsignaling-nans. > -- > 2.34.1 > LGTM. Reviewed-by: H.J. Lu Thanks. --=20 H.J.