From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by sourceware.org (Postfix) with ESMTPS id 6CA88385C426 for ; Mon, 1 Jun 2020 02:04:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6CA88385C426 Received: by mail-il1-x142.google.com with SMTP id h3so7909411ilh.13 for ; Sun, 31 May 2020 19:04:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UqIZ1SNzXP54LaDHVnj4n5kAyiYjqD+TGLVYCcAMFLw=; b=iq+yuyKaW7iyShPMlFSF1brF+AQbuGjusWCXhJ9WqFLBEYvVO1e4cwIATvthuJWQJH Jd47VO1Nh+WLbY57NcMVwzM+iKM9e/eY3ZQa3yZE1NyEGX91oqQeBXJ374COEhn66blI z3i0gjd3JkAGpiO1eZpr1fOsY2SAFZcxQMRGzNdX7bIwPEQKj8tePJlE6XEZX4LriCFy /irvV7a9k98fqgF05B4FSNuMCsPTvRj7OBr7RDrWkQXBS4x2RgMhINcUeWvDkotjJ1AH yY9zVSqoxybtzlw+x4lkGvUAXlDcZ5dgwrlQpMrpT3V2GNkznQOiAlzw7l7HpYt9VeeG sI9A== X-Gm-Message-State: AOAM533YGltEd4R/qyStBV1ETPCrMEDSAzABrnl4GvKGRAWeOB7MZdFM ypahjOxPsKWaoD/9VM7+4xX1jfB8iwmSReWxDIpllQ== X-Google-Smtp-Source: ABdhPJyy0cxWpDZR3sfrndq7P403y5uid3vzuJYf5rh9FZWc18Ymo+ky8TnNh0YyePi1xTFPVeHkFlx687sBFGBzZGg= X-Received: by 2002:a05:6e02:1350:: with SMTP id k16mr7393783ilr.213.1590977096819; Sun, 31 May 2020 19:04:56 -0700 (PDT) MIME-Version: 1.0 References: <20200502150243.1347705-2-ibmibmibm.tw@gmail.com> <877dwwckq2.fsf@oldenburg2.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Sun, 31 May 2020 19:04:21 -0700 Message-ID: Subject: Re: [PATCH v4 2/2] x86_64: roundeven with sse4.1 support To: "Cui, Lili" Cc: Florian Weimer , "H.J. Lu via Libc-alpha" , Shen-Ta Hsieh Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_LINEPADDING, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 02:04:58 -0000 On Sun, May 31, 2020 at 6:28 PM Cui, Lili wrote: > > > > > > From: H.J. Lu > Sent: Friday, May 29, 2020 7:30 PM > To: Cui, Lili > Cc: Florian Weimer ; H.J. Lu via Libc-alpha ; Shen-Ta Hsieh > Subject: Re: [PATCH v4 2/2] x86_64: roundeven with sse4.1 support > > > > On Fri, May 29, 2020 at 1:48 AM Cui, Lili wrote: > > > > > > > -----Original Message----- > > > From: H.J. Lu > > > Sent: Thursday, May 28, 2020 8:32 PM > > > To: Florian Weimer ; Cui, Lili > > > Cc: H.J. Lu via Libc-alpha ; Shen-Ta Hsieh > > > > > > Subject: Re: [PATCH v4 2/2] x86_64: roundeven with sse4.1 support > > > > > > On Thu, May 28, 2020 at 5:22 AM Florian Weimer > > > wrote: > > > > > > > > * H. J. Lu via Libc-alpha: > > > > > > > > >> Here is a benchmark result on my AMD Ryzen 9 3900X system: > > > > > > > > > > Since we don't know or may not care SSE4 machines without AVX, > > > > > should we make it to AVX only? > > > > > > > > What about Goldmont/Tremont? Those are current CPUs which do not > > > > support AVX, but I think they have sufficient SSE4 support levels for > > > > this change. > > > > > > > > > > Good point. Lili, please collect glibc micro benchmark roundeven/roundevenf > > > data before and after: > > > > > > https://sourceware.org/pipermail/libc-alpha/2020-May/113533.html > > > > > > on Tremont. > > > > > > -- > > > H.J. > > > > Hi H.J, > > > > Result is here. > > benchmark result before this commit on Tremont > > > > > > > > benchmark result after this commit on Tremont > > > > > > > > > > Hi Lili, > > > > The results are empty. > > > > -- > > H.J. > > > > Hi H.J, > > > > Sorry for that my format has some problems, data is here. > > > > benchmark result before this commit on Tremont > > > > "roundeven": "roundevenf": > > "duration": 2.19422e+09, "duration": 2.19402e+09, > > "iterations": 1.44514e+08, "iterations": 1.4184e+08, > > "max": 43.258, "max": 53.07, > > "min": 11.052, "min": 12.052, > > "mean": 15.1835 "mean": 15.4683 > > > > benchmark result after this commit on Tremont > > > > "roundeven": "roundevenf": > > "duration": 2.19144e+09, "duration": 2.19218e+09, > > "iterations": 2.17075e+08, "iterations": 1.97982e+08, > > "max": 395.428, "max": 34.928, > > "min": 10.044, "min": 11.02, > > "mean": 10.0953 "mean": 11.0726 > > > Looks good. Thanks. -- H.J.