From: "H.J. Lu" <hjl.tools@gmail.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH 4/5] Delay initialization of CPU features struct in static binaries
Date: Thu, 25 May 2017 03:05:00 -0000 [thread overview]
Message-ID: <CAMe9rOrdJjkR5mSpQFg=Aa3En6eakCiSagWbior3PSyxPpw=3A@mail.gmail.com> (raw)
In-Reply-To: <1495138038-32212-5-git-send-email-siddhesh@sourceware.org>
On Thu, May 18, 2017 at 1:07 PM, Siddhesh Poyarekar
<siddhesh@sourceware.org> wrote:
> Allow the CPU features structure set up to be overridden by tunables
> by delaying it to until after tunables are initialized. The
> initialization is already delayed in dynamically linked glibc, it is
> only in static binaries that the initialization is set early to allow
> it to influence IFUNC relocations that happen in libc-start. It is a
> bit too early however and there is a good place between tunables
> initialization and IFUNC relocations where this can be done.
>
> Verified that this does not regress the testsuite.
>
> * csu/libc-start.c [!ARCH_INIT_CPU_FEATURES]: Define
> ARCH_INIT_CPU_FEATURES.
> (LIBC_START_MAIN): Call it.
> * sysdeps/unix/sysv/linux/aarch64/libc-start.c
> (__libc_start_main): Remove.
> (ARCH_INIT_CPU_FEATURES): New macro.
> * sysdeps/x86/libc-start.c (__libc_start_main): Remove.
> (ARCH_INIT_CPU_FEATURES): New macro.
> ---
>
Looks good to me.
Thanks.
--
H.J.
next prev parent reply other threads:[~2017-05-25 3:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 20:07 [PATCH v2 0/5] aarch64: Allow overriding HWCAP_CPUID feature check Siddhesh Poyarekar
2017-05-18 20:07 ` [PATCH 4/5] Delay initialization of CPU features struct in static binaries Siddhesh Poyarekar
2017-05-25 3:05 ` H.J. Lu [this message]
2017-05-18 20:07 ` [PATCH 2/5] tunables: Add LD_HWCAP_MASK to tunables Siddhesh Poyarekar
2017-05-22 13:20 ` Adhemerval Zanella
2017-05-18 20:07 ` [PATCH 1/5] tunables: Add hooks to get and update tunables Siddhesh Poyarekar
2017-05-22 14:07 ` Adhemerval Zanella
2017-05-18 20:07 ` [PATCH 3/5] tunables: Use glibc.tune.hwcap_mask tunable instead of _dl_hwcap_mask Siddhesh Poyarekar
2017-05-22 14:51 ` Adhemerval Zanella
2017-05-18 20:07 ` [PATCH 5/5] aarch64: Allow overriding HWCAP_CPUID feature check using HWCAP_MASK Siddhesh Poyarekar
2017-05-19 9:49 ` Szabolcs Nagy
2017-05-19 17:44 ` Siddhesh Poyarekar
2017-05-19 22:12 ` Szabolcs Nagy
2017-05-20 3:32 ` Siddhesh Poyarekar
2017-05-20 12:35 ` Szabolcs Nagy
2017-05-20 13:23 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrdJjkR5mSpQFg=Aa3En6eakCiSagWbior3PSyxPpw=3A@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).