From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-79718-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 52300 invoked by alias); 25 May 2017 03:05:58 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 52254 invoked by uid 89); 25 May 2017 03:05:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.220.194, Hx-spam-relays-external:209.85.220.194
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-qk0-f194.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=otxyX6HqaX6Q4wtdvrLleJHfyhyHnVWINS089k0k9B4=;
        b=ObSM0YOB4w4XNQcX7O28Hgy30rlGmFrOiNFTQuWgh3Y9Ijus5W3TBzwQRdEi7JGHJN
         pttukRRSgy5Ovj6rQ6KY4v/Rs9PzPi7uLCqq8jmh2FKBw1ixPcNLqiBdPAJPrIq+3xin
         cwsYmaXGy+BARGhnSX+RD37fMxscjOK3LxWlxL4fAfCQz6WB38N0cxrHik2ap7RpXlly
         RMy3G2lOQe76QAmm7X98enkUfg67UeQRd2fmw07xcdy1gi2nx1h4jUNdQshrDSTOPZhi
         nJdRhEBZcWA/+l4swCS1BgUnnMZZF75j67Hh9kJmnH1zdcrt6l6np8aO8nGTz7PYuHF4
         hLIg==
X-Gm-Message-State: AODbwcAt7wgjzW74J75egH8PvErqCbwqWl0D0JT4igbgUb1sacyBBKao
	f+GwwCXaabCo/+g2O4U4aJ/p1HK32w==
X-Received: by 10.55.105.133 with SMTP id e127mr33119236qkc.19.1495681557467;
 Wed, 24 May 2017 20:05:57 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1495138038-32212-5-git-send-email-siddhesh@sourceware.org>
References: <1495138038-32212-1-git-send-email-siddhesh@sourceware.org> <1495138038-32212-5-git-send-email-siddhesh@sourceware.org>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 25 May 2017 03:05:00 -0000
Message-ID: <CAMe9rOrdJjkR5mSpQFg=Aa3En6eakCiSagWbior3PSyxPpw=3A@mail.gmail.com>
Subject: Re: [PATCH 4/5] Delay initialization of CPU features struct in static binaries
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: GNU C Library <libc-alpha@sourceware.org>, 
	Adhemerval Zanella <adhemerval.zanella@linaro.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2017-05/txt/msg00746.txt.bz2

On Thu, May 18, 2017 at 1:07 PM, Siddhesh Poyarekar
<siddhesh@sourceware.org> wrote:
> Allow the CPU features structure set up to be overridden by tunables
> by delaying it to until after tunables are initialized.  The
> initialization is already delayed in dynamically linked glibc, it is
> only in static binaries that the initialization is set early to allow
> it to influence IFUNC relocations that happen in libc-start.  It is a
> bit too early however and there is a good place between tunables
> initialization and IFUNC relocations where this can be done.
>
> Verified that this does not regress the testsuite.
>
>         * csu/libc-start.c [!ARCH_INIT_CPU_FEATURES]: Define
>         ARCH_INIT_CPU_FEATURES.
>         (LIBC_START_MAIN): Call it.
>         * sysdeps/unix/sysv/linux/aarch64/libc-start.c
>         (__libc_start_main): Remove.
>         (ARCH_INIT_CPU_FEATURES): New macro.
>         * sysdeps/x86/libc-start.c (__libc_start_main): Remove.
>         (ARCH_INIT_CPU_FEATURES): New macro.
> ---
>

Looks good to me.

Thanks.

-- 
H.J.