From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 197713858D39 for ; Mon, 15 Nov 2021 14:43:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 197713858D39 Received: by mail-pl1-x62c.google.com with SMTP id u11so14685161plf.3 for ; Mon, 15 Nov 2021 06:43:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BX/OM61At5aWy9Na4X0+lcl5nXiW3yoTHXrTMbOtGb0=; b=h7vrz9cmtzMlwJ8lsf6LAc2r+n9SBaJGmLxkwnoalM/XPKxsKLW5YI2ZrUVbcio4+A QY2lSZ5iUa6OlUjDr1at0sUpcE734QVbboYc7fRg+Xi8+ZNJDlb4Q/g7UWvD7i3N1SGn tpVpv6D+C7h3cHNXivKv8WCzWwqM+KD7wuWL2aAqZXrk5sLEfPKhLVs8m6503UpU+C55 lpN7U+U923+qyUlhlD+DGMWBLhLJ7GXQGav5mzRVsedAqboIyk+N+pNyXFFE5mYxBO8h Y5JXNmFdEP7Cd8hA/olCdgwROu2OEaN6xQhNYgPDnc6zaxjhn5j0pk8pce4MIASswkVX 2EGQ== X-Gm-Message-State: AOAM532mDVf64+M2XaCXAUWNOq481UbMbNoBln0VIpchwG3erjIv3v3+ XhpbBVmbxhl+RBg+oucOVDS3W3aaTXTfwKvA1yEHUmpH X-Google-Smtp-Source: ABdhPJzAHqajJiRgqM18ggwiU3tzgaQ65yNVmg/yt7clq0oXt76MGzal/J6Or5UR4VzOH42PgS3/BgXsYUkSzI7YuNk= X-Received: by 2002:a17:902:ced1:b0:141:e15d:49e0 with SMTP id d17-20020a170902ced100b00141e15d49e0mr36131787plg.27.1636987424214; Mon, 15 Nov 2021 06:43:44 -0800 (PST) MIME-Version: 1.0 References: <20211108154211.167829-1-hjl.tools@gmail.com> <80ff6840-3437-3c7d-90c7-da9d5c523973@linaro.org> In-Reply-To: <80ff6840-3437-3c7d-90c7-da9d5c523973@linaro.org> From: "H.J. Lu" Date: Mon, 15 Nov 2021 06:43:08 -0800 Message-ID: Subject: Re: [PATCH v2 0/2] Update Makefile fragments for DSO sorting tests To: Adhemerval Zanella Cc: GNU C Library , Florian Weimer Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 14:43:48 -0000 On Thu, Nov 11, 2021 at 6:05 AM Adhemerval Zanella wrote: > > > > On 11/11/2021 10:46, H.J. Lu via Libc-alpha wrote: > > On Mon, Nov 8, 2021 at 7:42 AM H.J. Lu wrote: > >> > >> One problem of using > >> > >> $(objpfx)%$o: $(objpfx)%.c $(before-compile); $$(compile-command.c) > >> compile-command.c = $(compile.c) $(OUTPUT_OPTION) $(compile-mkdep-flags) > >> compile.c = $(CC) $< -c $(CFLAGS) $(CPPFLAGS) > >> > >> to build DSO sorting relocatable objects is that $< may not be the source > >> file with 3 "make -j 28" parallel builds on a machine with 112 cores. > >> When generating Makefile fragments at build time, the same file may be > >> generated more than once at the same time with parallel builds. > >> > >> 1. Update dso-ordering-test.py to put all sources for DSO sorting tests > >> in a single directory, dso-sort-tests-src, and compile relocatable objects > >> with > >> > >> $(objpfx)tst-dso-ordering1-dir/tst-dso-ordering1-a.os: $(objpfx)dso-sort-tests-src/tst-dso-ordering1-a.c > >> $(compile.c) $(OUTPUT_OPTION) > >> > >> 2. Generate Makefile fragments for DSO sorting tests at configure time > >> to avoid generate them in the elf directory at build time. > >> > >> H.J. Lu (2): > >> dso-ordering-test.py: Put all sources in one directory [BZ #28550] > >> elf: Pre-generate Makefile fragment for DSO sorting tests [BZ #28550] > >> > >> configure | 11 +++++++++ > >> configure.ac | 12 +++++++++ > >> elf/Makefile | 22 ++++------------- > >> scripts/dso-ordering-test.py | 47 ++++++++++++++++++++++++++---------- > >> 4 files changed, 62 insertions(+), 30 deletions(-) > >> > >> -- > >> 2.33.1 > >> > > > > Any comments on the v2 patches? "make check -j28" has been failing for me > > on machines with many cores. I'd like to resolve it soon. > > > > It is on my list, just sorting out Florian comments to rtld-audit patchset. This bug has been causing false negative results with "makc check -jN" on machines with many cores. I will check it in on Tuesday if there are no objections. Thanks. -- H.J.