From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id A9A68385DC2D for ; Thu, 24 Mar 2022 19:03:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9A68385DC2D Received: by mail-pl1-x62e.google.com with SMTP id q11so5709925pln.11 for ; Thu, 24 Mar 2022 12:03:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qfMG2WsGLdo2LGvErGsUS4uf7FR0w9OrvXwFYa2IjdU=; b=jsJnYdlBn22iGyfqY8vzwdpkYaKcULH5Tis7/7DRHk2O17Nxy9fm9+SVJAtRSiUKc7 i/Z/ncpV8oWQJhCgbIMovQBzbdzABVDQJeL3XDLuzcW1BxCY7dlK1m87wVYcJWvz+bq1 HO+us6Z2Y1aCpRPiK0Vo9Q4TAID7rm+6rwELPnOOOWJr6VyKtNQehYZeZKjihVTtJi7y vx1IlPwJ/kfRCmdJBHcvQ/jYQM/cwPxC33fBjhKGNHbQtoF9QFKK2wKD/mYUxSy6WJe8 mWgJBnqzd7d/JEePIRra0ANFE+wO9JlseqIZBnk9KxO01xnpsEYqio9pMz955tSech5q D6hw== X-Gm-Message-State: AOAM5311pcIusEPb3wwGEiQJXAuOrkBcaXd1QjO3M6WZaeaUiJl8jzc/ kxEh8SKYvibAwTeYw6ooW84F6ZlNM/iuOJLRpzPFqS7vTm0= X-Google-Smtp-Source: ABdhPJxTcE7SfuuaFHOQHW9sckvKw8+V9mBTVXkhlOWlLH5uxOe2mulfSqc1LB4DUtcdav0iYp/9w2LNcUHCqReEhtA= X-Received: by 2002:a17:902:d508:b0:154:2f99:a52e with SMTP id b8-20020a170902d50800b001542f99a52emr7289037plg.102.1648148599793; Thu, 24 Mar 2022 12:03:19 -0700 (PDT) MIME-Version: 1.0 References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> <20220323215734.3927131-19-goldstein.w.n@gmail.com> In-Reply-To: <20220323215734.3927131-19-goldstein.w.n@gmail.com> From: "H.J. Lu" Date: Thu, 24 Mar 2022 12:02:43 -0700 Message-ID: Subject: Re: [PATCH v1 19/23] string: Expand page cross test cases in test-strcmp.c To: Noah Goldstein Cc: GNU C Library , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:03:21 -0000 On Wed, Mar 23, 2022 at 3:02 PM Noah Goldstein wrote: > > Test cases for when both `s1` and `s2` are near the end of a page > where previously missing. > --- > string/test-strcmp.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/string/test-strcmp.c b/string/test-strcmp.c > index 0abce769d0..ece03c6d0b 100644 > --- a/string/test-strcmp.c > +++ b/string/test-strcmp.c > @@ -392,7 +392,7 @@ check3 (void) > int > test_main (void) > { > - size_t i, j; > + size_t i, j, k; > const size_t test_len = MIN(TEST_LEN, 3 * 4096); > test_init (); > check(); > @@ -453,6 +453,19 @@ test_main (void) > do_test (j, getpagesize () - j - 1, i, 127, 1); > do_test (j, getpagesize () - j - 1, i, 127, -1); > > + for (k = 2; k <= 128; k += k) > + { > + do_test (getpagesize () - k, getpagesize () - j - 1, i, 127, 0); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i, 127, > + 0); > + do_test (getpagesize () - k, getpagesize () - j - 1, i, 127, 1); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i, 127, > + 1); > + do_test (getpagesize () - k, getpagesize () - j - 1, i, 127, -1); > + do_test (getpagesize () - k - 1, getpagesize () - j - 1, i, 127, > + -1); > + } > + > if (i < 32) > { > i += 1; > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu Thanks. -- H.J.