public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] loongarch: Remove duplicate strnlen in libc.a (BZ 31785)
Date: Wed, 22 May 2024 06:30:46 -0700	[thread overview]
Message-ID: <CAMe9rOrhakJS5ZeU5UeOzAjvjmbOwMYNEaFqkLc5tMyfT1_D_Q@mail.gmail.com> (raw)
In-Reply-To: <20240522132115.596912-1-adhemerval.zanella@linaro.org>

On Wed, May 22, 2024 at 6:21 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> The generic version provides weak definitions of strnlen,
> which are already provided by the ifunc resolver.
> ---
>  sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> index 9826d21c2e..3606225ca2 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> @@ -98,5 +98,7 @@ L(out):
>      jr          ra
>  END(STRNLEN)
>
> +#if !IS_IN (libc)
>  weak_alias (STRNLEN, strnlen)
>  libc_hidden_builtin_def (STRNLEN)
> +#endif
> --
> 2.43.0
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.

      reply	other threads:[~2024-05-22 13:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 13:21 Adhemerval Zanella
2024-05-22 13:30 ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOrhakJS5ZeU5UeOzAjvjmbOwMYNEaFqkLc5tMyfT1_D_Q@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).