* [PATCH] loongarch: Remove duplicate strnlen in libc.a (BZ 31785)
@ 2024-05-22 13:21 Adhemerval Zanella
2024-05-22 13:30 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella @ 2024-05-22 13:21 UTC (permalink / raw)
To: libc-alpha; +Cc: H . J . Lu
The generic version provides weak definitions of strnlen,
which are already provided by the ifunc resolver.
---
sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
index 9826d21c2e..3606225ca2 100644
--- a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
+++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
@@ -98,5 +98,7 @@ L(out):
jr ra
END(STRNLEN)
+#if !IS_IN (libc)
weak_alias (STRNLEN, strnlen)
libc_hidden_builtin_def (STRNLEN)
+#endif
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] loongarch: Remove duplicate strnlen in libc.a (BZ 31785)
2024-05-22 13:21 [PATCH] loongarch: Remove duplicate strnlen in libc.a (BZ 31785) Adhemerval Zanella
@ 2024-05-22 13:30 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2024-05-22 13:30 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On Wed, May 22, 2024 at 6:21 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> The generic version provides weak definitions of strnlen,
> which are already provided by the ifunc resolver.
> ---
> sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> index 9826d21c2e..3606225ca2 100644
> --- a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S
> @@ -98,5 +98,7 @@ L(out):
> jr ra
> END(STRNLEN)
>
> +#if !IS_IN (libc)
> weak_alias (STRNLEN, strnlen)
> libc_hidden_builtin_def (STRNLEN)
> +#endif
> --
> 2.43.0
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-22 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-22 13:21 [PATCH] loongarch: Remove duplicate strnlen in libc.a (BZ 31785) Adhemerval Zanella
2024-05-22 13:30 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).