From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by sourceware.org (Postfix) with ESMTPS id 1D006384DD3E for ; Wed, 22 May 2024 13:31:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D006384DD3E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D006384DD3E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716384684; cv=none; b=UUxLH+xEX36zukqimroeSXu9yY2n7HqmAdvDX3lW1QQ71vBSCRYLlqa9jzmZYVWDx5USNg8g7aXXNJDmcdn1qR3dLNHUFqPvxMXhy4uRs3iuaKmbTMkMU8fPe4MMI0dVl7oHY3iMpkStPa2PnkkEqt2E1steCdY9h0aCtaLMVB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716384684; c=relaxed/simple; bh=WJogZ8rC7/11FGsoVtpACcUj5BeCsldffdCVJh6sh0Y=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=R7fMfuVdMlnAsf8+cmV96X+mD7Tx9xzjDs1GGh9W2OZTJqxbWelXRYOiytMJsIg4tvZtgLJbcfzDw5aS9Ke+Xi2J1cTPBhpaSaQsMnrtuyMggMf7QlZYCvRcoyhI1dhzY0vTP4+lA7eJC1LTamRLwYUIK08FUEcZo8XmbNjI9+g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-61df903aa05so8205097b3.3 for ; Wed, 22 May 2024 06:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716384682; x=1716989482; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uptDE/NBjaiS2pS46uoSBk93vzdMOopxKdGRh0jD4dk=; b=SoczJQCfd0aRB5389fjIz9JKgXBNs0SmkrC+UmE9Enl09aK9Ki0+tx95ONFC5aesXN mjbCZYF51juvZoGIANZlOBU30taa8o3858qz0uL1ovam/mWZtH7ZAkyZZQGpZybrnVdk x2e/G3e1RBKwtfZaAan9PLsBi9tHO8UqNpFckg8radh/qxuNyO8VUjQUojL3Eg1YSKOK Ylms59Fh5AOEXdtu8hbK2xKoI2KgdIZXGpGkMJTRR3IoimPNONWR/F1hzZKxfzMpWANY FOemwrX/7AdgEKkMkiRJso9SoKV0YTbisB6RDty8BFgS1aeQph7bimcsFUvflW0O+Apr p8cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716384682; x=1716989482; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uptDE/NBjaiS2pS46uoSBk93vzdMOopxKdGRh0jD4dk=; b=SGhsW4xBRUBxNxxpFteX9OQJFHUG8iLcUTAZRKnty9TvIho7aM6r7lahFRcGfgZmV0 B9I/syspksRLbmhYP/Y066P0Qh5W3AhVmTBjGo7cBXkaNG6o44LBgZoMuThZoQF4D3AY wI/IkkGIdVPXEzUmWv0GaheylM/Ied60iPL13nOsi5VanHkHFM83gZDaWCCLWlgg+H3U l1SvF46NSMyednR6Ipb4XTiahgDxGHDlGlv3OpitlJS0LpyNH6CDRackQVz8R+xCwzoR JNqWKdn2jN7E+11nliEPcukIR01bs2Kf6RNHRBApqKWf69ECMS+qpOATskLsal6M48Kl IwPA== X-Gm-Message-State: AOJu0YwGWGS0vcnBhPan4Ef7xEmpwbW7DfRgtlUcaMUJcZcTUsJUFwMU MYrkTQK2xxcmBGFr+oXeZnX+9DG0f2ABt28qmQ7mJJeCNWiz/WArkIMpkV4ZhqnSW9u0jLMTIS2 LbXUjX5Coplyn1HAIbuNyajxoRaI= X-Google-Smtp-Source: AGHT+IHgRRbjbOS0P3yqq+9i+ZZB9A5sSb1eTZkzYltVNRbP4JOeNsGXeIaH2QpV1AExMzJ5xluqjfA9ZSMUBwpAbKE= X-Received: by 2002:a81:bf4f:0:b0:61a:dc61:25e2 with SMTP id 00721157ae682-627e48803d5mr27810507b3.49.1716384682289; Wed, 22 May 2024 06:31:22 -0700 (PDT) MIME-Version: 1.0 References: <20240522132115.596912-1-adhemerval.zanella@linaro.org> In-Reply-To: <20240522132115.596912-1-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Wed, 22 May 2024 06:30:46 -0700 Message-ID: Subject: Re: [PATCH] loongarch: Remove duplicate strnlen in libc.a (BZ 31785) To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 22, 2024 at 6:21=E2=80=AFAM Adhemerval Zanella wrote: > > The generic version provides weak definitions of strnlen, > which are already provided by the ifunc resolver. > --- > sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps= /loongarch/lp64/multiarch/strnlen-aligned.S > index 9826d21c2e..3606225ca2 100644 > --- a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S > +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S > @@ -98,5 +98,7 @@ L(out): > jr ra > END(STRNLEN) > > +#if !IS_IN (libc) > weak_alias (STRNLEN, strnlen) > libc_hidden_builtin_def (STRNLEN) > +#endif > -- > 2.43.0 > LGTM. Reviewed-by: H.J. Lu Thanks. --=20 H.J.