From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by sourceware.org (Postfix) with ESMTPS id 7324A3849AEF for ; Sat, 13 Apr 2024 15:50:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7324A3849AEF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7324A3849AEF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713023427; cv=none; b=fiRNuwWikUV+aYswU39AKVy0U6TdXx7JOHFO4W324RPw/mbuzMzwvBXk+bHeRnUGebmG77/uo2N6n78NdkEa/0hJMdQFUqpK555y2qPVy0LjtCzXutZ1wrbDKpeL5BPzLKoProzUjzwHLa71t5/Hd5hST0d+XmfP7LMytXBmMSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713023427; c=relaxed/simple; bh=gDt+/nJgGgjeldfyKfNNlTTMXf7GhNpKVCe3NHembjU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uGG5HGIEY8gnF1FHVIir59FarbsiphK/BYbx+B5eti28bTg02t1gDuu0X5YTdFak9TyLLWoHsn9Pc5ne3bM4edhRqKUjW9GHRZt00lyOvPBN1pvbPs2DVemXFiI0gHnXW8Jg/lf61TS2WxByK7DvI8iHYsP8o2YGeQX7+UoNYb8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-617e42a3f94so19769427b3.2 for ; Sat, 13 Apr 2024 08:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713023425; x=1713628225; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KsBSs1lWus/Kd7UAxAtG4mDAIiSs1CVkueBByl4ltco=; b=AOadJu6gV+5YPStqL4F4jEm44DgEgVvnvNJ0sUuoyWDs93YiuptT+oB1fNAKQLRXHy gIjgqZ4Kl6+zhCyuovLyxLdovb25KriKxaCdAIX9Z0uN/hCQMRK9/ePv9mzX35pw1mKA cguO+WBRWkqgqQtOl0+Bweo72cz/1IJGUdoyBeWC8MYDRZy8zwROVe4uuH889ehnFL4w aRs+KBtjBN9PH4WkiW+YNoYhBu99f1Hez4Nt5aDhMJmiglY9O07p8KBiQjssUmlPB45J XSb4ykL2JV5A1d6uFfL8/ep9zpU77IvByo8cPWR81GUwyZZ1atG/u0pY6RpuEUKdNMyW Jbwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713023425; x=1713628225; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsBSs1lWus/Kd7UAxAtG4mDAIiSs1CVkueBByl4ltco=; b=AoaWcvfGlWX7dlXbSBN9OwTqWS0mqb7FD7nfu4uiPCzobnW0kyZGITmDSZz1xuPxly L/0rZkYpb6R+lLEavfrLaRJFewrk8Bipm5+qBD+Rgocmg3MIESl3FfWfirs0Xd1zSjOC xalIrXK6qXqoptikxkBG0X7xFsROigoIpMOoXyLvOleP4Ozq8qQZdqvQ0iFHtH8pmtdw Txc1Yju+H4T2MeSBg5pBmQ118RD6Vakbt5g3/C1k4FrO3sS9SUi8d/7+sOX0kYQj/pHC Uz4eJ0V6nfs4bNm89UGxHyvS6kF8od5XD944HJb14D3+uEFjbSwAP5nK7YP5pXuFw2Hv CJbg== X-Gm-Message-State: AOJu0Yz38tW6zPAB9lHBUIZxzae++GmN6O7vq3F2JbQgdGRovqbOxnoI 6/Vqv5OHTpBllYLcP/CHjdXhuJVONotg2nk4F67mcG+NUjAHfGcznYd6PAzGoWzn4JC+4pJLCxP 4Rx4QNNLv6NMntsf0/B/PfMEMNxj9ft6E X-Google-Smtp-Source: AGHT+IHi6zH1fIGqzuKlWtli+o1XbJL4Lwq0CTx5fPwYgQQWH62AWm5bnT7Sb9pcB0nASMg8NyVE8u0ncGOry/7Oin8= X-Received: by 2002:a05:690c:6692:b0:60a:cd0:1a8e with SMTP id hz18-20020a05690c669200b0060a0cd01a8emr6013588ywb.3.1713023424607; Sat, 13 Apr 2024 08:50:24 -0700 (PDT) MIME-Version: 1.0 References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> <871q792ssr.fsf@oldenburg.str.redhat.com> In-Reply-To: From: "H.J. Lu" Date: Sat, 13 Apr 2024 08:49:48 -0700 Message-ID: Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" To: Florian Weimer Cc: libc-alpha@sourceware.org, Sunil K Pandey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 13, 2024 at 8:27=E2=80=AFAM H.J. Lu wrote= : > > On Sat, Apr 13, 2024 at 8:20=E2=80=AFAM Florian Weimer wrote: > > > > * H. J. Lu: > > > > > On Sat, Apr 13, 2024 at 8:03=E2=80=AFAM Florian Weimer wrote: > > >> > > >> * H. J. Lu: > > >> > > >> > On Sat, Apr 13, 2024 at 7:49=E2=80=AFAM Florian Weimer wrote: > > >> >> > > >> >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680. > > >> >> > > >> >> The test failure is a real valgrind bug that needs to be fixed be= fore > > >> >> valgrind is usable with a glibc that has been built with > > >> >> CC=3D"gcc -march=3Dx86-64-v3". The valgrind fix addresses the ob= served > > >> >> test failure as well. > > >> >> > > >> >> Upstream bug: > > >> >> > > >> >> Tested on x86_64-linux-gnu with and without CC=3D"gcc -march=3Dx8= 6-64-v3". > > >> >> The elf/tst-valgrind-smoke tests again fails with an unpatched va= lgrind, > > >> >> and the proposed upstream patch fixes it. (Apparently, valgrind > > >> >> matches on soname, and not the file name, which is ld.so in the t= est.) > > >> > > > >> > Please clarify that your patch fixes the glibc valgrind test by no= t using > > >> > strcmp-avx2.S in the valgrind test. > > >> > > >> Sorry, clarify where? In the commit message here? On the upstream = bug? > > > > > > In the glibc commit message. > > > > > >> My valgrind patch replaces the strcmp implementation in ld.so with i= ts > > >> own. > > >> > > > > > > Please mention it in the glibc commit message. > > > > Okay, I'll send a v2. > > > > Could someone proficient in x86-64 assembly have a look at my strcmp > > implementation? > > Can you adapt sysdeps/i386/i686/strcmp.S for valgrind? > You can use sysdeps/x86_64/strcmp.S from glibc 2.10: ENTRY (BP_SYM (strcmp)) L(oop): movb (%rdi), %al cmpb (%rsi), %al jne L(neq) incq %rdi incq %rsi testb %al, %al jnz L(oop) xorl %eax, %eax ret L(neq): movl $1, %eax movl $-1, %ecx cmovbl %ecx, %eax ret END (BP_SYM (strcmp)) --=20 H.J.