From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id EF0123950C1A for ; Mon, 19 Apr 2021 12:56:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EF0123950C1A Received: by mail-ot1-x32f.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso30515798otb.13 for ; Mon, 19 Apr 2021 05:56:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pX95WODt5WXCWv6wqbugGzKpiQMmf7WWnA+ITV5HOPY=; b=gAm3gDKgGtgWrUMxi0ghIYk9DTacnn3dkVLFwB4Aur9IpUOBT/alFHTLavIX0cMwHG 4DPkIaAUKmaSsW5+fNJVG0/Vqth6wVG3JoPsNnzQ7W1bVzQk0uuBWQ3SXumDWOllCLIw b6dJI/AqI6+mVarCFd3vlJ1F94vYlwtvb0cQhhHLKOq4I+LylyKuVh10Pz517E6Bkh6+ CaA3v2jmbEOfgVqWyf3ZLL5RTx3xvxziiLSRPYkxgvTPNOQvbpkeXo+8cS+WOZzSy9KF 81eUj0/y1zz4bmlEjC9NY8peEvQyFKbOICpoZrb8KvB9zZ9UCyQ00KHwyia6OM/PZ0Zf iMNg== X-Gm-Message-State: AOAM5338i5FfQ9eRRuyqLVpT8e/IZetG3rQb7D5tUVW+q+8nDUeW5LLA /Cd0oS5OOY82uuPp7VHgRrHRsPPZSnUupoXIoD9h6NdDWiA= X-Google-Smtp-Source: ABdhPJwkqAcovFriQSQpg8hGG4y1VRrdyt50jURWXi0TTCjAzn933w7cqKzPdGXr4k4++CHBu3tIefzmAPaKk0VMNlc= X-Received: by 2002:a05:6830:90c:: with SMTP id v12mr14719583ott.179.1618836965075; Mon, 19 Apr 2021 05:56:05 -0700 (PDT) MIME-Version: 1.0 References: <20210226211507.3430032-1-hjl.tools@gmail.com> In-Reply-To: <20210226211507.3430032-1-hjl.tools@gmail.com> From: "H.J. Lu" Date: Mon, 19 Apr 2021 05:55:29 -0700 Message-ID: Subject: PING^1 [PATCH] Run $(objpfx)iconvconfig as an installed program To: libc-alpha@sourceware.org Cc: Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3036.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Apr 2021 12:56:09 -0000 On Fri, Feb 26, 2021 at 1:15 PM H.J. Lu wrote: > > When glibc is configured with --enable-hardcoded-path-in-tests, > "make xcheck" failed with > > ... > env GCONV_PATH=3D/export/build/gnu/tools-build/glibc-cet-gitlab/build-x86= _64-linux/iconvdata LOCPATH=3D/export/build/gnu/tools-build/glibc-cet-gitla= b/build-x86_64-linux/localedata LC_ALL=3DC /export/build/gnu/tools-build/g= libc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig --output=3D$tmp --nos= tdlib /usr/lib64/gconv; > ... > /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/i= convconfig: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /= export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/icon= vconfig) > ... > FAIL: iconv/test-iconvconfig > > Since $(objpfx)iconvconfig is an installed program, run it as one. > --- > iconv/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/iconv/Makefile b/iconv/Makefile > index 659857dd8c..4af3eea0d8 100644 > --- a/iconv/Makefile > +++ b/iconv/Makefile > @@ -95,11 +95,13 @@ $(inst_bindir)/iconv: $(objpfx)iconv_prog $(+force) > $(objpfx)iconv_prog: $(iconv_prog-modules:%=3D$(objpfx)%.o) > $(objpfx)iconvconfig: $(iconvconfig-modules:%=3D$(objpfx)%.o) > > -$(objpfx)test-iconvconfig.out: /dev/null $(objpfx)iconvconfig > +$(objpfx)test-iconvconfig.out: $(objpfx)iconvconfig > (set -e; \ > tmp=3D$(objpfx)gconv-modules.cache.$$$$; \ > rm -f $$tmp; \ > - $(make-test-out) --output=3D$$tmp --nostdlib $(inst_gconvdir); \ > + $(built-program-cmd-before-env) \ > + $(run-program-env) $(built-program-cmd-after-env) $< \ > + --output=3D$$tmp --nostdlib $(inst_gconvdir); \ > cmp $$tmp $(inst_gconvdir)/gconv-modules.cache; \ > rm -f $$tmp) > $@; \ > $(evaluate-test) > -- > 2.29.2 > PING. --=20 H.J.