From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by sourceware.org (Postfix) with ESMTPS id C6B543858D3C for ; Thu, 1 Sep 2022 16:42:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C6B543858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2f.google.com with SMTP id n4so11283219qvt.7 for ; Thu, 01 Sep 2022 09:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ChHnSx6AfYjMDdcG+kOtwBohjIyJ89wBd1iLXeBEsVY=; b=V/0M2e8MgtrQcw93ci3PXhGW8gqHK40rXsHi+ml0LC/PiRk8clIL45SxvEuv6nG88c SI0RJqF4ZiRTY6uLWzlt7I12kXtjhqmOnQppMZn0LyBQAtK66a5aEPDVgUiK/dbrvR6H Kb4nhaqFLZVRprOLfRl8jliMjLmLAADoBdcSRZK4K3L0AUsLTW2edqe9efYr9/ZYwy/o o1vGUvd3/SO3nYb7+/A7uRkoPYbfNwsz1mfqUe+OmRdlJeMhTnux1gtpp97jrW4GSinQ r9YumR0xQlUbyAX1wTZk0SZuJeZObEWaAv4ZW1oOkJSqsh6kwP6m9Wu4I+Sl0JCM5KNL WZug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ChHnSx6AfYjMDdcG+kOtwBohjIyJ89wBd1iLXeBEsVY=; b=IZtHuo1xcgbx+nI6JRu1orA/qYmWTe+OIDZZOg/zb3oLpY7jFR2dq3dRbTukDkk121 1JneQrTXt22hn8vpf7Q8VchQLHXMPraxK7j4LKWnnHsrqEJDhLBaxCoi1auCyief6sJG 2aiCtFTRTiUIEQfWOFmTwCgj1v0vYyEnTTDnEg3DobZx8G5cm9wJ86sTlOAOyEIZ5mtE UsUXqsj7GtFm7Wy+5jWHIIg4qfy8FQ8aY/ynoIHsZJbCfEvizBJC5wJAvDoJ6ppirHAq /KaoogBeqLCYPMmooQ1pKshGslKRwZKQpq8Wqgl72piXjCN48WK037mjWOtWStX4szt2 sfxg== X-Gm-Message-State: ACgBeo1TEWRY+9IKlgDgPNKzXCyGLsQKlz5PF0Bi3CWYQ8SxbPhCI6XF 5Z92/BzoSFwAn5Sv4jfj5RtRP9u7GpYEmNDsVKVyedVKwRA= X-Google-Smtp-Source: AA6agR6APaSdK0FfrDJdIaMRAIGMrC+fFDTGvSyfBLdNV/feyb3wRn0dbb2kOc3jtH86mkQNu3kRHPEWTFp8KK5jeyw= X-Received: by 2002:a05:6214:62e:b0:499:2938:d49e with SMTP id a14-20020a056214062e00b004992938d49emr4963517qvx.84.1662050570133; Thu, 01 Sep 2022 09:42:50 -0700 (PDT) MIME-Version: 1.0 References: <20220901130253.1684344-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220901130253.1684344-1-adhemerval.zanella@linaro.org> From: "H.J. Lu" Date: Thu, 1 Sep 2022 09:42:14 -0700 Message-ID: Subject: Re: [PATCH] math: x86: Use prefix for FP_INIT_ROUNDMODE To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 1, 2022 at 6:03 AM Adhemerval Zanella via Libc-alpha wrote: > > Not all compilers support the inline asm prefix '%v' to emit the avx > instruction if AVX is enable. Use a prefix instead. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > --- > sysdeps/x86/fpu/sfp-machine.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/x86/fpu/sfp-machine.h b/sysdeps/x86/fpu/sfp-machine.h > index 5892f4f5fe..006eebe257 100644 > --- a/sysdeps/x86/fpu/sfp-machine.h > +++ b/sysdeps/x86/fpu/sfp-machine.h > @@ -39,9 +39,15 @@ typedef unsigned int UTItype __attribute__ ((mode (TI))); > > # define FP_RND_MASK 0x6000 > > +# ifdef __AVX__ > +# define AVX_INSN_PREFIX "v" > +# else > +# define AVX_INSN_PREFIX "" > +# endif > + > # define FP_INIT_ROUNDMODE \ > do { \ > - __asm__ __volatile__ ("%vstmxcsr\t%0" : "=m" (_fcw)); \ > + __asm__ __volatile__ (AVX_INSN_PREFIX "stmxcsr\t%0" : "=m" (_fcw)); \ > } while (0) > #else > # define _FP_W_TYPE_SIZE 32 > -- > 2.34.1 > Should we use __builtin_ia32_stmxcsr instead? -- H.J.