From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v4 3/5] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9
Date: Tue, 21 May 2024 13:05:13 -0700 [thread overview]
Message-ID: <CAMe9rOro=z-F0eKALh1cJOZ-2MeDyBJ8693U294qyxRaiZTdRg@mail.gmail.com> (raw)
In-Reply-To: <03c27032-173e-45aa-8bcc-f37177a1fedb@linaro.org>
On Tue, May 21, 2024 at 12:52 PM Adhemerval Zanella Netto
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 21/05/24 14:34, H.J. Lu wrote:
> > On Tue, May 21, 2024 at 9:54 AM Adhemerval Zanella
> > <adhemerval.zanella@linaro.org> wrote:
> >>
> >> Checked with a static build for the affected ABIs.
> >> ---
> >> sysdeps/ieee754/ldbl-64-128/s_copysignl.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/sysdeps/ieee754/ldbl-64-128/s_copysignl.c b/sysdeps/ieee754/ldbl-64-128/s_copysignl.c
> >> index 11b42d04ba..80137847d3 100644
> >> --- a/sysdeps/ieee754/ldbl-64-128/s_copysignl.c
> >> +++ b/sysdeps/ieee754/ldbl-64-128/s_copysignl.c
> >> @@ -1,10 +1,10 @@
> >> #include <math_ldbl_opt.h>
> >> #include <libm-alias-ldouble.h>
> >> -#if IS_IN (libc)
> >> +#if IS_IN (libc) && defined SHARED
> >> # undef libm_alias_ldouble
> >> # define libm_alias_ldouble(from, to)
> >> #endif
> >> #include <sysdeps/ieee754/ldbl-128/s_copysignl.c>
> >> -#if IS_IN (libc)
> >> +#if IS_IN (libc) && defined SHARED
> >> long_double_symbol (libc, __copysignl, copysignl);
> >> #endif
> >> --
> >> 2.43.0
> >>
> >
> > I think you should combine copysignf128, frexpf128, modff128 patches
> > and also fix scalbnf128 in a single patch for:
> >
> > https://sourceware.org/bugzilla/show_bug.cgi?id=31781
> >
>
> Ack, although scalbnf128 is already exported by libc.a.
The updated missing list is
copysignf128 copysignf64x frexpf128 frexpf64x modff128 modff64x
--
H.J.
next prev parent reply other threads:[~2024-05-21 20:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 16:52 [PATCH v4 0/5] Improve libm.a static coverage Adhemerval Zanella
2024-05-21 16:52 ` [PATCH v4 1/5] math: Add support for auto static math tests Adhemerval Zanella
2024-05-21 19:12 ` H.J. Lu
2024-05-21 16:52 ` [PATCH v4 2/5] math: Fix isnanf128 static build (BZ 31774) Adhemerval Zanella
2024-05-21 17:32 ` H.J. Lu
2024-05-21 16:52 ` [PATCH v4 3/5] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 Adhemerval Zanella
2024-05-21 17:34 ` H.J. Lu
2024-05-21 19:52 ` Adhemerval Zanella Netto
2024-05-21 20:05 ` H.J. Lu [this message]
2024-05-21 16:52 ` [PATCH v4 4/5] math: Provide frexpf128 " Adhemerval Zanella
2024-05-21 16:52 ` [PATCH v4 5/5] math: Provide modf128 " Adhemerval Zanella
2024-05-21 17:35 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOro=z-F0eKALh1cJOZ-2MeDyBJ8693U294qyxRaiZTdRg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).