From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com
 [IPv6:2607:f8b0:4864:20::436])
 by sourceware.org (Postfix) with ESMTPS id E16CC3858407
 for <libc-alpha@sourceware.org>; Thu,  4 Aug 2022 21:25:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E16CC3858407
Received: by mail-pf1-x436.google.com with SMTP id z187so587692pfb.12
 for <libc-alpha@sourceware.org>; Thu, 04 Aug 2022 14:25:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=1qeRejguQfJNH7vUM5dI2QY70kBqPi/vd/TlVdaQi4E=;
 b=V+ZWFgCOp7bfcEJmEFBhxLkwN6/nMP91ct2E0vOTarxDO2rN+P8GI9CO4720O2SHWe
 91LuG57PNoTHskXy91B7fEJ88kRJj3pEzQt23nGNA2h3Yj9zEQkclLmxrLTCOJVtOuAO
 hLL5J9vZKtiuxcvmWEO2P3IBPTvwGSkyVTgQ50LwgQlxjJPUsgpklEBe1I5pg3DClN36
 1aF/ph7EsUXFx6Dg9fkSczOcvvM8bx9PAGK6VMNNocwE8MojTP81/zYTzow3TlUPdEPh
 lgGZkb2H/T7ESBiR2UMvF05xnsk0tkqigxuXvt5ODtfTQ74OnIY/q59QztUxAE44dleM
 swig==
X-Gm-Message-State: ACgBeo2fi1dAiZVNiOGKGR/LqdOL3Rd9dEDgfmK6ecqqnb+QCFmp0ma+
 QkLoH2w3hAOVIIMnTBO81zVcm8B0czZaftqO+y6vNCGO
X-Google-Smtp-Source: AA6agR61QWPuGv8urY+PA4IZR1qr4olsfjL9c031PN/+AtEhiqRtJ6m01HyPxelVBmaoRBuLVFa18odj1Fu7n1NrOxc=
X-Received: by 2002:a63:82c2:0:b0:41b:c0f3:39b3 with SMTP id
 w185-20020a6382c2000000b0041bc0f339b3mr3099893pgd.86.1659648343835; Thu, 04
 Aug 2022 14:25:43 -0700 (PDT)
MIME-Version: 1.0
References: <20220804210037.2613528-1-adhemerval.zanella@linaro.org>
In-Reply-To: <20220804210037.2613528-1-adhemerval.zanella@linaro.org>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 4 Aug 2022 14:25:08 -0700
Message-ID: <CAMe9rOrq8O9f_W+K6+LR+P48U5ZMXydawUGSebOhbvJDzvWFmw@mail.gmail.com>
Subject: Re: [PATCH] i386: Use cmpl instead of cmp
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 Fangrui Song <maskray@google.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2022 21:25:46 -0000

On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> Clang cannot assemble cmp in the AT&T dialect mode.
> ---
>  sysdeps/i386/i686/multiarch/wcscpy-ssse3.S |  8 ++++----
>  sysdeps/i386/i686/multiarch/wcslen-sse2.S  | 16 ++++++++--------
>  2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S b/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> index 601e0f0138..fa6598c54d 100644
> --- a/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> +++ b/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> @@ -41,13 +41,13 @@ ENTRY (__wcscpy_ssse3)
>         mov     STR1(%esp), %edx
>         mov     STR2(%esp), %ecx
>
> -       cmp     $0, (%ecx)
> +       cmpl    $0, (%ecx)
>         jz      L(ExitTail4)
> -       cmp     $0, 4(%ecx)
> +       cmpl    $0, 4(%ecx)
>         jz      L(ExitTail8)
> -       cmp     $0, 8(%ecx)
> +       cmpl    $0, 8(%ecx)
>         jz      L(ExitTail12)
> -       cmp     $0, 12(%ecx)
> +       cmpl    $0, 12(%ecx)
>         jz      L(ExitTail16)
>
>         PUSH    (%edi)
> diff --git a/sysdeps/i386/i686/multiarch/wcslen-sse2.S b/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> index 5337286d41..d49a7ce355 100644
> --- a/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> +++ b/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> @@ -24,21 +24,21 @@
>  ENTRY (__wcslen_sse2)
>         mov     STR(%esp), %edx
>
> -       cmp     $0, (%edx)
> +       cmpl    $0, (%edx)
>         jz      L(exit_tail0)
> -       cmp     $0, 4(%edx)
> +       cmpl    $0, 4(%edx)
>         jz      L(exit_tail1)
> -       cmp     $0, 8(%edx)
> +       cmpl    $0, 8(%edx)
>         jz      L(exit_tail2)
> -       cmp     $0, 12(%edx)
> +       cmpl    $0, 12(%edx)
>         jz      L(exit_tail3)
> -       cmp     $0, 16(%edx)
> +       cmpl    $0, 16(%edx)
>         jz      L(exit_tail4)
> -       cmp     $0, 20(%edx)
> +       cmpl    $0, 20(%edx)
>         jz      L(exit_tail5)
> -       cmp     $0, 24(%edx)
> +       cmpl    $0, 24(%edx)
>         jz      L(exit_tail6)
> -       cmp     $0, 28(%edx)
> +       cmpl    $0, 28(%edx)
>         jz      L(exit_tail7)
>
>         pxor    %xmm0, %xmm0
> --
> 2.34.1


LGTM.

Thanks.

-- 
H.J.