From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 105BD3858D35 for ; Fri, 14 Jan 2022 14:32:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 105BD3858D35 Received: by mail-pg1-x52d.google.com with SMTP id x20so2917395pgk.1 for ; Fri, 14 Jan 2022 06:32:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dv5xiIzwXinic0K8wR4Lh7xDL4AA49F3a92CJ9/Rsw4=; b=bbNFs5qpg5nc7KN3VYEeRa9epL2hd4j9tJXwuzsQnn5nPKd5zyRgGnpvKD1/W+h+rE e8o89b6qmEmbJlTvlun7KTuHMFL9sdCxw8S2/9erB83rEjd6W1gB7gXk2IpMzJE70se/ 8Qz35SeD+cXAosH4SR6AYbcuVtyAXdWH6JCsMbKbKGrf4dxGYC2mB9Xv7QN1TY4G55ua xQofMUouYWMvdIDQ4xzn47Dfca1zAftkahoVH7DB0Uq0H/brxvNPQ/XXKw7yAjYYepJw eIKS0+SBScbVrUMbVScgQveq6FwlCO6HXkkXZqQpLA/59D7IyLEfezGFS5vQNWwi42kF 7DUg== X-Gm-Message-State: AOAM533wwkDDltW5FjbB6zPjLPd5Ze+CERQwNv4DY9O9/KmzP6PM8Rj1 BvQqxLTl84HtzRUk3CmJfSA2dGaU1mX2uRIInYluw86I X-Google-Smtp-Source: ABdhPJwdPG8+b1p6USDhmTrJlB00u9Do8Itl1aXi3l7XcIMtN64bHuTv0192Qb50GK0IRWUkXLwFyDouiqvMRFrBzV8= X-Received: by 2002:a05:6a00:1311:b0:4ba:1288:67dc with SMTP id j17-20020a056a00131100b004ba128867dcmr9134099pfu.43.1642170759139; Fri, 14 Jan 2022 06:32:39 -0800 (PST) MIME-Version: 1.0 References: <905c03a4ee231961ca1dd4fc74e49ebf97299b0d.1642162312.git.fweimer@redhat.com> <87lezitmsl.fsf@oldenburg.str.redhat.com> In-Reply-To: <87lezitmsl.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Fri, 14 Jan 2022 06:32:03 -0800 Message-ID: Subject: Re: [PATCH 3/7] elf: Split dl-printf.c from dl-misc.c To: Florian Weimer Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 14:32:41 -0000 On Fri, Jan 14, 2022 at 6:27 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Fri, Jan 14, 2022 at 4:42 AM Florian Weimer via Libc-alpha > > wrote: > >> > >> This allows to use different compiler flags for the diagnostics > >> code. > >> --- > >> elf/Makefile | 2 +- > >> elf/dl-misc.c | 281 +--------------------------------------------- > >> elf/dl-printf.c | 292 ++++++++++++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 297 insertions(+), 278 deletions(-) > >> create mode 100644 elf/dl-printf.c > >> > >> diff --git a/elf/Makefile b/elf/Makefile > >> index b86d116be9..0c4be43deb 100644 > >> --- a/elf/Makefile > >> +++ b/elf/Makefile > >> @@ -31,7 +31,7 @@ routines = $(all-dl-routines) dl-support dl-iteratephdr \ > >> # The core dynamic linking functions are in libc for the static and > >> # profiled libraries. > >> dl-routines = $(addprefix dl-,load lookup object reloc deps \ > >> - runtime init fini debug misc \ > >> + runtime init fini debug misc printf \ > >> version profile tls origin scope \ > >> execstack open close trampoline \ > >> exception sort-maps lookup-direct \ > > > > Should we put one item per-line now? > > And drop the addprefix? I can submit a separate patch for that. Yes. It will make adding the next file a bit easier. > Thanks, > Florian > -- H.J.