public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>,
	Thomas Schwinge <thomas@codesourcery.com>,
	bug-hurd@gnu.org,  GNU C Library <libc-alpha@sourceware.org>
Subject: [PATCH] Hurd: Add rtld-strncpy-c.c
Date: Mon, 18 Jan 2021 18:24:48 -0800	[thread overview]
Message-ID: <CAMe9rOrrM9jrrTcKoT3y_8nAn1YdYiMPfwHX08g2_Zs9iQ7rvw@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOonT9ky7nR7Xe7SYz188Xd_Oo8FEY0YuVs9jjVc9ARKzg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> >
> > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
> > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
> > > > Why doesn't hurd ld.so build script mark strncpy as needed?
> > >
> > > I don't even know what "hurd ld.so build script" is.
> >
> > More precisely, I don't see why hurd should be doing anything special
> > while everything is already taken care of by elf/Makefile's librtld.map
> > file scripts.
> >
>
> I am taking a look.
>

Try this.   I have no idea if it really works on hurd.

-- 
H.J.

[-- Attachment #2: 0001-Hurd-Add-rtld-strncpy-c.c.patch --]
[-- Type: text/x-patch, Size: 789 bytes --]

From a73010aaab13c5cd67ded77091601b8cd01e3fcf Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 18 Jan 2021 18:19:16 -0800
Subject: [PATCH] Hurd: Add rtld-strncpy-c.c

All IFUNC functions which are used in ld.so must have a rtld version if
the IFUNC version isn't safe to use in ld.so.
---
 sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c

diff --git a/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c b/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c
new file mode 100644
index 0000000000..b759c999eb
--- /dev/null
+++ b/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c
@@ -0,0 +1 @@
+#include <string/strncpy.c>
-- 
2.29.2


  reply	other threads:[~2021-01-19  2:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201108225251.3195591-1-samuel.thibault@ens-lyon.org>
     [not found] ` <87h7nl1425.fsf@dem-tschwing-1.ger.mentorg.com>
2021-01-18 20:05   ` [PATCH] Hurd: Enable ifunc by default Joseph Myers
2021-01-18 20:25     ` Samuel Thibault
2021-01-19  0:04     ` Samuel Thibault
2021-01-19  0:17       ` H.J. Lu
2021-01-19  0:21         ` Samuel Thibault
2021-01-19  0:24           ` Samuel Thibault
2021-01-19  0:40             ` H.J. Lu
2021-01-19  2:24               ` H.J. Lu [this message]
2021-01-19  9:02                 ` [PATCH] Hurd: Add rtld-strncpy-c.c Samuel Thibault
2021-01-19 12:21                   ` H.J. Lu
2021-01-19 12:25                     ` Adhemerval Zanella
2021-01-19 12:35                       ` H.J. Lu
2021-01-19 12:44                         ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOrrM9jrrTcKoT3y_8nAn1YdYiMPfwHX08g2_Zs9iQ7rvw@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=bug-hurd@gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).