From: "H.J. Lu" <hjl.tools@gmail.com>
To: Sunil K Pandey <skpgkp2@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] String: Improve test coverage for memchr
Date: Tue, 18 Oct 2022 08:44:31 -0700 [thread overview]
Message-ID: <CAMe9rOrrR39y6q56WAX8oZz6i1Z-6Zav8RnVYEsjNMBMwu03BQ@mail.gmail.com> (raw)
In-Reply-To: <20221018074400.1435168-1-skpgkp2@gmail.com>
On Tue, Oct 18, 2022 at 12:44 AM Sunil K Pandey via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> This test improves memchr coverage near page boundary.
> ---
> string/test-memchr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/string/test-memchr.c b/string/test-memchr.c
> index 1cbcd57fd4..ab206e05db 100644
> --- a/string/test-memchr.c
> +++ b/string/test-memchr.c
> @@ -251,6 +251,7 @@ test_main (void)
> /* page_size is in fact getpagesize() * 2. */
> do_test (page_size / 2 - i, i, i, 1, 0x9B);
> do_test (page_size / 2 - i, i - 1, i - 1, 1, 0x9B);
> + do_test (page_size / 2 - (i * 4), i + 128, i + 128, i, 0x9B);
> }
>
> do_random_tests ();
> --
> 2.36.1
>
LGTM.
Thanks.
--
H.J.
next prev parent reply other threads:[~2022-10-18 15:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 0:27 [PATCH] x86_64: Implement evex512 version of memchr, rawmemchr and wmemchr Sunil K Pandey
2022-09-22 0:50 ` Noah Goldstein
2022-09-23 3:57 ` Sunil Pandey
2022-09-29 3:42 ` Sunil Pandey
2022-09-29 4:07 ` Noah Goldstein
2022-10-03 18:33 ` Noah Goldstein
2022-10-03 19:00 ` H.J. Lu
2022-10-03 19:12 ` Noah Goldstein
2022-10-13 21:41 ` [PATCH v2] " Sunil K Pandey
2022-10-15 14:01 ` [PATCH v3] " Sunil K Pandey
2022-10-15 16:26 ` Noah Goldstein
2022-10-15 16:26 ` Noah Goldstein
2022-10-17 3:53 ` [PATCH v4] " Sunil K Pandey
2022-10-17 15:46 ` Noah Goldstein
2022-10-17 23:55 ` Sunil Pandey
2022-10-18 0:00 ` [PATCH v5] " Sunil K Pandey
2022-10-18 3:01 ` Noah Goldstein
2022-10-18 4:15 ` Sunil Pandey
2022-10-18 4:18 ` Noah Goldstein
2022-10-18 4:19 ` Noah Goldstein
2022-10-18 8:02 ` [PATCH v6] " Sunil K Pandey
2022-10-18 17:12 ` Noah Goldstein
2022-10-18 5:36 ` [PATCH v5] " Sunil Pandey
2022-10-18 6:30 ` Noah Goldstein
2022-10-18 7:44 ` [PATCH] String: Improve test coverage for memchr Sunil K Pandey
2022-10-18 15:44 ` H.J. Lu [this message]
2022-10-10 16:48 Sunil K Pandey
2022-10-10 16:52 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrrR39y6q56WAX8oZz6i1Z-6Zav8RnVYEsjNMBMwu03BQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).