From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by sourceware.org (Postfix) with ESMTPS id A47EF3849AF1 for ; Sat, 13 Apr 2024 15:09:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A47EF3849AF1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A47EF3849AF1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713020982; cv=none; b=Lf5c+1YB61qmS/lffgBUCzXUxsY7nhVl4qpmHujlA8z0zyltr6Gf5nDSO+K86ljMBgLEZlbSRKqD0V1yrzWpVAjFGzFG5rnztbF3AbMtBi2392Yy5+PdnzUG7ThPlovsnaAmtMrnOXnQqMVZQkyRrOcRYQPAOEADp0l+xOFowBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713020982; c=relaxed/simple; bh=xrpp9cqtUI/AtrIsZMXbVV3GkR39a5cz0d4e8lIDRBw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=dnXmwx7WOJGYWb748l//TXxdWWScYhiPoZZVcAtCHunbk4rlhXbNPm14jlrjLFrctbsSiYrAc1NINjscfe+lSw0i0kmSpHAqonzPMUpiu2Yn73tmF08yvPo2TG+P1eVNoZu/+kQZorZLVNBlTheFj/8H2H/oI9WX4F6jU4m574E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-618769020bcso19641767b3.3 for ; Sat, 13 Apr 2024 08:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713020980; x=1713625780; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qsuQwc9tz2Q5hOAPnyWCUIpQ8+3oU43okbrfQd8uMPg=; b=X40T+TwGxWJ7H9IuE2F+OCIvK7eFgiop6B7U2bJcDgTw1gK1rDRwe/LhmmcPDp+aZa xJLRyBowsIW3qegoEji8LtAnUQAQhM0uV/Hb1Dm8XN06HkqKqr3RwPg9EemaTRKv2xe+ HgUBRv+eOJ/F5WU18993+YnbQOCO4sbXc2rtaf7x//0loIErYNIZVUzLPXcIyRk8iIdb 9sr/2k81Ij1t+ro7anIK9kh8VFQEOa1uROXuY0eZ/b65I8yCujj2OGdCPV7RqAj7bwNv cMwmou1Wm+YjBB5D+5Cc6gkICWPpPwRBOqQQXFL+SVw05Du5cygSlYQdOn8VoxSPqt+R IYCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713020980; x=1713625780; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qsuQwc9tz2Q5hOAPnyWCUIpQ8+3oU43okbrfQd8uMPg=; b=DNbMIN5uihb5eAbCMcBkPzRiZ72WaW5gKd7TzyRhDlNRJT8Oqf3eOf3VrkcWdssmgK ro2oFvPmCAzeaYpQs6IN1S/tAfAMys7uEgR8aeZGMEicmGmuiBD0kgNSkEYOsCgAVqKg P3UGPoBCYILnkir7OqYx6SDi1vot4rg+/r1Yu3r4nuPcqSOaxJK08gqi1cE2Sb6S4sFR 2L9couX7urr2mbkigrIIgtC/0t4+pOC4w6nT+OYK7tr05VeasnKBJOwwpXhK4TZGXhv8 l3TGYHokEIcF7Mjd2LZwRZYbqTg6u8F3F9as6m1gOqh4bPvxB8MIe6ZaPm8acrrcXJux MZ1A== X-Gm-Message-State: AOJu0Yz/i9vZ0UJD9/3sgvYiHaa2z/EjwysRxFbjay565NLZzuKPqtf1 p3lLMJxVk/oPgib7ZzHM1s5lzz9fSqIwNBkh4qfiltq5zJGjLEZw1Qn7hO39tMtS/B3pqX5oevt 9h8Q+ZgzTQaBujB7a/xN1y/XbxKY= X-Google-Smtp-Source: AGHT+IHY5XmMBAivrbbsKn9EXMsoI3RDT4hl9eNJxkcyBdBnUngQYAesC4t3K41TV8DeKIjm8vE5P0zJ79xPBQzdkD0= X-Received: by 2002:a81:a00f:0:b0:618:1dab:2f04 with SMTP id x15-20020a81a00f000000b006181dab2f04mr5813137ywg.3.1713020980046; Sat, 13 Apr 2024 08:09:40 -0700 (PDT) MIME-Version: 1.0 References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> In-Reply-To: <875xwl2tku.fsf@oldenburg.str.redhat.com> From: "H.J. Lu" Date: Sat, 13 Apr 2024 08:09:04 -0700 Message-ID: Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" To: Florian Weimer Cc: libc-alpha@sourceware.org, Sunil K Pandey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 13, 2024 at 8:03=E2=80=AFAM Florian Weimer = wrote: > > * H. J. Lu: > > > On Sat, Apr 13, 2024 at 7:49=E2=80=AFAM Florian Weimer wrote: > >> > >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680. > >> > >> The test failure is a real valgrind bug that needs to be fixed before > >> valgrind is usable with a glibc that has been built with > >> CC=3D"gcc -march=3Dx86-64-v3". The valgrind fix addresses the observe= d > >> test failure as well. > >> > >> Upstream bug: > >> > >> Tested on x86_64-linux-gnu with and without CC=3D"gcc -march=3Dx86-64-= v3". > >> The elf/tst-valgrind-smoke tests again fails with an unpatched valgrin= d, > >> and the proposed upstream patch fixes it. (Apparently, valgrind > >> matches on soname, and not the file name, which is ld.so in the test.) > > > > Please clarify that your patch fixes the glibc valgrind test by not usi= ng > > strcmp-avx2.S in the valgrind test. > > Sorry, clarify where? In the commit message here? On the upstream bug? In the glibc commit message. > My valgrind patch replaces the strcmp implementation in ld.so with its > own. > Please mention it in the glibc commit message. --=20 H.J.