From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62087 invoked by alias); 11 May 2017 14:45:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 61825 invoked by uid 89); 11 May 2017 14:45:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=integrating X-HELO: mail-qk0-f170.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kY+3bSj9C3F6bod0c2t93YplmKugGR5JI2aOkP/Fl70=; b=MyNpjhR+fuuEKlPruqGat+QvMEDD8B1v3JvnQ/lgU+88xRsXXfn0MKH6y/4/e8a7ip nWURPJ351jcuBh1wEKcOVljdtgxerorNOr8LFXLL4kSReUXXr7idahI/u+vehP8VzklD SOzJkzmbllf1DXXsLywoN4GSRssP1Cm8nT7SX68g/+eaH1tat2Ac3qDc5bfeRuscy8jQ w9Y9EdxTAiz0+0F9hVr+GGMPRay53LhmWI0uj6SY4FwprUJNPycQJXvvTIcAfjoKyI46 zfJO8T3BiFi/OqgWUwuA1VlANjLYhNSAvGcdScpv/hKejkXF1plBMqLznQhCWSG4zmYf Eq8Q== X-Gm-Message-State: AODbwcDaUvDbtibT8SIZJIIFRLpHL/sAIT14fo2rtr8qKKFqqBV1BqHy ugN2gSClA0nLZhSc4BiXwQKHQTnCLw== X-Received: by 10.55.162.136 with SMTP id l130mr736049qke.275.1494513939173; Thu, 11 May 2017 07:45:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170511141836.GB26086@intel.com> From: "H.J. Lu" Date: Thu, 11 May 2017 14:45:00 -0000 Message-ID: Subject: Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++ To: Zack Weinberg Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-05/txt/msg00303.txt.bz2 On Thu, May 11, 2017 at 7:43 AM, Zack Weinberg wrote: > On Thu, May 11, 2017 at 10:39 AM, H.J. Lu wrote: >> On Thu, May 11, 2017 at 7:29 AM, Zack Weinberg wrote: >>> On Thu, May 11, 2017 at 10:18 AM, H.J. Lu wrote: >>>> Add __BEGIN_DECLS and __END_DECLS to support C++. >>>> >>>> Any comments? >>> >>> Could you please explain why you found this to be necessary? >>> ifunc-impl-list.h is an internal header which should never be compiled >>> as C++ in the first place. >> >> I am integrating memcpy_benchmark.cc: >> >> https://gist.github.com/ekelsen/b66cc085eb39f0495b57679cdb1874fa >> >> into glibc benchtests. It is a C++ program. > > This program does not appear to need ifunc-impl-list.h. Please elaborate. > Please see hjl/x86/optimize branch in glibc git repo. -- H.J.