From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id 36EE43857C65 for ; Mon, 27 Jul 2020 14:30:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36EE43857C65 Received: by mail-io1-xd41.google.com with SMTP id s189so9899108iod.2 for ; Mon, 27 Jul 2020 07:30:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z6PKDDDXv1dRYz4WippqMQNaWiwv7IRe/g4f//+oR04=; b=Qc6IJooOUrrfMENp2fevBYHuEbkHqMzzXNcMfViMuK3aJgs44miAdvrG7BENqRwNTK ZlYqqkNvuCImUV08rM6hyQjUxgmZi0/c+e8wZ5cNQ/PzUfBfI5ZgNVM8SIj95kmHQvTw LvwiaMeJyQXM4vW6WfEE88njRFgoF/9ECet42Vsgb7pm/WJ6OsQYjet7kwtEHVFKf/Ly h7cxowgucKgMMCEzkL5WT/eZsj0gy7rlHw1i/eHkudsDr5SFfFkP+uRPGgOCM7C5lfWj mbl9WVcnX4jjMc2xB8afllrx0s0CIS0pgQfLOXqmmqyjBAxBjdjz5oXQ1qlQEJifflos zIbA== X-Gm-Message-State: AOAM5307XA1Sn9VxjBGsyQmOxuu2MWtFdLA5PLQKrVYLUTuKAagJzr3u 0g160k24JiLy+7ZDnHyy9vbgaKPkdbzzpjl3onWbFw4D/QE= X-Google-Smtp-Source: ABdhPJyJcAw1/YcUsUKxXiUfTSRswHLzlPfAB7EUb0maeazlM5DSx9MqYAS24zJtkP1JEO1EN7Bvvj6cYwueC/NvGs4= X-Received: by 2002:a02:cd91:: with SMTP id l17mr26027146jap.88.1595860229657; Mon, 27 Jul 2020 07:30:29 -0700 (PDT) MIME-Version: 1.0 References: <20200716112651.2257283-1-hjl.tools@gmail.com> <87o8ofy8e7.fsf@oldenburg2.str.redhat.com> <56cafa21-37ea-b39e-8c84-afb258f0d17a@redhat.com> <87sgdqp434.fsf@oldenburg2.str.redhat.com> <180ab9db-d012-52c9-736f-437eecafc35b@redhat.com> <91e0af7e-5f5c-a994-d7bf-dd94c45dcd71@redhat.com> <6276e59d-a363-32a8-10b1-5e19dc065d6d@redhat.com> <6396e998-af22-deaf-3127-257059f9f46b@redhat.com> <87y2n54hv4.fsf@oldenburg2.str.redhat.com> <87sgddup2z.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87sgddup2z.fsf@oldenburg2.str.redhat.com> From: "H.J. Lu" Date: Mon, 27 Jul 2020 07:29:53 -0700 Message-ID: Subject: V3 [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248] To: Florian Weimer Cc: "Carlos O'Donell via Libc-alpha" , "Carlos O'Donell" Content-Type: multipart/mixed; boundary="0000000000001a0e6605ab6d2a1a" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 14:30:31 -0000 --0000000000001a0e6605ab6d2a1a Content-Type: text/plain; charset="UTF-8" On Mon, Jul 27, 2020 at 5:20 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Sun, Jul 26, 2020 at 11:00 PM Florian Weimer wrote: > >> > >> * Carlos O'Donell via Libc-alpha: > >> > >> > We can't fix this easily quickly. > >> > >> We can make this test a non-container xtest today. It's better than no > >> test at all. > >> > > > > Currently this test is in sysdeps/unix/sysv/linux/x86_64/x32/tst-setgroups.c > > since there are > > > > static int > > do_test (void) > > { > > int size; > > /* NB: Stack address is at 0xfffXXXXX. */ > > gid_t list[NGROUPS_MAX]; > > int status = EXIT_SUCCESS; > > > > and x32 stack starts at 0xfffXXXXX, which triggers this bug. Should > > it be moved to nptl/tst-setgroups.c? > > Yes, this would make sense to me. > Here is the updated patch to add nptl/tst-setgroups.c. OK for master? Thanks. -- H.J. --0000000000001a0e6605ab6d2a1a Content-Type: application/x-patch; name="0001-nptl-Zero-extend-arguments-to-SETXID-syscalls-BZ-262.patch" Content-Disposition: attachment; filename="0001-nptl-Zero-extend-arguments-to-SETXID-syscalls-BZ-262.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kd4lwd1b0 RnJvbSBkZDg2YWE3N2E1OTQ2NDkxMTcxMTk0YmE0NDAzNDY5OWM5YTdmZDI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFRodSwgMTYgSnVsIDIwMjAgMDM6Mzc6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBucHRsOiBa ZXJvLWV4dGVuZCBhcmd1bWVudHMgdG8gU0VUWElEIHN5c2NhbGxzIFtCWiAjMjYyNDhdCgpucHRs IGhhcwoKLyogT3Bjb2RlcyBhbmQgZGF0YSB0eXBlcyBmb3IgY29tbXVuaWNhdGlvbiB3aXRoIHRo ZSBzaWduYWwgaGFuZGxlciB0bwogICBjaGFuZ2UgdXNlci9ncm91cCBJRHMuICAqLwpzdHJ1Y3Qg eGlkX2NvbW1hbmQKewogIGludCBzeXNjYWxsX25vOwogIGxvbmcgaW50IGlkWzNdOwogIHZvbGF0 aWxlIGludCBjbnRyOwogIHZvbGF0aWxlIGludCBlcnJvcjsKfTsKCiAvKiBUaGlzIG11c3QgYmUg bGFzdCwgb3RoZXJ3aXNlIHRoZSBjdXJyZW50IHRocmVhZCBtaWdodCBub3QgaGF2ZQogICAgIHBl cm1pc3Npb25zIHRvIHNlbmQgU0lHU0VUWElEIHN5c2NhbGwgdG8gdGhlIG90aGVyIHRocmVhZHMu ICAqLwogIHJlc3VsdCA9IElOVEVSTkFMX1NZU0NBTExfTkNTIChjbWRwLT5zeXNjYWxsX25vLCAz LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbWRwLT5pZFswXSwgY21kcC0+aWRb MV0sIGNtZHAtPmlkWzJdKTsKCkJ1dCB0aGUgc2Vjb25kIGFyZ3VtZW50IG9mIHNldGdyb3VwcyBz eXNjYWwgaXMgYSBwb2ludGVyOgoKICAgICAgIGludCBzZXRncm91cHMoc2l6ZV90IHNpemUsIGNv bnN0IGdpZF90ICpsaXN0KTsKCkJ1dCBvbiB4MzIsIHBvaW50ZXJzIHBhc3NlZCB0byBzeXNjYWxs IG11c3QgaGF2ZSBwb2ludGVyIHR5cGUgc28gdGhhdAp0aGV5IHdpbGwgYmUgemVyby1leHRlbmRl ZC4gIFRoZSBrZXJuZWwgWElEIGFyZ3VtZW50cyBhcmUgdW5zaWduZWQgYW5kCmRvIG5vdCByZXF1 aXJlIHNpZ24gZXh0ZW5zaW9uLiAgQ2hhbmdlIHhpZF9jb21tYW5kIHRvCgpzdHJ1Y3QgeGlkX2Nv bW1hbmQKewogIGludCBzeXNjYWxsX25vOwogIHVuc2lnbmVkIGxvbmcgaW50IGlkWzNdOwogIHZv bGF0aWxlIGludCBjbnRyOwogIHZvbGF0aWxlIGludCBlcnJvcjsKfTsKCnNvIHRoYXQgYWxsIGFy Z3VtZW50cyBhcmUgemVyby1leHRlbmRlZC4gIEEgdGVzdGNhc2UgaXMgYWRkZWQgZm9yIHgzMiBh bmQKc2V0Z3JvdXBzIHJldHVybmVkIHdpdGggRUZBVUxUIHdoZW4gcnVubmluZyBhcyByb290IHdp dGhvdXQgdGhlIGZpeC4KLS0tCiBucHRsL01ha2VmaWxlICAgICAgICB8ICAyICstCiBucHRsL2Rl c2NyLmggICAgICAgICB8ICA4ICsrKystCiBucHRsL3RzdC1zZXRncm91cHMuYyB8IDc5ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQs IDg3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgbnB0 bC90c3Qtc2V0Z3JvdXBzLmMKCmRpZmYgLS1naXQgYS9ucHRsL01ha2VmaWxlIGIvbnB0bC9NYWtl ZmlsZQppbmRleCA1ZTYyYzc3ODUzLi44OTU2OWM0ZjQ2IDEwMDY0NAotLS0gYS9ucHRsL01ha2Vm aWxlCisrKyBiL25wdGwvTWFrZWZpbGUKQEAgLTMxMCw3ICszMTAsNyBAQCB0ZXN0cy1pbnRlcm5h bCA6PSB0c3Qtcm9idXN0cGk4IHRzdC1yd2xvY2sxOSB0c3Qtcndsb2NrMjAgXAogCQkgIHRzdC1z ZXRnZXRuYW1lIFwKIAogeHRlc3RzID0gdHN0LXNldHVpZDEgdHN0LXNldHVpZDEtc3RhdGljIHRz dC1zZXR1aWQyIFwKLQl0c3QtbXV0ZXhwcDEgdHN0LW11dGV4cHA2IHRzdC1tdXRleHBwMTAKKwl0 c3QtbXV0ZXhwcDEgdHN0LW11dGV4cHA2IHRzdC1tdXRleHBwMTAgdHN0LXNldGdyb3VwcwogCiAj IFRoaXMgdGVzdCBjYW4gcnVuIGludG8gdGFzayBsaW1pdHMgYmVjYXVzZSBvZiBhIGxpbnV4IGtl cm5lbCBidWcKICMgYW5kIHRoZW4gY2F1c2UgdGhlIG1ha2UgcHJvY2VzcyB0byBmYWlsIHRvbywg c2VlIGJ1ZyAyNDUzNy4KZGlmZiAtLWdpdCBhL25wdGwvZGVzY3IuaCBiL25wdGwvZGVzY3IuaApp bmRleCA2YTUwOWI2NzI1Li5hMGZjM2ZkYTBmIDEwMDY0NAotLS0gYS9ucHRsL2Rlc2NyLmgKKysr IGIvbnB0bC9kZXNjci5oCkBAIC05NSw3ICs5NSwxMyBAQCBzdHJ1Y3QgcHRocmVhZF91bndpbmRf YnVmCiBzdHJ1Y3QgeGlkX2NvbW1hbmQKIHsKICAgaW50IHN5c2NhbGxfbm87Ci0gIGxvbmcgaW50 IGlkWzNdOworICAvKiBFbmZvcmNlIHplcm8tZXh0ZW5zaW9uIGZvciB0aGUgcG9pbnRlciBhcmd1 bWVudCBpbgorCisgICAgIGludCBzZXRncm91cHMoc2l6ZV90IHNpemUsIGNvbnN0IGdpZF90ICps aXN0KTsKKworICAgICBUaGUga2VybmVsIFhJRCBhcmd1bWVudHMgYXJlIHVuc2lnbmVkIGFuZCBk byBub3QgcmVxdWlyZSBzaWduCisgICAgIGV4dGVuc2lvbi4gICovCisgIHVuc2lnbmVkIGxvbmcg aW50IGlkWzNdOwogICB2b2xhdGlsZSBpbnQgY250cjsKICAgdm9sYXRpbGUgaW50IGVycm9yOyAv KiAtMTogbm8gY2FsbCB5ZXQsIDA6IHN1Y2Nlc3Mgc2VlbiwgPjA6IGVycm9yIHNlZW4uICAqLwog fTsKZGlmZiAtLWdpdCBhL25wdGwvdHN0LXNldGdyb3Vwcy5jIGIvbnB0bC90c3Qtc2V0Z3JvdXBz LmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uYWUzYzFiMWJhMAotLS0g L2Rldi9udWxsCisrKyBiL25wdGwvdHN0LXNldGdyb3Vwcy5jCkBAIC0wLDAgKzEsNzkgQEAKKy8q IFRlc3Qgc2V0Z3JvdXBzIGFzIHJvb3QgYW5kIGluIHRoZSBwcmVzZW5jZSBvZiB0aHJlYWRzIChC dWcgMjYyNDgpCisgICBDb3B5cmlnaHQgKEMpIDIwMjAgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBJbmMuCisgICBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgR05VIEMgTGlicmFyeS4KKworICAg VGhlIEdOVSBDIExpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yCisgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2Vy IEdlbmVyYWwgUHVibGljCisgICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAgIHZlcnNpb24gMi4xIG9mIHRoZSBMaWNlbnNlLCBv ciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCisgICBUaGUgR05VIEMgTGli cmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAor ICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2Fy cmFudHkgb2YKKyAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIg UFVSUE9TRS4gIFNlZSB0aGUgR05VCisgICBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBm b3IgbW9yZSBkZXRhaWxzLgorCisgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9m IHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgICBMaWNlbnNlIGFsb25nIHdpdGggdGhl IEdOVSBDIExpYnJhcnk7IGlmIG5vdCwgc2VlCisgICA8aHR0cHM6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LiAgKi8KKworI2luY2x1ZGUgPHN0ZGxpYi5oPgorI2luY2x1ZGUgPGxpbWl0cy5oPgor I2luY2x1ZGUgPGdycC5oPgorI2luY2x1ZGUgPGVycm5vLmg+CisjaW5jbHVkZSA8ZXJyb3IuaD4K KyNpbmNsdWRlIDxzdXBwb3J0L3h0aHJlYWQuaD4KKyNpbmNsdWRlIDxzdXBwb3J0L3N1cHBvcnQu aD4KKyNpbmNsdWRlIDxzdXBwb3J0L3Rlc3QtZHJpdmVyLmg+CisjaW5jbHVkZSA8c3VwcG9ydC94 dW5pc3RkLmg+CisKKy8qIFRoZSBwdXJwb3NlIG9mIHRoaXMgdGVzdCBpcyB0byB0ZXN0IHRoZSBz ZXRncm91cHMgQVBJIGFzIHJvb3QgYW5kIGluCisgICB0aGUgcHJlc2VuY2Ugb2YgdGhyZWFkcy4g IE9uY2Ugd2UgY3JlYXRlIGEgdGhyZWFkIHRoZSBzZXRncm91cHMKKyAgIGltcGxlbWVudGF0aW9u IG11c3QgZW5zdXJlIHRoYXQgYWxsIHRocmVhZHMgYXJlIHNldCB0byB0aGUgc2FtZQorICAgZ3Jv dXAgYW5kIHRoaXMgb3BlcmF0aW9uIHNob3VsZCBub3QgZmFpbC4gTGFzdGx5IHdlIHRlc3Qgc2V0 Z3JvdXBzCisgICB3aXRoIGEgemVybyBzaXplZCBncm91cCBhbmQgYSBiYWQgYWRkcmVzcyBhbmQg dmVyaWZ5IHdlIGdldCBFUEVSTS4gICovCisKK3N0YXRpYyB2b2lkICoKK3N0YXJ0X3JvdXRpbmUg KHZvaWQgKmFyZ3MpCit7CisgIHJldHVybiBOVUxMOworfQorCitzdGF0aWMgaW50Citkb190ZXN0 ICh2b2lkKQoreworICBpbnQgc2l6ZTsKKyAgLyogTkI6IFN0YWNrIGFkZHJlc3MgY2FuIGJlIGF0 IDB4ZmZmWFhYWFggb24gMzItYml0IE9TZXMuICAqLworICBnaWRfdCBsaXN0W05HUk9VUFNfTUFY XTsKKyAgaW50IHN0YXR1cyA9IEVYSVRfU1VDQ0VTUzsKKworICBwdGhyZWFkX3QgdGhyZWFkID0g eHB0aHJlYWRfY3JlYXRlIChOVUxMLCBzdGFydF9yb3V0aW5lLCBOVUxMKTsKKworICBzaXplID0g Z2V0Z3JvdXBzIChzaXplb2YgKGxpc3QpIC8gc2l6ZW9mIChsaXN0WzBdKSwgbGlzdCk7CisgIGlm IChzaXplIDwgMCkKKyAgICB7CisgICAgICBzdGF0dXMgPSBFWElUX0ZBSUxVUkU7CisgICAgICBl cnJvciAoMCwgZXJybm8sICJnZXRncm91cHMgZmFpbGVkIik7CisgICAgfQorICBpZiAoc2V0Z3Jv dXBzIChzaXplLCBsaXN0KSA8IDApCisgICAgeworICAgICAgaWYgKGVycm5vID09IEVQRVJNKQor CXN0YXR1cyA9IEVYSVRfVU5TVVBQT1JURUQ7CisgICAgICBlbHNlCisJeworCSAgc3RhdHVzID0g RVhJVF9GQUlMVVJFOworCSAgZXJyb3IgKDAsIGVycm5vLCAic2V0Z3JvdXBzIGZhaWxlZCIpOwor CX0KKyAgICB9CisKKyAgaWYgKHN0YXR1cyA9PSBFWElUX1NVQ0NFU1MgJiYgc2V0Z3JvdXBzICgw LCBsaXN0KSA8IDApCisgICAgeworICAgICAgc3RhdHVzID0gRVhJVF9GQUlMVVJFOworICAgICAg ZXJyb3IgKDAsIGVycm5vLCAic2V0Z3JvdXBzIGZhaWxlZCIpOworICAgIH0KKworICB4cHRocmVh ZF9qb2luICh0aHJlYWQpOworCisgIHJldHVybiBzdGF0dXM7Cit9CisKKyNpbmNsdWRlIDxzdXBw b3J0L3Rlc3QtZHJpdmVyLmM+Ci0tIAoyLjI2LjIKCg== --0000000000001a0e6605ab6d2a1a--