public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Martin Galvan <omgalvan.86@gmail.com>
To: Torvald Riegel <triegel@redhat.com>
Cc: siddhesh@sourceware.org, Joseph Myers <joseph@codesourcery.com>,
	 libc-alpha@sourceware.org
Subject: Re: [PATCH v11] Add pretty printers for the NPTL lock types
Date: Thu, 22 Dec 2016 16:44:00 -0000	[thread overview]
Message-ID: <CAN19L9Feu-=SAiwuTxsb1HNM96RhbrttFG7Q3O_AH=X942jRag@mail.gmail.com> (raw)
In-Reply-To: <1482424494.14990.810.camel@redhat.com>

2016-12-22 13:34 GMT-03:00 Torvald Riegel <triegel@redhat.com>:
> Is there any way to specify a different gdb binary during configure time
> or such?  I've only seen the hard-coded value in
> scripts/test_printers_common.py.

I didn't touch any configure scripts for this patch. Sid was working
on a patch for detecting the python program at configure time, perhaps
he can do something similar for gdb?

I'm personally focused on the install patch, though I don't think I'll
have it ready for 2.25 as I'm doing all this in what little free time
I have.

> Testing the pretty printers if the build host gdb isn't ready out of the
> box is quite annoying.

How so? IIRC the tests should return UNSUPPORTED when gdb is absent.
Are you seeing something different?

> It would be good if README.pretty-printers could
> be improved to cover this.

The README says:

"The tests run on the glibc host, which is assumed to have both gdb
and PExpect; if any of those is absent the tests will fail with code
77 (UNSUPPORTED)."

What do you suggest? Should it mention that the gdb binary should
actually be called "gdb" and be somewhere within PATH?

  reply	other threads:[~2016-12-22 16:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-27  3:04 Martin Galvan
2016-11-28 12:11 ` Stefan Liebler
2016-11-28 16:00   ` Martin Galvan
2016-12-04 12:41 ` Siddhesh Poyarekar
2016-12-04 20:56   ` Martin Galvan
2016-12-08 13:36   ` Siddhesh Poyarekar
2016-12-08 18:56     ` Joseph Myers
2016-12-08 21:01       ` Martin Galvan
2016-12-12 20:55       ` Martin Galvan
2016-12-12 23:15         ` Joseph Myers
2016-12-12 23:21           ` Martin Galvan
2016-12-14 18:20         ` Joseph Myers
2016-12-14 19:46           ` Martin Galvan
2016-12-17 18:10             ` Martin Galvan
2016-12-17 19:07               ` Siddhesh Poyarekar
2016-12-17 19:09                 ` Martin Galvan
2016-12-22 16:35                   ` Torvald Riegel
2016-12-22 16:44                     ` Martin Galvan [this message]
2016-12-22 22:50                       ` Torvald Riegel
2016-12-22 23:40                         ` Martin Galvan
2016-12-23 17:05                           ` Torvald Riegel
2016-12-23 17:40                             ` Martin Galvan
2016-12-23 18:05                               ` Martin Galvan
2016-12-23 18:48                               ` Torvald Riegel
2016-12-23 19:38                                 ` Martin Galvan
2016-12-26 14:17                                   ` Martin Galvan
2017-01-02 12:48                                     ` Martin Galvan
2017-01-02 13:51                                       ` Joseph Myers
2017-01-02 14:35                                         ` Martin Galvan
2017-01-02 15:47                                           ` Torvald Riegel
2017-01-02 21:51                                           ` Joseph Myers
2017-01-03  7:27                                             ` Siddhesh Poyarekar
2017-01-06 21:58                                   ` Torvald Riegel
2017-01-09 19:37                                     ` Martin Galvan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN19L9Feu-=SAiwuTxsb1HNM96RhbrttFG7Q3O_AH=X942jRag@mail.gmail.com' \
    --to=omgalvan.86@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    --cc=triegel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).