From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id CBB153858D32 for ; Sun, 12 Feb 2023 16:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBB153858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x432.google.com with SMTP id j184so1543681pfg.10 for ; Sun, 12 Feb 2023 08:14:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yjEOaGmswZT7Mw1t2FeGYHCxrEXBMA8P0vIEqtFk+NU=; b=GHeR4ljANNEJFim3EGSL/P+5rrND4Hk+gtC3cCxrBiTQscFgU+gbSbTytlO2D0PZKd UQPBGhB4I8xSy0pBIIHHLR4Gw2OiPl53Enhc4SfSLiAJpfmr/w6ZjDfBuHXHoT4Jkky/ /wGBX37ToQr3Qcz2IHaN/Rb2UuirBulNg7otjw6OG/MsaolIh0koE04q9xw/T/6FWbKX KXrWjiUKY9HrJE+++inbeqlvveIUqUtg2fiU/MPvqXIWn5ER4+k5PDcwOmtxmHpD+CAT Ux8TXI+o0EsUnZWnSKe4TKQ2uQjhDxlJd2Ly3mZjVPWvS48bbOCDdAEJ/W/4hrp8/TVF Jkiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yjEOaGmswZT7Mw1t2FeGYHCxrEXBMA8P0vIEqtFk+NU=; b=WCFJE8ZjmoZYiP8aizBZFQSTeSmgaEust0lECXY6SimME3hMY569+umDISxLAmZnO7 OdM76txwFOH8u2qFH+h6yllBw8mVCwLsObKAN+0bz4ZI/2A2TDHxRL0m/V+fBAKuoInr FEIWjppld1Gil5Cm6ltYcbUC0KaIqK1BOWqwUHnDK2XfBgnLDqJOO3zvjPpYNmENaETP MHFEImuPSfcaw+KGkw5kiJfBSyOfZ5nvd5plMx/ZAuOblJItuvjm7g7dTAAvwmp4Eg1O K76ocxi6dzk6NxsxSRKaSZiRTKT+Xyw8rrly7RfLpDKHKqMjHh/nowZLmlIWiDCpntOz iheQ== X-Gm-Message-State: AO0yUKXC6KawBWj//96Dk6Har86By9kBEhLh92gN0UFsRCi3dzZrXzJ0 PYcbBmP/VUTZiqeTmqNJhlkVHVUEhwZQn+o1XLk= X-Google-Smtp-Source: AK7set+ybddjbQ6gkSrAn/AQp90LOYE7BhHkdZxwskaAORgs82GOBzjvGSMo8Q6iz+Olk1yThp85DMVODdWhmnIi2vY= X-Received: by 2002:a63:7a0b:0:b0:4fb:b024:abd7 with SMTP id v11-20020a637a0b000000b004fbb024abd7mr39053pgc.23.1676218449768; Sun, 12 Feb 2023 08:14:09 -0800 (PST) MIME-Version: 1.0 References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-7-bugaevc@gmail.com> <20230212150011.sjntfvmkxzuu6iqt@begin> <20230212152254.y7mxeu5vxh7lzetx@begin> In-Reply-To: <20230212152254.y7mxeu5vxh7lzetx@begin> From: Sergey Bugaev Date: Sun, 12 Feb 2023 19:13:58 +0300 Message-ID: Subject: Re: [RFC PATCH hurd 6/12] hurd: Fix modes_t and speeds_t types on 64-bit To: Samuel Thibault Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?UTF-8?B?RmzDoXZpbyBDcnV6?= Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Feb 12, 2023 at 6:22 PM Samuel Thibault wrote: > I'd rather say drop the "long" part, to avoid having to pull the > stdint.h header in. That's what I meant, yes. > Nowadays' BSD headers just use the int type, > notably. So given that the Linux port has its own bits/termios.h, is it fine to just modify the generic one inline, rather than creating a Hurd-specific version? The patch for that follows. Sergey -- >8 -- >From 625b774141823a8f504cce8a92b9f45f5e6f050f Mon Sep 17 00:00:00 2001 From: Sergey Bugaev Date: Sun, 12 Feb 2023 19:08:57 +0300 Subject: [PATCH] hurd: Fix tcflag_t and speed_t types on 64-bit These are supposed to stay 32-bit even on 64-bit systems. This matches BSD and Linux, as well as how these types are already defined in tioctl.defs Signed-off-by: Sergey Bugaev --- bits/termios.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bits/termios.h b/bits/termios.h index 4439c2f1..6a883ceb 100644 --- a/bits/termios.h +++ b/bits/termios.h @@ -99,13 +99,13 @@ `tcflag_t', `cc_t', `speed_t' and the `TC*' constants appropriately. */ /* Type of terminal control flag masks. */ -typedef unsigned long int tcflag_t; +typedef unsigned int tcflag_t; /* Type of control characters. */ typedef unsigned char cc_t; /* Type of baud rate specifiers. */ -typedef long int speed_t; +typedef int speed_t; /* Terminal control structure. */ struct termios -- 2.39.1