From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id BC2463858C31 for ; Mon, 3 Apr 2023 09:32:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC2463858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-177b78067ffso30077130fac.7 for ; Mon, 03 Apr 2023 02:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680514339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SYWLBpJFeH8RPrGhh8U3fRK539jFPtUjD6a/Jyj+23Q=; b=UZBuWM1V+Sgv4OW4MCrjs0/+M1v6Sg/YLAF77dwNj9ftkt3ORK1TXWwMUCL1+Tgjq0 XQys17p9C4v0JImMfY6s4Iz5S5WiqPFXqYyMFXEAJ1j89mooUFrdqai/y+Uciv1L+Ob4 gtWFDbZXKSjLnYJII85mZro+xFIyWgpehl5EP3pS3tNjUbe+jual14SS8IQOROIx/bD7 aDxQM4AH0bdf6cYISb5orUxEfPLx0aUQFkIXVhn6LO51uY/LZxEPSsKiYbYBh2qRup4h 4QYHWFZB2GcnGrlKG/RysuB7DEYWTJZFVxqgI57IrV5ZlsxdBGngNsiXFe/w94DBL3eT OxNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680514339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SYWLBpJFeH8RPrGhh8U3fRK539jFPtUjD6a/Jyj+23Q=; b=ZXrs4idkAZXj/Jm/RaHwS59gO4Ap95K2sv901vUOpvAN9uvlMUe8WDc7D/ZPapXFUK GUtf6BzxddmbASIcMUHUyfXXJXi8fq6CkRVngjfqipi7tIPwyMTO6oDZ4QI/Gyvas/Du /8QhWaMrln4gVyxHTxbYdNWDX3L/0i0UJC/vVWIqyqoqmu2CJVCFgP2bA8db0sFp9d/p Aeb/CPoUnqJmgESXLms9t2EMXITeIhRn3W3TI1gO8NBeIVrJYpOVSvAYwhkQm7Db7WS6 tI+APDhDZQKEw81h3ez7Yy3KVUmqWiAJxkoaE5DULvnCiy5SmGs50ZOTMIwcuBBk1oSm 6V9A== X-Gm-Message-State: AAQBX9cK844KTDChvTed2VYH/yUuaIX2cthDnwOADH0nwxMxdIbsdjkA YiuHbifxu/qUtwy3g1Nu6PTKeADVkjVvB2SGb0ssNuhEkag= X-Google-Smtp-Source: AKy350aQMx6UrpYoPXqduCN72BvYkJEwpuNq7r41h1YNmsuQGPdCNXomLBWi+C4RXiwZiOujQZg61GWmL8sa1UCY7cU= X-Received: by 2002:a05:6870:420c:b0:180:511f:5366 with SMTP id u12-20020a056870420c00b00180511f5366mr3750551oac.5.1680514339093; Mon, 03 Apr 2023 02:32:19 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-4-bugaevc@gmail.com> <20230402224557.3cmvy5ztbxr2n7fm@begin> In-Reply-To: <20230402224557.3cmvy5ztbxr2n7fm@begin> From: Sergey Bugaev Date: Mon, 3 Apr 2023 12:32:08 +0300 Message-ID: Subject: Re: [RFC PATCH gnumach 03/34] Make exception subcode a long To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org, Luca Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 3, 2023 at 1:45=E2=80=AFAM Samuel Thibault wrote: > Sergey Bugaev, le dim. 19 mars 2023 18:09:46 +0300, a ecrit: > > On EXC_BAD_ACCESS, exception subcode is used to pass the faulting memor= y > > address, so it needs to be (at least) pointer-sized. Thus, make it into > > a long. > > > > This requires matching changes in glibc and the Hurd. > > But the change doesn't affect 32bit glibc and hurd since > rpc_long_integer_t is really like integer_t there, right? It's supposed to be ABI-compatible on 32-bit, since all these types are 32-bit integers there, yes. (But maybe I messed up, do check!) But it may break source-level compatibility (if you only apply the Mach change but not glibc, or vice versa); as in maybe GCC will complain about int vs long in function prototype vs definition. I haven't actually checked, since I have both changes applied locally. Sergey