From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id C6BB63858D1E for ; Sun, 19 Mar 2023 15:39:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6BB63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id o11so10062901ple.1 for ; Sun, 19 Mar 2023 08:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679240372; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v1F++ENc9j7EUnucJrn0AHnoWDquHjP08xbIpy+gJ6g=; b=Q1hFVGnzR1z1E7/Ru2Y0OT7A+efhyhDzTcPWwrJuw/rYe3kBYDiZqeZT2qwKLYuYTX p3qhuASlkDdIlsvXD+Jwiei/GTyu4rPa8yiBFCEEnnjAeLCJ3oF5aZ8vDxUM3VxN+b97 OEvuQfvu3NTEPaaDWumtfl1cpbYul/hb/QYYvTzIzlaDaB7Yr/3MGuBY+SkHqVTT2/nq rA+BLcw0EAzapueYZ2jTgAMMo1fmdtBVFYN7LJsRFk8EanVApERNh1o1ZfTjCTsbeCrs cyfxgd19NAu2Hhj9PhXJkje95YdpuYLX1tI0EhN9I7XxKdUZ2QPbhQjjq2eE1CnXGiMP ax0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679240372; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v1F++ENc9j7EUnucJrn0AHnoWDquHjP08xbIpy+gJ6g=; b=ivpNAungzOrKHQ3wzI3aKYRYBHYBq0Lefp4OFTGU06k8LHDXUEXH61SV9cjXo5wAwf KqcA7f5qjvq1zNBPkLIpdyaqrEuXw2CqnEMVcCjO91Y9zwW9zFGb8/0XBgWyd8fgl1a0 251WEnvtsPL236Xh0qs1wFOIqa92IQ797C2By/1mOYmdaoLillfwJB++J/12QUgZG9Na 1TmPrzak6cuukETzgByROnwKPOY5rp8XbPNea6efAu6/uRt9q/GqMyTI2FZaRkbByevV 5o4LHVgvX19T/pqk+Yj4DLcuEojNK/uh4sK+QOKJHGZBYNRFPxF5OEHZY2FsdbPMRunz 8qxg== X-Gm-Message-State: AO0yUKXPjRDxzS/3FDiy+52LE4/5hHJ8tzfJQlyNxUOmJjULtbaf0WBD esx/krrLfkNr3EentwppxtrpjZD1FkJv4ha5pY8SvVA+clCXsQ== X-Google-Smtp-Source: AK7set8iziQBPXS+sNtvWL4C7L2LIYfqQqTDjkcMIIgRj6g6cN2QhSLak/pNCO7IJSKmvjE16tJmzXPjSDlRlK9CKjU= X-Received: by 2002:a17:903:32d1:b0:19f:3cc1:e3be with SMTP id i17-20020a17090332d100b0019f3cc1e3bemr5619156plr.12.1679240371827; Sun, 19 Mar 2023 08:39:31 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-34-bugaevc@gmail.com> <20230319151943.6mo7bsaxz33774gw@begin> In-Reply-To: <20230319151943.6mo7bsaxz33774gw@begin> From: Sergey Bugaev Date: Sun, 19 Mar 2023 18:39:20 +0300 Message-ID: Subject: Re: [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach,hurd}user To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Mar 19, 2023 at 6:19=E2=80=AFPM Samuel Thibault wrote: > > Hello, > > Thanks for this work! :D Yay! Can you believe just how glad I am to finally have completed it :D > I don't have the time now to review the whole series, just a comment > here: we don't really want to introduce abilist for lib{mach,hurd}user > since their content will depend on the mach/hurd version glibc gets > built against. But isn't accidental ABI breakage (or unintended ABI additions) exactly what the abilist mechanism is designed to guard against? It doesn't even break your build (unlike -Werror) -- it's more of a lint. You *would* want to know if your libhurduser.so build suddenly doesn't include, say, proc_pid2task, because user code links to lib{mach,hurd}user (via the libc.so linker script) and uses those symbols, and would break if the symbols were to disappear. No? Well in any case, the abilists aren't essential. Freel free to drop this commit (and remove lib{mach,hurd}user.abilist from the next one) if that was the wrong call. Sergey