From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 74A083858D28 for ; Wed, 12 Apr 2023 08:37:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74A083858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x229.google.com with SMTP id q28so303109oiw.5 for ; Wed, 12 Apr 2023 01:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681288630; x=1683880630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h8JpDC9/3kdgC2gqUOX/2KzwMrF2H7pQ8QuBzuDwU1s=; b=jvtwsuy/sVMsHArGjGMaPEE/e7zkQEnn95WKF+IFCBoZjqIKIdJPk5fKqzptlcYJRB 2lxzVJbY6bEjQ0TvQkCm82tlOnJdv6kIEmru+BVSY17t0cl3FQ4F/diVJfLO/UgrYIm9 GjWlpJEMT5mF0X+2OTEZLXQJNF6UpC5rJ5wK1UPSDg/GYooOBBpMK4Uwz0vMeLKbbhrR S5q0CyK4s8m7Xb9wvOe0KfMhDPp13c1WML3RFaAORydfnYfIfaX6jzTMxXKvFbPCFwTE xplXvAprK5XyPlxfx/egV8zu3Kxvk6/2cuQ6myFEQBldRb4/1qrXh/KSG2MNf3x6OVOm dEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681288630; x=1683880630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8JpDC9/3kdgC2gqUOX/2KzwMrF2H7pQ8QuBzuDwU1s=; b=wvATmW5Y9dYVbr8QrXB1F7ZnK/PKqeg1QyzTuQSthEH4oFkKoJZFHyDO2m25qLhV6+ bGmtD/kmYS7kyA3J1kyf5nnRMvZ+kOPi/9873xvFqH+ymW6qC0Z9vV2BBSqMxsAxgrpX 5u2WfsBBpw+bZR1YJOGb5C8LpTGOsWx1A4k7QxABc/2ErIiwBR/pmWfsujhClTLdhvPq 1PGir0l7w6sAjzvzYzD+ROIJRV3vOBZlx0kEUbqHD0axb0mOssZSwa6Cq+RHnPMDA5bw lIY+Dg5pAgi3WXF1zIYHaSkL2asUxDkic8XqSe2cfEKsaN/y6amQuZJVevFGouSVowP0 BCWg== X-Gm-Message-State: AAQBX9c+J2ArUrDk2VRR7A+pfNDJFarudzyQmsA4eXBnbl7773VlvtVS TApQELx2c+q0jc9FMH4HeeenHpe0FC+wSDy/+1qLBfAIiBM= X-Google-Smtp-Source: AKy350bNVZWkVHWwC3B5KjoU2T7Kq/NLpj/WoOB0TbF46Y+1KNmlRdD9gXBy04bI2FGYqjvcnJQqOnuXvrZ0XUcVDtU= X-Received: by 2002:aca:6505:0:b0:387:251b:71fa with SMTP id m5-20020aca6505000000b00387251b71famr1448720oim.4.1681288629663; Wed, 12 Apr 2023 01:37:09 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-25-bugaevc@gmail.com> <20230411185705.22jygrepjq4mhbvk@begin> <20230411212346.ligmclr5ph7gowl5@begin> In-Reply-To: <20230411212346.ligmclr5ph7gowl5@begin> From: Sergey Bugaev Date: Wed, 12 Apr 2023 11:36:58 +0300 Message-ID: Subject: Re: [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization inside rtld or in static builds To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 12, 2023 at 12:23=E2=80=AFAM Samuel Thibault wrote:> > Sergey Bugaev, le mar. 11 avril 2023 23:27:35 +0300, a ecrit: > > On Tue, Apr 11, 2023 at 9:57=E2=80=AFPM Samuel Thibault wrote: > > > Had you actually tested it on i386? It seems to be breaking the > > > testsuite completely. I would expect that a submitted patch series ha= s > > > gone through the testsuite. > > > > Ouch! > > > > I have tested that it works on i386, as in I was able to run bash and > > apt with it. I'll re-check whether it (still) works, > > Yes, some things work, but some others don't :) > > > I have not run the testsuite, because: > > * I'm cross-compiling > > You can probably push your tree to a box where you can compile & run? > > > * I never managed to run it to completion on the Hurd in the first > > place... but maybe you have already fixed this. > > I have marked various tests as unsupported, yet. Alright, this went much as expected. First it took an eternity to compile (SMP support can't come soon enough), and second, the testuite has brought the system into a bad state and didn't complete. In particular: it managed to terminate my SSH session several times (I don't know how), and eventually it ran into that networking stack deadlock (the only way out of which seems to be reboot-hurd on the console). So I still can not run the testsuite on my end. But the tests that did run seem to mostly have worked. There were some failures here and there (I don't know which ones are expected), but nothing as bad as every single program crashing because it starts using TLS before it's set up due to already having switched to libc.so functions. Could you please point me to a specific test case (and not just "run the whole thing") that started failing because of this change, and teach me how to run just that one? I have read [0], but that says, "To test just one test you have to have already run the entire testsuite", which is a non-starter. [0]: https://sourceware.org/glibc/wiki/Testing/Testsuite#Testing_just_one_t= est Side note, I don't know why it's glibc's test suite that brings the system to its knees. glib's, which is also quite comprehensive, completes just fine. Would it have been easy for me to run the full test suite, I would surely do that before submitting any patches. But it's not. Sergey