From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by sourceware.org (Postfix) with ESMTPS id B4D003858D28 for ; Mon, 19 Jun 2023 08:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4D003858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1a998a2e7a6so3717621fac.1 for ; Mon, 19 Jun 2023 01:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687165066; x=1689757066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h93PrGOt1daJc34Z+Ycrf0dzuOLf/TjE9EK/edlySH0=; b=ovHsuN3PQZylwDjxiGLpg6RrkP/AZwK7ONCeZASIjuflSyo7n9pxhLc/ZjrkvMTTlU 4EQAW3n4NfJnsWmbbkP1fvrJYHveGRzCbOjLTr8p1agSqw9R+1sSLdLtD2cETr+shkef g/LFRYoGIGSszA2ozvmC1yQli2rjGbTqK2hdgRgxciU9SV43nsSpS7Gw4rG0Jfs+FA85 VgG/jNgzpDJNZBH3fUadXdUatUcO7IJ3XyKT9Ik/7H+sdHsunaheBL8ZKguzaU4zA+CD 13km/aj+/gQgy9M7+s5v/80ahRwKBlXEHIYmeWMKxQykUA/Fif7/9NZzNF7XH/L1cYW2 Zkgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687165066; x=1689757066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h93PrGOt1daJc34Z+Ycrf0dzuOLf/TjE9EK/edlySH0=; b=eHOCoHDmvgsQO7zzjOKnCka+nVJCT7wyGqqYzfXoevhdJmKlg7JydBMk0w7JlZqIm/ 3BOPo9t2kpak96NmdM/xjvIH6CKxUCILIipmxAJjy0gyctDJ0U5bELBcMCIn3fXUc/Py dMcwcoXIQE3GmJXgLLPKieJJ3djR5JA3khCHYLlE1Ef0XyJDZZUV105SOrfIpUarxaf7 hkWBhCGHtaKKMscXxWHWaGPsHTe1WYUMx1F0fSfpr5QG4iDlUmox0H+k968IsN3OR0H1 Iyan46MJbo98nuraA71GPmfv4jo8cUyktKOghOtKptfGWH4Hk8jeLl4eqPsNL8FmHYZD TnyA== X-Gm-Message-State: AC+VfDzlahv6i9INbHAbRl492iWDuu9ZENMR2eR4kJ/SE78xsW7gWs0C uI1Sn8QlCMQ8SGsEq2DXlOkQeqXRexVAlx+TrFo= X-Google-Smtp-Source: ACHHUZ4JBOfQR6a3mwYCU0u+y1fsYEkYk38cW3cwR4WQDX8RAixaAjmG3HzCI0PoAajflD+sQbzw9SpS1XNuidhZVVo= X-Received: by 2002:a05:6870:1846:b0:1a6:9788:c8dc with SMTP id u6-20020a056870184600b001a69788c8dcmr331628oaf.47.1687165066481; Mon, 19 Jun 2023 01:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20230604204258.2026816-1-bugaevc@gmail.com> <20230604204258.2026816-3-bugaevc@gmail.com> <9c2a4fb7-5b9e-94ac-dedf-b3fb29529650@cs.ucla.edu> <20230618215536.bd64s5bskinzeyv5@begin> In-Reply-To: <20230618215536.bd64s5bskinzeyv5@begin> From: Sergey Bugaev Date: Mon, 19 Jun 2023 11:57:34 +0300 Message-ID: Subject: Re: [PATCH v3 2/2] Use O_IGNORE_CTTY where appropriate To: Samuel Thibault Cc: Paul Eggert , libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Mon, Jun 19, 2023 at 12:55=E2=80=AFAM Samuel Thibault wrote: > > Samuel, what do you think? > > It looks better to me to add a shared helper that adds O_IGNORE_CTTY > whenever the flags contain something that implies it. Callers of > _hurd_intern_fd / _hurd_port2fd can then easily use it That's exactly what I was thinking, thank you. > (or even just > always pass O_IGNORE_CTTY, when creating a socket for instance). It does that already, yes. Sergey