From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id B2D093858D37 for ; Mon, 3 Apr 2023 09:27:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2D093858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x332.google.com with SMTP id ca2-20020a056830610200b006a11ab58c3fso14592294otb.4 for ; Mon, 03 Apr 2023 02:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680514026; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8SGt3r1LCsGp6k8RB5HRrY5zTMIpLBFEgyOmz3hYhY0=; b=l82rSaz+lBgU5IeASJwx6BqhadriKXsTU4Jihv+AJfkA8QnsvWXR7z7Xgad5rgNGnp pLwNcGICEFnaTMKfKpStn9HBWWlTAtOBUyVo//7XI4uTOD55wS6RExK5doVO2lqNb9Id sSZ+WgS1W5t/pISZ+lf+lY6tLa6L4zy5dyUzMiGUsXbYPC1TKrC9hJrT0W5zRJAyIG+Z tXMyAArXs8ByVqPZtlRKhbzrvUJiH8W7bzZAdFpP7JY6B5C45baQcO+/tiga2/rPibwd b1wAUabqyzrC7kuBJ1B6mUwW3s74bTdmD4Y7nbKToSPKtVAyklUhmagbp12tMVwxLXH5 s4gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680514026; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8SGt3r1LCsGp6k8RB5HRrY5zTMIpLBFEgyOmz3hYhY0=; b=4M3Y4Cm7Pnv5mEbvVLGTLgHYm1cV/IGsbEusrHAERdApA2TBCRYcKHke84viM/0Ikf t3A97PNCNY3JB2V+y5ZZAf/V34WjmBZd5ewL3k3PP4vKZTtZWJCwQRi0aakQG9NuT2LT ofGoVePUzJD5fcVcxJ92FgY/iT9xVLe11Wf4zsDw1W65YoISkrAIWGZXvhKQ1x6VLUyR h1TeS4tbUxR1NFCKAVtV2EqKvtY8P84qalSiIMOTolAi0m0LjFeLfeGgMtCRt3Nx1dH8 qWHFw/wPJjdZOxkcm7f6Ux5bz9Z89RXCc5pPKFPl4So0SKOEAhL9rx36RDWHVV2tKv6D PAkw== X-Gm-Message-State: AO0yUKU02aDuYobsSDoZruiWi0GCsSyJcxCuH6W6Kua8Sl4Pfmzet9kd RCvlvR71GMqbFWU7ZqEv5yC4AH7uQ5dwtQMHjLnQhTCIB94= X-Google-Smtp-Source: AK7set9geN/0GmY+dw9h6pXh1/mh8yCF1yMFXuH4kMJoFgK0cD4ILj0OiPOdwxAatVbuYOYwTh1Asja/miFYrZ0UhTM= X-Received: by 2002:a9d:67d0:0:b0:68b:cd1e:1ef1 with SMTP id c16-20020a9d67d0000000b0068bcd1e1ef1mr11854286otn.7.1680514025933; Mon, 03 Apr 2023 02:27:05 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-24-bugaevc@gmail.com> <20230402232028.ub4vsrnhjcphah2z@begin> In-Reply-To: <20230402232028.ub4vsrnhjcphah2z@begin> From: Sergey Bugaev Date: Mon, 3 Apr 2023 12:26:55 +0300 Message-ID: Subject: Re: [RFC PATCH glibc 23/34] elf: Stop including tls.h in ldsodefs.h To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 3, 2023 at 2:20=E2=80=AFAM Samuel Thibault wrote: > Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > > Nothing in there needs tls.h > > Ok but includers might be erroneously relying on it. Did you try to > build various configurations, to make sure that this isn't breaking any? There (unfortunately) still are multiple other ways that ends up including (in particular through ), so this change should not immediately break anything. See the cover letter for some more details about this. That being said, it sounds like glibc would benefit from a run of https://include-what-you-use.org/ over the code base. This would both trim the extraneous includes (such as this #include ) and add the ones that are required, but (as you're saying, erroneously) not explicitly mentioned. Sergey