From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 0A1463858C50 for ; Mon, 15 May 2023 15:28:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A1463858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6ac8ede63ccso2524052a34.2 for ; Mon, 15 May 2023 08:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684164486; x=1686756486; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VO21Mi2SFyluxpd3b1u+hQin3wkv3ITuXTVw3166nL4=; b=kW2Z+V49ORqjR/ATdkgx5q8yv8eTrgW4nyL+Nz4amcwJ8/8U4gpzWaxkNN64sUNSGV +ey78O+Xv+eDLCqbftbJYFSq92w4emEANM54DfWJFfjw9FsTRGsgItqhrDT6aiD1Yf0k mt7Vk+5ZtQNvkomtiyMT+JQsLHhnsjDrtUAZBlLPW6nPMXE7GjbdHt4CgCp+HHAGH8MS RQQMxq4BalFBn0or1Xp/INPcyD4iKNa/TFM0DmlfHYi+ni8LHWFf/Zv6z6S/232CTeCV P2vewviaoA7HDysNtfrK7uaWQVC0Mi6ktFU52vh7GUc4RYHi8rV4uBfhPkEiNbjFVr4c PAXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684164486; x=1686756486; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VO21Mi2SFyluxpd3b1u+hQin3wkv3ITuXTVw3166nL4=; b=ktQ5abtQEkBGr1wCRIb905J/XNHmVf32kCQ+fv+arMah28yl+Z/uH80ULWymOuh9mQ BUjY/j5LPOO3SUneYyJuIvBixl1xt4Z1UrrEPVGLueKHJj1knz2v4SWrLq/WUHSKy1jm mSlWyeN2V8ewvgOQcnsfjprUUY9PuA9+SQn2SYQUhyeCg1WMU14QMdebTv/H/mvc56i7 5zVWWwLrE1bWArAeehf/8dzm12hrx4MK7n/bQ7JtAu6aOr9aBjIcQK/8M0MQiz0ZIZjw WSy2Be9D0kx3/lMy4irua6afiNM4fqVjzqTKpWgUpsl3RkS1t36wpm1kqYVf/vIAhWM7 ZZjg== X-Gm-Message-State: AC+VfDz/YvFGf0PHDw8+8WWe0lgEnhTL8XqpUQACHQ3BpGp3oUBiqmPT MMs2YpfKgQJ4CDYqciSUgKXsh0dPOM6X6fzGm/U= X-Google-Smtp-Source: ACHHUZ7pQn+JZFV5LXB4iWljXTHjkeFmQY5yUVQJIeaRgMkIiS2TWXfRNYuOjw8bFQjI3IQ3pyNmsY4cWZVqCM29Ktk= X-Received: by 2002:a05:6808:53:b0:384:374c:43c7 with SMTP id v19-20020a056808005300b00384374c43c7mr10356869oic.25.1684164486134; Mon, 15 May 2023 08:28:06 -0700 (PDT) MIME-Version: 1.0 References: <20230515144815.3939017-1-bugaevc@gmail.com> <20230515144815.3939017-2-bugaevc@gmail.com> In-Reply-To: From: Sergey Bugaev Date: Mon, 15 May 2023 18:27:55 +0300 Message-ID: Subject: Re: [RFC PATCH 1/6] Mark more functions as __COLD To: Andreas Schwab Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 15, 2023 at 6:22=E2=80=AFPM Andreas Schwab wro= te: > Any reason you replaced _Noreturn with __attribute__ ((__noreturn__)) > here ... > ... but did the other way here? Thank you for spotting, that was not intentional (in fact I thought I got rid of the noreturn tweaks when git add -p'ing... evidently not entirely). I *think* the _Noreturn form is / should be the preferred one, both because it's actual C syntax, and because it's defined to __attrbiute__ ((noreturn)) only when the compiler supports it? Sergey