From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 622243858D32 for ; Thu, 13 Apr 2023 13:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 622243858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x231.google.com with SMTP id cd20so3518534oib.0 for ; Thu, 13 Apr 2023 06:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681392061; x=1683984061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hyfrKYmnG3xh+BlFgn5Wms7aXF2rYw3LuBrNnQOFnVs=; b=lD/EmD2fMF9AWNHdDYJpOOyQMsn7jCtSWNJ2J6CX9bc46HnGSel+ICLwnzLW3fTgik zzBZmHzSKrobBK9owaEUXRWrq83QJ53310+D+GCuSNEU00s3LJuC4XMfDS4GIW8aD8Ox g0oTThO1FHkWWtxS1VEaSDgsXLw/BUC7JwLUwi3N/UquvvYv9aEZHPP7lD5e1+B0ZEw/ 7ag+l27kmMGiUwiDUzAlwDUpOB5qAJFa+YXoEWibKH61HDmBYTS2wQz27A+Ltb2n85oA CFh/qN+UxMhsuyy5bpCzMoMf8cAO58yF+Uq3Hp7CVWh6vqk9VvNfciIiggYa43VV4/un wpUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681392061; x=1683984061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hyfrKYmnG3xh+BlFgn5Wms7aXF2rYw3LuBrNnQOFnVs=; b=E/5hMPLD+sQYV/DBK18KRWEQafhkzYXsRboDf5QAe9z75iHG5OANiUDVV1tYO9Ff9T UmEB0vLx7TfMXJjR0Hk41oq0Q2QPqyT1fMUYj46ZCMcFqW8pw4J8FWpW87Lzs15l4E2H hGPus3e/d54zrbA1zYFM0/WgSYAGDeOtOnoqV6SMFZ/LESFWzJZ1EvqBQpoldMjyVHho EEcfyh8oxwhCWYiCVfDC3pRGtFEcvU1IjfztbIpq3h0/xNTw2v+gyCR5cQjJbHZnXWo6 Z2i2iO/Qq4idakK7WUaND0nyG1M1V1u05pvj4BGdOKKy52O8ovBvZvaiV14t/K3fdXsP P6pg== X-Gm-Message-State: AAQBX9cMR+z5R/9LSwfmZ+Mka4LfCmytCoI1MhwSgnrpcI10MMAChic+ xLUuh+DjA6k88PXKedbWNcP6rY0gv20AQjwgK2utJLP1crM= X-Google-Smtp-Source: AKy350YBlwMUQFyJtqCJChlvcfB3IMWBnFDiJizRPcMhtVXvHglGEpyVjQBSNsF/JSY6t9uN+mUjB4oeueAtbCXLtHo= X-Received: by 2002:aca:1a0b:0:b0:384:420d:6671 with SMTP id a11-20020aca1a0b000000b00384420d6671mr387204oia.5.1681392061533; Thu, 13 Apr 2023 06:21:01 -0700 (PDT) MIME-Version: 1.0 References: <20230411201845.oias7lryrvm3cck7@begin> <20230413115812.267158-1-bugaevc@gmail.com> <20230413131227.oiotppbcxrpwl7l2@begin> In-Reply-To: <20230413131227.oiotppbcxrpwl7l2@begin> From: Sergey Bugaev Date: Thu, 13 Apr 2023 16:20:50 +0300 Message-ID: Subject: Re: [RFC PATCH glibc v2 26/34] hurd: Remove __hurd_local_reply_port To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 13, 2023 at 4:12=E2=80=AFPM Samuel Thibault wrote: at ../sysdeps/mach/hurd/dl-sysdep.c:241 > 241 __mig_dealloc_reply_port (MACH_PORT_NULL); Uhh, who deallocs a reply port like that :| You can't pass random crap into __mig_dealloc_reply_port and rely on its particular implementation, which *happened* to deallocate the current port. Apparently FATAL_PREPARE in dl-sysdep.h is also defined to do the same. I'd rather fix these both to do __mig_dealloc_reply_port (__mig_get_reply_port ()); but we can also explicitly support passing MACH_PORT_NULL to mean "dealloc whatever you have stored", i.e. the previous behavior. Which one would you prefer? Sergey