From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 606993858D32 for ; Mon, 24 Apr 2023 21:13:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 606993858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6a5fe1ebc42so2123393a34.1 for ; Mon, 24 Apr 2023 14:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682370815; x=1684962815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4VnQcnsI9SfVKHcIcRENWUjIb0VOfPu/+ubdnh+ucIY=; b=haCG3RpI8VN+tCRtQDsel1ohBwEOoKLMtO6hKwnkTkyTZ99gBIkkU48fF7+OcIoHoS PpOq5dJjoR4gOYD1+02RdSRywsS2K+AudKK0lNpBLj3/0C9M+0Jghu+nrRBfD6pSxirQ 6FVvKabRF29IyyX3JrET0ZQCCZyjmnbH77wbmrj+H1cAHwqWfIJTZsBuoea+sPKzmjtX 5t5jS7aXjQbQhPZwIFDAm0QmDxVD8K1bktyp1Qi7uy+K/BpItCuiq1GlQMSzG5K55OND AsETelz6jXJy1wKwWlbA8rFxgmDl5uW7qv2m06rtZ1sHIoAo1RFXrGAaxEN5K2ENnjr/ t+tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682370815; x=1684962815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4VnQcnsI9SfVKHcIcRENWUjIb0VOfPu/+ubdnh+ucIY=; b=AQe37ALcdb/J8QWlhPT7+yBokzSLkf+U0ttvHNScMi4qOMA2o6y2QC8ZewzamxMTF0 Q229OVjrSGBOovVppC+0oVicFbjfeJFEvz3TQepTOZKfSjEdevGMROj8DbTNU0RNzvvL aYDwhmzakUS9h+qWtp5bP2dD2FnxN4zEyBYhs89qWpkvHyni/8Boxjeq9LBgnJnxrLpc CEprZCmwhpcZ9z6+/z12sUthExFzeIKIYA/4dWEKrDmC0YCZFMSsIxrj8smVKtM8Q7/Q 3HwhvUrdoatM88ntJGIVS+AYV5gnrx9O/jZXDOVvyIJf+t6YFmOfFuRd7kU5aR6NVqhq XpVA== X-Gm-Message-State: AAQBX9f7F8L1ErZnAQ9Ynlp6H4ShlXPOgGYCduk/c6YLVXhrHtJoJjje Fpfy3xlFkRaKQs5fO+DTt+h4+lReemFhS+3EVwE= X-Google-Smtp-Source: AKy350aCuB4xmcnnyGXFPJgQ4f7APRHwprxWPzAUW83yfwRLS9i1Dl3eWc3o+zM+aeT5oPrWv1vmp9SahVgmUHlk0DI= X-Received: by 2002:a05:6870:e749:b0:187:aa17:5ebb with SMTP id t9-20020a056870e74900b00187aa175ebbmr10147846oak.47.1682370815627; Mon, 24 Apr 2023 14:13:35 -0700 (PDT) MIME-Version: 1.0 References: <20230423160548.126576-1-bugaevc@gmail.com> <20230424210159.xdmwk5oqfflwph2k@begin> In-Reply-To: <20230424210159.xdmwk5oqfflwph2k@begin> From: Sergey Bugaev Date: Tue, 25 Apr 2023 00:13:24 +0300 Message-ID: Subject: Re: [PATCH v2 1/4] hurd: Don't pass FD_CLOEXEC in CMSG_DATA To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 25, 2023 at 12:02=E2=80=AFAM Samuel Thibault wrote: > The two patches actually make me realize that there was a confusion here > between FD_* flags and O_* flags. _hurd_intern_fd definitely takes O_* > flags (and translates O_CLOEXEC to FD_CLOEXEC). If we are to transport > some flags, it'd probably rather be O_* flags. I'll commit that way. Right, good point. Sergey