From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 0361D3858D1E for ; Mon, 10 Apr 2023 19:07:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0361D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x231.google.com with SMTP id e9so3795225oig.7 for ; Mon, 10 Apr 2023 12:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681153664; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WLq7POZ7Url1xgILrnWFSOWLnMhoeCZYqxIH5SdHxlY=; b=hWr6r/OPfcGpInhxdENhNb4Nw/YILuaUm+HeIA7WV3B2+K2h3OK3vlTMlqv1z4jAIE hjxPZ9mpOGh8+gVkfDfeTuWyaEOLSeL9a7N0rDpK1ymfwYm86GAr6TeeVnNiegdMMqkD IK0Mlf6ZKYvkja+mXMNZBB5HBU00y442RCxM33OeBN/hdACjpTP2deX7cfcaiJaFQpeG 09Ax2QiU5ympdIMVy8qwOWiZgZwL+ZM92hFXOJhAiFPS5JNsUstbRmgaUd/nQtoZGLSz 7tF9vt9D6pMvjrRVKP/RlH6ANcbDyQjm/6K/p992wR6fycyJ2IX4RaJ6fVYISUWm138T ApSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681153664; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WLq7POZ7Url1xgILrnWFSOWLnMhoeCZYqxIH5SdHxlY=; b=1z041hrq7u/JADek7yfcjtfdQxRDIlCSGZv3mK2Rc3aVCZ9m+4PJftH+9v5zjonZ67 9ed7Q1fVrKqjQSkqIOzsT8+2Ek2cdwD6QcFHmuMkaiPECqBKtd1qN+RJlObFLh0ZHTbM HgjzXUQ9+uQvo6HYSeBKiN85aurNOs6LrhNHOo8Tl2UUjLrl9Cx+xfDvtIhgu/75vMO7 36iaN64FLwOLLCmCmdIca57Ngj313DQC4sc9c9FUztUNWmBHwdJykDFd2dTMayKc+Y0P OMFWAni86GNIvU1xNqFDuXtNPEqrmKKO3zHNZksQwEYygOz0DqMpDR7HFLQ0SGU/uood EXfQ== X-Gm-Message-State: AAQBX9erMuufRWEam+pi5LXgSFeGdk1XJAhXTcM+M3zm2LbI+GSIdd1T SXHGWB9t/0Fk6JzvXgCoBHqaoUUQR1fsO7u6Ba6zBFWtRjE= X-Google-Smtp-Source: AKy350ZcZFxGTUZw7/kXAuNJD0xNmd2RdOEka5zhOkR2O5x4Ib8uYDy/wKNwtcoRJQAckqOfQ+vfuozRGTAePZYkThw= X-Received: by 2002:a05:6808:4282:b0:386:cb70:3828 with SMTP id dq2-20020a056808428200b00386cb703828mr2708918oib.4.1681153663899; Mon, 10 Apr 2023 12:07:43 -0700 (PDT) MIME-Version: 1.0 References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-17-bugaevc@gmail.com> <20230410183907.7w55cg675fgoae6k@begin> In-Reply-To: <20230410183907.7w55cg675fgoae6k@begin> From: Sergey Bugaev Date: Mon, 10 Apr 2023 22:07:33 +0300 Message-ID: Subject: Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64 To: libc-alpha@sourceware.org, bug-hurd , Samuel Thibault Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 10, 2023, 21:39 Samuel Thibault wrote= : > > Hello, > > Applied, thanks! Yay! Thank you for finding the time to review some more patches! Here's to hoping that the rest will follow. > Note that I have pushed sysdeps/mach/hurd/x86_64/sys/ucontext.h to > sysdeps/x86_64/sys/ucontext.h since it's not mach-specific, and Linux > has its own for x86. It's not technically Mach specific, but it's arranged the same way as Mach's struct i386_thread_state, and code in hurdsig.c relies on this. If, say, Flavio would have arranged registers differently in gnumach commit feba9b7b1d88e505feb6579e41dc45e48c264e6f =E2=80=94 say, put rdi & rs= i before the r{8..15} gang, like it's done in the 32-bit version =E2=80=94 th= en ucontext definitions would also have to be different. So while it could work for any port (provided it doesn't care about the ordering), putting it into the generic tree underemphasizes why it has to be arranged this specifically. But it's up to you, of course. Sergey