public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Sergey Bugaev <bugaevc@gmail.com>
To: Flavio Cruz <flaviocruz@gmail.com>
Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org
Subject: Re: [PATCH glibc] Define PC, SP and SYSRETURN for hurd x86_64
Date: Wed, 15 Feb 2023 09:42:36 +0300	[thread overview]
Message-ID: <CAN9u=HdpjfL+Xz5JGMBJZ3hcH-v_3ERoDdzdbKB5nN3QM4ZKVw@mail.gmail.com> (raw)
In-Reply-To: <Y+x4xrsDMkAomncO@jupiter.tail36e24.ts.net>

On Wed, Feb 15, 2023 at 9:17 AM Flavio Cruz <flaviocruz@gmail.com> wrote:
>
> Moved thread_state.h to x86 directory since we only need to customize
> those 3 definitions.

No, that won't be enough. We also need to customize those
MACHINE_THREAD_STATE_FLAVOR definitions to include the potential new
i386_FSGS_BASE_STATE that we were discussing recently [0].

[0] https://sourceware.org/pipermail/libc-alpha/2023-February/145528.html

I was just looking at this file yesterday and concluded the
MACHINE_THREAD_STATE_FLAVOR / MACHINE_NEW_THREAD_STATE_FLAVOR
abstraction cannot work as is for x86_64, because half of the time
it's used for indeed accessing registers like SP and PC, and other
times it's used to access TLS/TCB. So this needs to be two distinct
definitions, and all the users inside glibc have to be reworked.

So let's please not rush with moving this to x86/

Sergey

  reply	other threads:[~2023-02-15  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  6:16 Flavio Cruz
2023-02-15  6:42 ` Sergey Bugaev [this message]
2023-02-20  0:33 ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN9u=HdpjfL+Xz5JGMBJZ3hcH-v_3ERoDdzdbKB5nN3QM4ZKVw@mail.gmail.com' \
    --to=bugaevc@gmail.com \
    --cc=bug-hurd@gnu.org \
    --cc=flaviocruz@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).