From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 833313858D20 for ; Tue, 8 Aug 2023 18:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 833313858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3a76cbd4bbfso4720701b6e.3 for ; Tue, 08 Aug 2023 11:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691520031; x=1692124831; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HHLlb8KE5hCX4H3P4N0qWp3XF+zc+5qa0Yb8dQBNmEw=; b=HS3Mmngpmdd8Sj+bkXgqo4cxvIG0MN3TD0zHbyDN4smAybdPAV3W7AbHxp8+4E/Z9W OB9lYb8a7TSQtXHCvts5E1dBVa+CVG/4VVKdrKjV+95uCKvEH+AvVoslMF4WYIEloV4e S2ye5Kzze0WSvKBJ0k1qaGmKkGntpCpggkw02gNnXyslYxx5D5Ji5qQQpEYGLdP5JCNb p5Zsw5HwwZ2k0kJNLgdCXZ9MsqxtIWCdWXaSWcK7Uxopt/blND09dczq9/kes7QMdzfb N0Hj0oQzN9x3jOjpnzg0fGVgXUcPxewKAm4WnbAORIKsYPuEvGvnqhG1sqqw/IH8xE71 8jtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691520031; x=1692124831; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HHLlb8KE5hCX4H3P4N0qWp3XF+zc+5qa0Yb8dQBNmEw=; b=HDUFfn8mRO1rsPr2ggqiuMFZwLVHkXlAQjQO7gjqL7FLAUmkTthNIzr5/GCpWce+py 0z5iX8Wxw4KDBKKWQ6IDCAQvvpvSXv7OHRA9sQDrHUjgJXMU3BlBla7roQlt6k/KOzG6 U3RhQZQC0C3ezLEFjIPXZ+I7wQjIXPNo23EbieuiV4ZzNCRqTfGW285fhfJjqy1w0kXO q0qT4W8nTYOnGxwqPXNG9K8OnYmCNA+bLRoR0N1vEf/JtArsy3D7UauMxD1Oe5M1g1kY Itzgc63llTX7I8Wlf1Rlc6H7djxv4N/4ws15XWN+GCaLvuGzqtaWpR4pqOflPQ5hPBvq sa5Q== X-Gm-Message-State: AOJu0YwaePAlbKID+g+RXCW0Vk0ixd108U8Qn/pfx88qwgMh0p+fdxdr Rwn1AUJcgUy6U3Dv5LzsUnPA9MadEgxSKQkoun8= X-Google-Smtp-Source: AGHT+IEv0GD+/p+FyJWsjFowgEtvL/B8lrR+MRjSQehwsSVMSeYZIPEL2Q3o8aMA84+0IgWw4TjwmKQxYcasXPCGBg8= X-Received: by 2002:a05:6808:2a65:b0:3a7:805:d42e with SMTP id fu5-20020a0568082a6500b003a70805d42emr510796oib.15.1691520030657; Tue, 08 Aug 2023 11:40:30 -0700 (PDT) MIME-Version: 1.0 References: <20230730192605.2423480-1-bugaevc@gmail.com> <20230730192605.2423480-2-bugaevc@gmail.com> <48e0343a-e683-6137-b1a9-139a399b8020@linaro.org> In-Reply-To: <48e0343a-e683-6137-b1a9-139a399b8020@linaro.org> From: Sergey Bugaev Date: Tue, 8 Aug 2023 21:40:19 +0300 Message-ID: Subject: Re: [PATCH v4 1/6] Fix calling fcntl64 (fd, F_SETLK, &flock64) To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org, Florian Weimer , Frederic Berat Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Mon, Jul 31, 2023 at 8:50=E2=80=AFPM Adhemerval Zanella Netto wrote: > Nice, it seems that on both tests the fields that might trigger wrong val= ues > by the kernel reading the struct with a wrong size (l_start and l_len) ar= e > always being 0 and thus it should not matter. > > LGTM, thanks. But please note that this only really fortifies tests & other code that uses the public fcntl/fcntl64 API, not callers of __libc_fcntl64, so it's not a guarantee that there are no more cases of this. Though I guess this applies equally to all the other fortifications. Sergey