From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id 07FE7385840E for ; Tue, 23 May 2023 20:44:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07FE7385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-55239f43426so145867eaf.1 for ; Tue, 23 May 2023 13:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684874655; x=1687466655; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z7JrslP5vwZNaeDKSUrxgcXv9aIMTsxZLbuOpiR9OCk=; b=J2y9c2t/GB5Ih2SS9UZcwbZVrV6I96gTc5viicv5MYIfSVjgD2WRNjHoF4MOwyYjZJ 4jSgbs+OFR2fQrX4fxri6zoOOA2WNbxyFq5TD/jKdJigwqFxtj+r9SeqzGd4vJeowXn+ EknaALc8N477zq6zHaldWa4BYrHXuMrOTSYQzRKnMyi0xQQTAisgcWVLXcEH/bb+WEQd O8KmcQ26op3RYnPQcH66IHJSRy1YapWnNmcGepS64vSF5JZnrWzJvE11IwuwlnB8C0Kj qVP48UZpPAt+GNL0+HfEqtEy6ll88b5B609TuwPiiqugZI3pzqguamqQeFnTRdUcr2TU QpUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684874655; x=1687466655; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z7JrslP5vwZNaeDKSUrxgcXv9aIMTsxZLbuOpiR9OCk=; b=dKsX3jwK/D3LuR5QzA7gUz9SYmieBNsBlTGah6SBMk06NEyjAeFRIk2PqyDJnwbijD t9DVETMKpQuPen3tSvayQzj3lv12z3lWFM7xd4EOrPVqBwDtSfHjS9Ecuuu3zZ6Q/S4o kGmrKk8irT1FAG+3GDRWMUnR8k4a7eROjac67DIFUIKbaHRTPuQwBgGIo5nhUhY7NGgq JuaYESK37fV2/d/58sUT8C1k5b8pGTDZEZ2U/J1W+LiFzxlXwksJ9uEYrnU4v0FLfXoT iKzZsg4UFKEQVmWQlHXIG5PX1Sptb0IsNk37PDatrMTLVEOZAxlXQPm/FND3Dx2QbVQ3 xr/w== X-Gm-Message-State: AC+VfDzHmYIWV6NW89Jhbw4cXXm3pWuGdy4eXDc868jhWIMChes/HFjY KtczOyxt+IpjfiWFhiZ7lu/lIwUy0VbM4r1nlrgDqa5G X-Google-Smtp-Source: ACHHUZ46QHY6we4m1y9jxbyDc5nX3NU5awhhNDckz96ek7R5R0iKdHTDBccFjIvaIU5aNirtC2pKfalpy6HIO96nwdU= X-Received: by 2002:a05:6808:a07:b0:392:56aa:f58b with SMTP id n7-20020a0568080a0700b0039256aaf58bmr7772707oij.33.1684874655239; Tue, 23 May 2023 13:44:15 -0700 (PDT) MIME-Version: 1.0 References: <20230519213059.3812385-1-bugaevc@gmail.com> <20230519213059.3812385-2-bugaevc@gmail.com> <0b512019-09ab-9f25-57d6-cf6fd19be8f3@linaro.org> In-Reply-To: From: Sergey Bugaev Date: Tue, 23 May 2023 23:44:05 +0300 Message-ID: Subject: Re: [RFC PATCH 1/1] io: Add FORTIFY_SOURCE check for fcntl arguments To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 23, 2023, 23:24 Sergey Bugaev wrote: > if what you're concerned is what the _2 functions end up calling > (__fcntl_time64 vs __libc_fcntl64), then it does not matter because > they're only used for 2-argument variant of fcntl, which can not > possibly deal with any time-related structures (nor any structures), > exactly because there's no third argument where a structure could be > passed. The 2-arg variant is basically for simple getters that return > an int. And now that I think of it, there's also no reason to have separate __fcntl64_2 & __fcntl_2 functions either, is there? Sergey